ipmi: ipmi_ssif: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Message-Id: <c8a6cd95ad7a8220e211373c44cdaba2a8c06052.1709655755.git.u.kleine-koenig@pengutronix.de>
Signed-off-by: Corey Minyard <minyard@acm.org>

authored by Uwe Kleine-König and committed by Corey Minyard a69da502 f99a9965

+2 -3
+2 -3
drivers/char/ipmi/ipmi_ssif.c
··· 2071 2071 return dmi_ipmi_probe(dev); 2072 2072 } 2073 2073 2074 - static int ssif_platform_remove(struct platform_device *dev) 2074 + static void ssif_platform_remove(struct platform_device *dev) 2075 2075 { 2076 2076 struct ssif_addr_info *addr_info = dev_get_drvdata(&dev->dev); 2077 2077 ··· 2079 2079 list_del(&addr_info->link); 2080 2080 kfree(addr_info); 2081 2081 mutex_unlock(&ssif_infos_mutex); 2082 - return 0; 2083 2082 } 2084 2083 2085 2084 static const struct platform_device_id ssif_plat_ids[] = { ··· 2091 2092 .name = DEVICE_NAME, 2092 2093 }, 2093 2094 .probe = ssif_platform_probe, 2094 - .remove = ssif_platform_remove, 2095 + .remove_new = ssif_platform_remove, 2095 2096 .id_table = ssif_plat_ids 2096 2097 }; 2097 2098