Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

matroxfb: get rid of CONFIG_FB_MATROX_32MB

CONFIG_FB_MATROX_32MB is always enabled, so there is no point in having
ifdefs all around. And it is bad practice to use CONFIG_* as a name for
something which is not a Kconfig option.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Acked-by: Petr Vandrovec <vandrove@vc.cvut.cz>
Cc: Krzysztof Helt <krzysztof.h1@poczta.fm>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Jean Delvare and committed by
Linus Torvalds
a690606d ee5a2749

-19
-2
drivers/video/matrox/matroxfb_DAC1064.c
··· 1080 1080 1081 1081 DAC1064_restore_1(minfo); 1082 1082 matroxfb_vgaHWrestore(minfo); 1083 - #ifdef CONFIG_FB_MATROX_32MB 1084 1083 if (minfo->devflags.support32MB) 1085 1084 mga_setr(M_EXTVGA_INDEX, 8, hw->CRTCEXT[8]); 1086 - #endif 1087 1085 minfo->crtc1.panpos = -1; 1088 1086 for (i = 0; i < 6; i++) 1089 1087 mga_setr(M_EXTVGA_INDEX, i, hw->CRTCEXT[i]);
-12
drivers/video/matrox/matroxfb_base.c
··· 310 310 { 311 311 unsigned int pos; 312 312 unsigned short p0, p1, p2; 313 - #ifdef CONFIG_FB_MATROX_32MB 314 313 unsigned int p3; 315 - #endif 316 314 int vbl; 317 315 unsigned long flags; 318 316 ··· 328 330 p0 = minfo->hw.CRTC[0x0D] = pos & 0xFF; 329 331 p1 = minfo->hw.CRTC[0x0C] = (pos & 0xFF00) >> 8; 330 332 p2 = minfo->hw.CRTCEXT[0] = (minfo->hw.CRTCEXT[0] & 0xB0) | ((pos >> 16) & 0x0F) | ((pos >> 14) & 0x40); 331 - #ifdef CONFIG_FB_MATROX_32MB 332 333 p3 = minfo->hw.CRTCEXT[8] = pos >> 21; 333 - #endif 334 334 335 335 /* FB_ACTIVATE_VBL and we can acquire interrupts? Honor FB_ACTIVATE_VBL then... */ 336 336 vbl = (var->activate & FB_ACTIVATE_VBL) && (matroxfb_enable_irq(minfo, 0) == 0); ··· 338 342 matroxfb_DAC_lock_irqsave(flags); 339 343 mga_setr(M_CRTC_INDEX, 0x0D, p0); 340 344 mga_setr(M_CRTC_INDEX, 0x0C, p1); 341 - #ifdef CONFIG_FB_MATROX_32MB 342 345 if (minfo->devflags.support32MB) 343 346 mga_setr(M_EXTVGA_INDEX, 0x08, p3); 344 - #endif 345 347 if (vbl) { 346 348 minfo->crtc1.panpos = p2; 347 349 } else { ··· 1354 1360 #ifdef CONFIG_FB_MATROX_G 1355 1361 static struct video_board vbG100 = {0x0800000, 0x0800000, FB_ACCEL_MATROX_MGAG100, &matrox_G100}; 1356 1362 static struct video_board vbG200 = {0x1000000, 0x1000000, FB_ACCEL_MATROX_MGAG200, &matrox_G100}; 1357 - #ifdef CONFIG_FB_MATROX_32MB 1358 1363 /* from doc it looks like that accelerator can draw only to low 16MB :-( Direct accesses & displaying are OK for 1359 1364 whole 32MB */ 1360 1365 static struct video_board vbG400 = {0x2000000, 0x1000000, FB_ACCEL_MATROX_MGAG400, &matrox_G100}; 1361 - #else 1362 - static struct video_board vbG400 = {0x2000000, 0x1000000, FB_ACCEL_MATROX_MGAG400, &matrox_G100}; 1363 - #endif 1364 1366 #endif 1365 1367 1366 1368 #define DEVF_VIDEO64BIT 0x0001 ··· 1636 1646 minfo->devflags.textmode = 1; 1637 1647 minfo->devflags.text_type_aux = FB_AUX_TEXT_MGA_STEP8; 1638 1648 } 1639 - #ifdef CONFIG_FB_MATROX_32MB 1640 1649 minfo->devflags.support32MB = (b->flags & DEVF_SUPPORT32MB) != 0; 1641 - #endif 1642 1650 minfo->devflags.precise_width = !(b->flags & DEVF_ANY_VXRES); 1643 1651 minfo->devflags.crtc2 = (b->flags & DEVF_CRTC2) != 0; 1644 1652 minfo->devflags.maven_capable = (b->flags & DEVF_MAVEN_CAPABLE) != 0;
-5
drivers/video/matrox/matroxfb_base.h
··· 54 54 #include "../macmodes.h" 55 55 #endif 56 56 57 - /* always compile support for 32MB... It cost almost nothing */ 58 - #define CONFIG_FB_MATROX_32MB 59 - 60 57 #ifdef MATROXFB_DEBUG 61 58 62 59 #define DEBUG ··· 461 464 int nopciretry; 462 465 int noinit; 463 466 int sgram; 464 - #ifdef CONFIG_FB_MATROX_32MB 465 467 int support32MB; 466 - #endif 467 468 468 469 int accelerator; 469 470 int text_type_aux;