Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

pinctrl: pinconf: separate config parameters with commas for debugfs

To improve debugfs readability, use commas instead of whitespaces
for separating configuration parameters.

For example, the "pinconf-pins" dump on my board will change as follows:

Without this commit:

# head -5 pinconf-pins
Pin config settings per pin
Format: pin (name): configs
pin 0 (ED0): input bias pull down output drive strength (8 mA) input enabled
pin 1 (ED1): input bias pull down output drive strength (8 mA) input enabled
pin 2 (ED2): input bias pull down output drive strength (8 mA) input enabled

With this commit:

# head -5 pinconf-pins
Pin config settings per pin
Format: pin (name): configs
pin 0 (ED0): input bias pull down, output drive strength (8 mA), input enabled
pin 1 (ED1): input bias pull down, output drive strength (8 mA), input enabled
pin 2 (ED2): input bias pull down, output drive strength (8 mA), input enabled

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

authored by

Masahiro Yamada and committed by
Linus Walleij
a672eb5e cd8f61f1

+11 -7
+9 -5
drivers/pinctrl/pinconf-generic.c
··· 53 53 struct seq_file *s, const char *gname, 54 54 unsigned pin, 55 55 const struct pin_config_item *items, 56 - int nitems) 56 + int nitems, int *print_sep) 57 57 { 58 58 int i; 59 59 ··· 75 75 seq_printf(s, "ERROR READING CONFIG SETTING %d ", i); 76 76 continue; 77 77 } 78 - /* Space between multiple configs */ 79 - seq_puts(s, " "); 78 + /* comma between multiple configs */ 79 + if (*print_sep) 80 + seq_puts(s, ", "); 81 + *print_sep = 1; 80 82 seq_puts(s, items[i].display); 81 83 /* Print unit if available */ 82 84 if (items[i].has_arg) { ··· 107 105 const char *gname, unsigned pin) 108 106 { 109 107 const struct pinconf_ops *ops = pctldev->desc->confops; 108 + int print_sep = 0; 110 109 111 110 if (!ops->is_generic) 112 111 return; 113 112 114 113 /* generic parameters */ 115 114 pinconf_generic_dump_one(pctldev, s, gname, pin, conf_items, 116 - ARRAY_SIZE(conf_items)); 115 + ARRAY_SIZE(conf_items), &print_sep); 117 116 /* driver-specific parameters */ 118 117 if (pctldev->desc->num_custom_params && 119 118 pctldev->desc->custom_conf_items) 120 119 pinconf_generic_dump_one(pctldev, s, gname, pin, 121 120 pctldev->desc->custom_conf_items, 122 - pctldev->desc->num_custom_params); 121 + pctldev->desc->num_custom_params, 122 + &print_sep); 123 123 } 124 124 125 125 void pinconf_generic_dump_config(struct pinctrl_dev *pctldev,
+2 -2
drivers/pinctrl/pinconf.c
··· 310 310 if (desc == NULL) 311 311 continue; 312 312 313 - seq_printf(s, "pin %d (%s):", pin, desc->name); 313 + seq_printf(s, "pin %d (%s): ", pin, desc->name); 314 314 315 315 pinconf_dump_pin(pctldev, s, pin); 316 316 ··· 347 347 while (selector < ngroups) { 348 348 const char *gname = pctlops->get_group_name(pctldev, selector); 349 349 350 - seq_printf(s, "%u (%s):", selector, gname); 350 + seq_printf(s, "%u (%s): ", selector, gname); 351 351 pinconf_dump_group(pctldev, s, selector, gname); 352 352 seq_printf(s, "\n"); 353 353