Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ASoC: amd: acp: select SND_SOC_AMD_ACP_LEGACY_COMMON for ACP63

Without this dependency, acp63 fails to link:

x86_64-linux-ld: sound/soc/amd/acp/acp63.o: in function `acp63_audio_remove':
acp63.c:(.text+0x22): undefined reference to `acp_disable_interrupts'
x86_64-linux-ld: sound/soc/amd/acp/acp63.o: in function `acp63_i2s_master_clock_generate.isra.0':
acp63.c:(.text+0x6f): undefined reference to `smn_read'
x86_64-linux-ld: acp63.c:(.text+0x81): undefined reference to `smn_write'
x86_64-linux-ld: acp63.c:(.text+0x8e): undefined reference to `smn_read'
x86_64-linux-ld: sound/soc/amd/acp/acp63.o: in function `acp63_pcm_resume':
acp63.c:(.text+0x230): undefined reference to `restore_acp_i2s_params'
x86_64-linux-ld: acp63.c:(.text+0x23d): undefined reference to `restore_acp_pdm_params'
x86_64-linux-ld: sound/soc/amd/acp/acp63.o: in function `acp63_audio_probe':
acp63.c:(.text+0x474): undefined reference to `acp_enable_interrupts'

Fixes: d4c2d5391d7e ("ASoC: amd: acp: add Kconfig options for acp6.3 based platform driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20231027152403.386257-3-arnd@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Arnd Bergmann and committed by
Mark Brown
a65cdffb cf046ecb

+11 -9
+11 -9
sound/soc/amd/acp/Kconfig
··· 61 61 If unsure select "N". 62 62 63 63 config SND_AMD_ASOC_ACP63 64 - tristate "AMD ACP ASOC ACP6.3 Support" 65 - select SND_SOC_AMD_ACP_PCM 66 - select SND_SOC_AMD_ACP_I2S 67 - select SND_SOC_AMD_ACP_PDM 68 - depends on X86 && PCI 69 - help 70 - This option enables Acp6.3 I2S support on AMD platform. 71 - Say Y if you want to enable AUDIO on ACP6.3 72 - If unsure select "N". 64 + tristate "AMD ACP ASOC ACP6.3 Support" 65 + depends on X86 && PCI 66 + depends on ACPI 67 + select SND_SOC_AMD_ACP_PCM 68 + select SND_SOC_AMD_ACP_I2S 69 + select SND_SOC_AMD_ACP_PDM 70 + select SND_SOC_AMD_ACP_LEGACY_COMMON 71 + help 72 + This option enables Acp6.3 I2S support on AMD platform. 73 + Say Y if you want to enable AUDIO on ACP6.3 74 + If unsure select "N". 73 75 74 76 config SND_SOC_AMD_MACH_COMMON 75 77 tristate