Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[media] itd1000: Don't reuse core macro names

The dbg, warn and info macros are already defined by the USB stack.
Rename these macros to avoid macro redefinition warnings.

Refactor lineshift in printouts.

Signed-off-by: Hans Petter Selasky <hselasky@c2i.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

authored by

Hans Petter Selasky and committed by
Mauro Carvalho Chehab
a5bef1d2 f54ba7f1

+11 -14
+11 -14
drivers/media/dvb/frontends/itd1000.c
··· 35 35 module_param(debug, int, 0644); 36 36 MODULE_PARM_DESC(debug, "Turn on/off debugging (default:off)."); 37 37 38 - #define deb(args...) do { \ 38 + #define itd_dbg(args...) do { \ 39 39 if (debug) { \ 40 40 printk(KERN_DEBUG "ITD1000: " args);\ 41 - printk("\n"); \ 42 41 } \ 43 42 } while (0) 44 43 45 - #define warn(args...) do { \ 44 + #define itd_warn(args...) do { \ 46 45 printk(KERN_WARNING "ITD1000: " args); \ 47 - printk("\n"); \ 48 46 } while (0) 49 47 50 - #define info(args...) do { \ 48 + #define itd_info(args...) do { \ 51 49 printk(KERN_INFO "ITD1000: " args); \ 52 - printk("\n"); \ 53 50 } while (0) 54 51 55 52 /* don't write more than one byte with flexcop behind */ ··· 59 62 buf[0] = reg; 60 63 memcpy(&buf[1], v, len); 61 64 62 - /* deb("wr %02x: %02x", reg, v[0]); */ 65 + /* itd_dbg("wr %02x: %02x\n", reg, v[0]); */ 63 66 64 67 if (i2c_transfer(state->i2c, &msg, 1) != 1) { 65 68 printk(KERN_WARNING "itd1000 I2C write failed\n"); ··· 80 83 itd1000_write_regs(state, (reg - 1) & 0xff, &state->shadow[(reg - 1) & 0xff], 1); 81 84 82 85 if (i2c_transfer(state->i2c, msg, 2) != 2) { 83 - warn("itd1000 I2C read failed"); 86 + itd_warn("itd1000 I2C read failed\n"); 84 87 return -EREMOTEIO; 85 88 } 86 89 return val; ··· 124 127 u8 bbgvmin = itd1000_read_reg(state, BBGVMIN) & 0xf0; 125 128 u8 bw = itd1000_read_reg(state, BW) & 0xf0; 126 129 127 - deb("symbol_rate = %d", symbol_rate); 130 + itd_dbg("symbol_rate = %d\n", symbol_rate); 128 131 129 132 /* not sure what is that ? - starting to download the table */ 130 133 itd1000_write_reg(state, CON1, con1 | (1 << 1)); 131 134 132 135 for (i = 0; i < ARRAY_SIZE(itd1000_lpf_pga); i++) 133 136 if (symbol_rate < itd1000_lpf_pga[i].symbol_rate) { 134 - deb("symrate: index: %d pgaext: %x, bbgvmin: %x", i, itd1000_lpf_pga[i].pgaext, itd1000_lpf_pga[i].bbgvmin); 137 + itd_dbg("symrate: index: %d pgaext: %x, bbgvmin: %x\n", i, itd1000_lpf_pga[i].pgaext, itd1000_lpf_pga[i].bbgvmin); 135 138 itd1000_write_reg(state, PLLFH, pllfh | (itd1000_lpf_pga[i].pgaext << 4)); 136 139 itd1000_write_reg(state, BBGVMIN, bbgvmin | (itd1000_lpf_pga[i].bbgvmin)); 137 140 itd1000_write_reg(state, BW, bw | (i & 0x0f)); ··· 179 182 180 183 adcout = itd1000_read_reg(state, PLLLOCK) & 0x0f; 181 184 182 - deb("VCO: %dkHz: %d -> ADCOUT: %d %02x", freq_khz, itd1000_vcorg[i].vcorg, adcout, vco_chp1_i2c); 185 + itd_dbg("VCO: %dkHz: %d -> ADCOUT: %d %02x\n", freq_khz, itd1000_vcorg[i].vcorg, adcout, vco_chp1_i2c); 183 186 184 187 if (adcout > 13) { 185 188 if (!(itd1000_vcorg[i].vcorg == 7 || itd1000_vcorg[i].vcorg == 15)) ··· 229 232 pllf = (u32) tmp; 230 233 231 234 state->frequency = ((plln * 1000) + (pllf * 1000)/1048576) * 2*FREF; 232 - deb("frequency: %dkHz (wanted) %dkHz (set), PLLF = %d, PLLN = %d", freq_khz, state->frequency, pllf, plln); 235 + itd_dbg("frequency: %dkHz (wanted) %dkHz (set), PLLF = %d, PLLN = %d\n", freq_khz, state->frequency, pllf, plln); 233 236 234 237 itd1000_write_reg(state, PLLNH, 0x80); /* PLLNH */; 235 238 itd1000_write_reg(state, PLLNL, plln & 0xff); ··· 239 242 240 243 for (i = 0; i < ARRAY_SIZE(itd1000_fre_values); i++) { 241 244 if (freq_khz <= itd1000_fre_values[i].freq) { 242 - deb("fre_values: %d", i); 245 + itd_dbg("fre_values: %d\n", i); 243 246 itd1000_write_reg(state, RFTR, itd1000_fre_values[i].values[0]); 244 247 for (j = 0; j < 9; j++) 245 248 itd1000_write_reg(state, RFST1+j, itd1000_fre_values[i].values[j+1]); ··· 379 382 kfree(state); 380 383 return NULL; 381 384 } 382 - info("successfully identified (ID: %d)", i); 385 + itd_info("successfully identified (ID: %d)\n", i); 383 386 384 387 memset(state->shadow, 0xff, sizeof(state->shadow)); 385 388 for (i = 0x65; i < 0x9c; i++)