Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

gpio: exar: Use correct property prefix and document bindings

The device-specific property should be prefixed with the vendor name,
not "linux,", as Linus Walleij pointed out. Change this and document the
bindings of this platform device.

We didn't ship the old binding in a release yet. So we can still change
it without breaking an official API.

Fixes: 380b1e2f3a2f ("gpio-exar/8250-exar: Make set of exported GPIOs configurable")
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

authored by

Jan Kiszka and committed by
Linus Walleij
a589e211 cc9269f8

+8 -3
+5
Documentation/devicetree/bindings/gpio/gpio-exar.txt
··· 1 + Exportable MPIO interface of Exar UART chips 2 + 3 + Required properties of the device: 4 + - exar,first-pin: first exportable pins (0..15) 5 + - ngpios: number of exportable pins (1..16)
+1 -1
drivers/gpio/gpio-exar.c
··· 132 132 if (!p) 133 133 return -ENOMEM; 134 134 135 - ret = device_property_read_u32(&pdev->dev, "linux,first-pin", 135 + ret = device_property_read_u32(&pdev->dev, "exar,first-pin", 136 136 &first_pin); 137 137 if (ret) 138 138 return ret;
+2 -2
drivers/tty/serial/8250/8250_exar.c
··· 261 261 } 262 262 263 263 static const struct property_entry exar_gpio_properties[] = { 264 - PROPERTY_ENTRY_U32("linux,first-pin", 0), 264 + PROPERTY_ENTRY_U32("exar,first-pin", 0), 265 265 PROPERTY_ENTRY_U32("ngpios", 16), 266 266 { } 267 267 }; ··· 326 326 } 327 327 328 328 static const struct property_entry iot2040_gpio_properties[] = { 329 - PROPERTY_ENTRY_U32("linux,first-pin", 10), 329 + PROPERTY_ENTRY_U32("exar,first-pin", 10), 330 330 PROPERTY_ENTRY_U32("ngpios", 1), 331 331 { } 332 332 };