platform/chrome: wilco_ec: Add newlines to printks

Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

kernel os linux

printk messages all require newlines, or it looks very odd in the log
when messages are not on different lines. Add them.

Cc: Nick Crews <ncrews@chromium.org>
Cc: Daniel Campello <campello@chromium.org>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

authored by

Stephen Boyd and committed by

Enric Balletbo i Serra 6 years ago a532149c 3b0bfd33

+10 -10

4 changed files

expand all

drivers

platform

chrome

wilco_ec

core.c

keyboard_leds.c

mailbox.c

telemetry.c

+1 -1

drivers/platform/chrome/wilco_ec/core.c

··· 94 94 95 95 ret = wilco_ec_add_sysfs(ec); 96 96 if (ret < 0) { 97 - dev_err(dev, "Failed to create sysfs entries: %d", ret); 97 + dev_err(dev, "Failed to create sysfs entries: %d\n", ret); 98 98 goto unregister_rtc; 99 99 } 100 100

+4 -4

drivers/platform/chrome/wilco_ec/keyboard_leds.c

··· 69 69 ret = wilco_ec_mailbox(ec, &msg); 70 70 if (ret < 0) { 71 71 dev_err(ec->dev, 72 - "Failed sending keyboard LEDs command: %d", ret); 72 + "Failed sending keyboard LEDs command: %d\n", ret); 73 73 return ret; 74 74 } 75 75 ··· 94 94 95 95 if (response.status) { 96 96 dev_err(ec->dev, 97 - "EC reported failure sending keyboard LEDs command: %d", 97 + "EC reported failure sending keyboard LEDs command: %d\n", 98 98 response.status); 99 99 return -EIO; 100 100 } ··· 147 147 148 148 if (response.status) { 149 149 dev_err(ec->dev, 150 - "EC reported failure sending keyboard LEDs command: %d", 150 + "EC reported failure sending keyboard LEDs command: %d\n", 151 151 response.status); 152 152 return -EIO; 153 153 } ··· 179 179 ret = kbbl_exist(ec, &leds_exist); 180 180 if (ret < 0) { 181 181 dev_err(ec->dev, 182 - "Failed checking keyboard LEDs support: %d", ret); 182 + "Failed checking keyboard LEDs support: %d\n", ret); 183 183 return ret; 184 184 } 185 185 if (!leds_exist)

+2 -2

drivers/platform/chrome/wilco_ec/mailbox.c

··· 163 163 } 164 164 165 165 if (rs->data_size != EC_MAILBOX_DATA_SIZE) { 166 - dev_dbg(ec->dev, "unexpected packet size (%u != %u)", 166 + dev_dbg(ec->dev, "unexpected packet size (%u != %u)\n", 167 167 rs->data_size, EC_MAILBOX_DATA_SIZE); 168 168 return -EMSGSIZE; 169 169 } 170 170 171 171 if (rs->data_size < msg->response_size) { 172 - dev_dbg(ec->dev, "EC didn't return enough data (%u < %zu)", 172 + dev_dbg(ec->dev, "EC didn't return enough data (%u < %zu)\n", 173 173 rs->data_size, msg->response_size); 174 174 return -EMSGSIZE; 175 175 }

+3 -3

drivers/platform/chrome/wilco_ec/telemetry.c

··· 367 367 minor = ida_alloc_max(&telem_ida, TELEM_MAX_DEV-1, GFP_KERNEL); 368 368 if (minor < 0) { 369 369 error = minor; 370 - dev_err(&pdev->dev, "Failed to find minor number: %d", error); 370 + dev_err(&pdev->dev, "Failed to find minor number: %d\n", error); 371 371 return error; 372 372 } 373 373 ··· 427 427 428 428 ret = class_register(&telem_class); 429 429 if (ret) { 430 - pr_err(DRV_NAME ": Failed registering class: %d", ret); 430 + pr_err(DRV_NAME ": Failed registering class: %d\n", ret); 431 431 return ret; 432 432 } 433 433 434 434 /* Request the kernel for device numbers, starting with minor=0 */ 435 435 ret = alloc_chrdev_region(&dev_num, 0, TELEM_MAX_DEV, TELEM_DEV_NAME); 436 436 if (ret) { 437 - pr_err(DRV_NAME ": Failed allocating dev numbers: %d", ret); 437 + pr_err(DRV_NAME ": Failed allocating dev numbers: %d\n", ret); 438 438 goto destroy_class; 439 439 } 440 440 telem_major = MAJOR(dev_num);