Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

quota: Fix memory leak when handling corrupted quota file

When checking corrupted quota file we can bail out and leak allocated
info structure. Properly free info structure on error return.

Reported-by: syzbot+77779c9b52ab78154b08@syzkaller.appspotmail.com
Fixes: 11c514a99bb9 ("quota: Sanity-check quota file headers on load")
Signed-off-by: Jan Kara <jack@suse.cz>

Jan Kara a4db1072 36bbbd0e

+8 -3
+8 -3
fs/quota/quota_v2.c
··· 164 164 quota_error(sb, "Number of blocks too big for quota file size (%llu > %llu).", 165 165 (loff_t)qinfo->dqi_blocks << qinfo->dqi_blocksize_bits, 166 166 i_size_read(sb_dqopt(sb)->files[type])); 167 - goto out; 167 + goto out_free; 168 168 } 169 169 if (qinfo->dqi_free_blk >= qinfo->dqi_blocks) { 170 170 quota_error(sb, "Free block number too big (%u >= %u).", 171 171 qinfo->dqi_free_blk, qinfo->dqi_blocks); 172 - goto out; 172 + goto out_free; 173 173 } 174 174 if (qinfo->dqi_free_entry >= qinfo->dqi_blocks) { 175 175 quota_error(sb, "Block with free entry too big (%u >= %u).", 176 176 qinfo->dqi_free_entry, qinfo->dqi_blocks); 177 - goto out; 177 + goto out_free; 178 178 } 179 179 ret = 0; 180 + out_free: 181 + if (ret) { 182 + kfree(info->dqi_priv); 183 + info->dqi_priv = NULL; 184 + } 180 185 out: 181 186 up_read(&dqopt->dqio_sem); 182 187 return ret;