tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

[media] Kconfig: fix breakages when DVB_CORE is not selected

On some weird randconfigs, it is possible to select DVB
drivers, without having the DVB_CORE:

CONFIG_DVB_AU8522=m
CONFIG_DVB_AU8522_V4L=m
CONFIG_DVB_TUNER_DIB0090=m

This was never supposed to work, but changeset 22a613e89825
("[media] dvb_frontend: merge duplicate dvb_tuner_ops.release implementations")
caused it to be exposed:

drivers/built-in.o: In function `fc0011_attach':
(.text+0x1598fb): undefined reference to `dvb_tuner_simple_release'
drivers/built-in.o:(.rodata+0x55e58): undefined reference to `dvb_tuner_simple_release'
drivers/built-in.o:(.rodata+0x57398): undefined reference to `dvb_tuner_simple_release'

Fixes: 22a613e89825 ("[media] dvb_frontend: merge duplicate dvb_tuner_ops.release implementations")
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

Mauro Carvalho Chehab a4afb3ed c044170f

+6 -5
+1 -1
drivers/media/Kconfig
··· 115 115 116 116 config MEDIA_CONTROLLER_DVB 117 117 bool "Enable Media controller for DVB (EXPERIMENTAL)" 118 - depends on MEDIA_CONTROLLER 118 + depends on MEDIA_CONTROLLER && DVB_CORE 119 119 ---help--- 120 120 Enable the media controller API support for DVB. 121 121
+5 -4
drivers/media/dvb-frontends/Kconfig
··· 642 642 to support this frontend. 643 643 644 644 config DVB_AU8522 645 - depends on I2C 645 + depends on DVB_CORE && I2C 646 646 tristate 647 647 648 648 config DVB_AU8522_DTV ··· 656 656 657 657 config DVB_AU8522_V4L 658 658 tristate "Auvitek AU8522 based ATV demod" 659 - depends on VIDEO_V4L2 && I2C 659 + depends on VIDEO_V4L2 && DVB_CORE && I2C 660 660 select DVB_AU8522 661 661 default m if !MEDIA_SUBDRV_AUTOSELECT 662 662 help ··· 722 722 723 723 config DVB_TUNER_DIB0070 724 724 tristate "DiBcom DiB0070 silicon base-band tuner" 725 - depends on I2C 725 + depends on DVB_CORE && I2C 726 726 default m if !MEDIA_SUBDRV_AUTOSELECT 727 727 help 728 728 A driver for the silicon baseband tuner DiB0070 from DiBcom. ··· 731 731 732 732 config DVB_TUNER_DIB0090 733 733 tristate "DiBcom DiB0090 silicon base-band tuner" 734 - depends on I2C 734 + depends on DVB_CORE && I2C 735 735 default m if !MEDIA_SUBDRV_AUTOSELECT 736 736 help 737 737 A driver for the silicon baseband tuner DiB0090 from DiBcom. ··· 879 879 880 880 config DVB_DUMMY_FE 881 881 tristate "Dummy frontend driver" 882 + depends on DVB_CORE 882 883 default n 883 884 endmenu