Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

iio:adc:ad5504: Use BIT() and GENMASK() macros

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>

authored by

Peter Meerwald and committed by
Jonathan Cameron
a476bc02 ff96bf51

+5 -6
+5 -6
drivers/iio/dac/ad5504.c
··· 15 15 #include <linux/sysfs.h> 16 16 #include <linux/regulator/consumer.h> 17 17 #include <linux/module.h> 18 + #include <linux/bitops.h> 18 19 19 20 #include <linux/iio/iio.h> 20 21 #include <linux/iio/sysfs.h> 21 22 #include <linux/iio/events.h> 22 23 #include <linux/iio/dac/ad5504.h> 23 24 24 - #define AD5505_BITS 12 25 - #define AD5504_RES_MASK ((1 << (AD5505_BITS)) - 1) 26 - 27 - #define AD5504_CMD_READ (1 << 15) 28 - #define AD5504_CMD_WRITE (0 << 15) 25 + #define AD5504_RES_MASK GENMASK(11, 0) 26 + #define AD5504_CMD_READ BIT(15) 27 + #define AD5504_CMD_WRITE 0 29 28 #define AD5504_ADDR(addr) ((addr) << 12) 30 29 31 30 /* Registers */ ··· 41 42 42 43 /** 43 44 * struct ad5446_state - driver instance specific data 44 - * @us: spi_device 45 + * @spi: spi_device 45 46 * @reg: supply regulator 46 47 * @vref_mv: actual reference voltage used 47 48 * @pwr_down_mask power down mask