Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ncr5380: Remove DONT_USE_INTR and AUTOPROBE_IRQ macros

Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Tested-by: Michael Schmitz <schmitzmic@gmail.com>
Tested-by: Ondrej Zary <linux@rainbow-software.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Finn Thain and committed by
Martin K. Petersen
a46865dc f0ea73a4

+4 -32
+1 -11
drivers/scsi/NCR5380.c
··· 106 106 * DIFFERENTIAL - if defined, NCR53c81 chips will use external differential 107 107 * transceivers. 108 108 * 109 - * DONT_USE_INTR - if defined, never use interrupts, even if we probe or 110 - * override-configure an IRQ. 111 - * 112 109 * PSEUDO_DMA - if defined, PSEUDO DMA is used during the data transfer phases. 113 110 * 114 111 * REAL_DMA - if defined, REAL DMA is used during the data transfer phases. ··· 461 464 hostdata->flags & FLAG_DMA_FIXUP ? "DMA_FIXUP " : "", 462 465 hostdata->flags & FLAG_NO_PSEUDO_DMA ? "NO_PSEUDO_DMA " : "", 463 466 hostdata->flags & FLAG_TOSHIBA_DELAY ? "TOSHIBA_DELAY " : "", 464 - #ifdef AUTOPROBE_IRQ 465 - "AUTOPROBE_IRQ " 466 - #endif 467 467 #ifdef DIFFERENTIAL 468 468 "DIFFERENTIAL " 469 469 #endif ··· 909 915 } 910 916 } 911 917 912 - #ifndef DONT_USE_INTR 913 - 914 918 /** 915 919 * NCR5380_intr - generic NCR5380 irq handler 916 920 * @irq: interrupt number ··· 943 951 * the Busy Monitor interrupt is enabled together with DMA Mode. 944 952 */ 945 953 946 - static irqreturn_t NCR5380_intr(int irq, void *dev_id) 954 + static irqreturn_t __maybe_unused NCR5380_intr(int irq, void *dev_id) 947 955 { 948 956 struct Scsi_Host *instance = dev_id; 949 957 struct NCR5380_hostdata *hostdata = shost_priv(instance); ··· 1011 1019 1012 1020 return IRQ_RETVAL(handled); 1013 1021 } 1014 - 1015 - #endif 1016 1022 1017 1023 /* 1018 1024 * Function : int NCR5380_select(struct Scsi_Host *instance,
-4
drivers/scsi/NCR5380.h
··· 280 280 #define NCR5380_dprint_phase(flg, arg) do {} while (0) 281 281 #endif 282 282 283 - #if defined(AUTOPROBE_IRQ) 284 283 static int NCR5380_probe_irq(struct Scsi_Host *instance, int possible); 285 - #endif 286 284 static int NCR5380_init(struct Scsi_Host *instance, int flags); 287 285 static int NCR5380_maybe_reset_bus(struct Scsi_Host *); 288 286 static void NCR5380_exit(struct Scsi_Host *instance); 289 287 static void NCR5380_information_transfer(struct Scsi_Host *instance); 290 - #ifndef DONT_USE_INTR 291 288 static irqreturn_t NCR5380_intr(int irq, void *dev_id); 292 - #endif 293 289 static void NCR5380_main(struct work_struct *work); 294 290 static const char *NCR5380_info(struct Scsi_Host *instance); 295 291 static void NCR5380_reselect(struct Scsi_Host *instance);
-2
drivers/scsi/arm/oak.c
··· 14 14 15 15 #include <scsi/scsi_host.h> 16 16 17 - #define DONT_USE_INTR 18 - 19 17 #define priv(host) ((struct NCR5380_hostdata *)(host)->hostdata) 20 18 21 19 #define NCR5380_read(reg) \
-2
drivers/scsi/dmx3191d.c
··· 34 34 * Definitions for the generic 5380 driver. 35 35 */ 36 36 37 - #define DONT_USE_INTR 38 - 39 37 #define NCR5380_read(reg) inb(instance->io_port + reg) 40 38 #define NCR5380_write(reg, value) outb(value, instance->io_port + reg) 41 39
+3 -9
drivers/scsi/dtc.c
··· 1 - #define DONT_USE_INTR 2 - 3 1 /* 4 2 * DTC 3180/3280 driver, by 5 3 * Ray Van Tassle rayvt@comm.mot.com ··· 51 53 #include <scsi/scsi_host.h> 52 54 53 55 #include "dtc.h" 54 - #define AUTOPROBE_IRQ 55 56 #include "NCR5380.h" 56 57 57 58 /* ··· 240 243 if (instance->irq == 255) 241 244 instance->irq = NO_IRQ; 242 245 243 - #ifndef DONT_USE_INTR 244 246 /* With interrupts enabled, it will sometimes hang when doing heavy 245 247 * reads. So better not enable them until I finger it out. */ 248 + instance->irq = NO_IRQ; 249 + 246 250 if (instance->irq != NO_IRQ) 247 251 if (request_irq(instance->irq, dtc_intr, 0, 248 252 "dtc", instance)) { ··· 255 257 printk(KERN_WARNING "scsi%d : interrupts not enabled. for better interactive performance,\n", instance->host_no); 256 258 printk(KERN_WARNING "scsi%d : please jumper the board for a free IRQ.\n", instance->host_no); 257 259 } 258 - #else 259 - if (instance->irq != NO_IRQ) 260 - printk(KERN_WARNING "scsi%d : interrupts not used. Might as well not jumper it.\n", instance->host_no); 261 - instance->irq = NO_IRQ; 262 - #endif 260 + 263 261 dprintk(NDEBUG_INIT, "scsi%d : irq = %d\n", 264 262 instance->host_no, instance->irq); 265 263
-2
drivers/scsi/g_NCR5380.c
··· 56 56 * 57 57 */ 58 58 59 - #define AUTOPROBE_IRQ 60 - 61 59 #include <asm/io.h> 62 60 #include <linux/blkdev.h> 63 61 #include <linux/module.h>
-1
drivers/scsi/pas16.c
··· 75 75 76 76 #include <scsi/scsi_host.h> 77 77 #include "pas16.h" 78 - #define AUTOPROBE_IRQ 79 78 #include "NCR5380.h" 80 79 81 80
-1
drivers/scsi/t128.c
··· 74 74 75 75 #include <scsi/scsi_host.h> 76 76 #include "t128.h" 77 - #define AUTOPROBE_IRQ 78 77 #include "NCR5380.h" 79 78 80 79 static struct override {