Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/ssd130x: Make ssd130x_remove() return void

This function returns zero unconditionally, so there isn't any benefit
of returning a value. Make it return void to be able to see at a glance
that the return value of ssd130x_i2c_remove() is always zero.

This patch is a preparation for making i2c remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Javier Martinez Canillas <javierm@redhat.com>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220425192306.59800-1-u.kleine-koenig@pengutronix.de

authored by

Uwe Kleine-König and committed by
Javier Martinez Canillas
a4359b4e 57e6f056

+5 -5
+3 -1
drivers/gpu/drm/solomon/ssd130x-i2c.c
··· 43 43 { 44 44 struct ssd130x_device *ssd130x = i2c_get_clientdata(client); 45 45 46 - return ssd130x_remove(ssd130x); 46 + ssd130x_remove(ssd130x); 47 + 48 + return 0; 47 49 } 48 50 49 51 static void ssd130x_i2c_shutdown(struct i2c_client *client)
+1 -3
drivers/gpu/drm/solomon/ssd130x.c
··· 924 924 } 925 925 EXPORT_SYMBOL_GPL(ssd130x_probe); 926 926 927 - int ssd130x_remove(struct ssd130x_device *ssd130x) 927 + void ssd130x_remove(struct ssd130x_device *ssd130x) 928 928 { 929 929 drm_dev_unplug(&ssd130x->drm); 930 - 931 - return 0; 932 930 } 933 931 EXPORT_SYMBOL_GPL(ssd130x_remove); 934 932
+1 -1
drivers/gpu/drm/solomon/ssd130x.h
··· 86 86 extern const struct ssd130x_deviceinfo ssd130x_variants[]; 87 87 88 88 struct ssd130x_device *ssd130x_probe(struct device *dev, struct regmap *regmap); 89 - int ssd130x_remove(struct ssd130x_device *ssd130x); 89 + void ssd130x_remove(struct ssd130x_device *ssd130x); 90 90 void ssd130x_shutdown(struct ssd130x_device *ssd130x); 91 91 92 92 #endif /* __SSD1307X_H__ */