Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

dmaengine: owl: Fix warnings generated during build

Following warnings are generated when compiled with W=1,

drivers/dma/owl-dma.c:170: warning: Function parameter or member 'cyclic'
not described in 'owl_dma_txd'
drivers/dma/owl-dma.c:198: warning: Function parameter or member 'cfg' not
described in 'owl_dma_vchan'
drivers/dma/owl-dma.c:198: warning: Function parameter or member 'drq' not
described in 'owl_dma_vchan'
drivers/dma/owl-dma.c:225: warning: Function parameter or member 'irq' not
described in 'owl_dma'

Fix this by adding comments for relevant struct members to appear in
kernel-doc.

Fixes: d64e1b3f5cce ("dmaengine: owl: Add Slave and Cyclic mode support for
Actions Semi Owl S900 SoC")

Reported-by: Vinod Koul <vinod.koul@linaro.org>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Manivannan Sadhasivam and committed by
Vinod Koul
a3e40316 d64e1b3f

+4
+4
drivers/dma/owl-dma.c
··· 162 162 * struct owl_dma_txd - Wrapper for struct dma_async_tx_descriptor 163 163 * @vd: virtual DMA descriptor 164 164 * @lli_list: link list of lli nodes 165 + * @cyclic: flag to indicate cyclic transfers 165 166 */ 166 167 struct owl_dma_txd { 167 168 struct virt_dma_desc vd; ··· 189 188 * @vc: wrappped virtual channel 190 189 * @pchan: the physical channel utilized by this channel 191 190 * @txd: active transaction on this channel 191 + * @cfg: slave configuration for this channel 192 + * @drq: physical DMA request ID for this channel 192 193 */ 193 194 struct owl_dma_vchan { 194 195 struct virt_dma_chan vc; ··· 207 204 * @clk: clock for the DMA controller 208 205 * @lock: a lock to use when change DMA controller global register 209 206 * @lli_pool: a pool for the LLI descriptors 207 + * @irq: interrupt ID for the DMA controller 210 208 * @nr_pchans: the number of physical channels 211 209 * @pchans: array of data for the physical channels 212 210 * @nr_vchans: the number of physical channels