tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

Staging: line6: fix up my fixup for some sysfs attribute permissions

They should be writable by root, not readable.
Doh, stupid me with the wrong flags.

Reported-by: Jonathan Cameron <jic23@cam.ac.uk>
Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

Greg Kroah-Hartman a3a972a0 a3d13107

+130 -130
+102 -102
drivers/staging/line6/control.c
··· 266 266 VARIAX_PARAM_R(float, mix1); 267 267 VARIAX_PARAM_R(int, pickup_wiring); 268 268 269 - static DEVICE_ATTR(tweak, S_IRUSR | S_IRUGO, pod_get_tweak, pod_set_tweak); 270 - static DEVICE_ATTR(wah_position, S_IRUSR | S_IRUGO, pod_get_wah_position, 269 + static DEVICE_ATTR(tweak, S_IWUSR | S_IRUGO, pod_get_tweak, pod_set_tweak); 270 + static DEVICE_ATTR(wah_position, S_IWUSR | S_IRUGO, pod_get_wah_position, 271 271 pod_set_wah_position); 272 - static DEVICE_ATTR(compression_gain, S_IRUSR | S_IRUGO, 272 + static DEVICE_ATTR(compression_gain, S_IWUSR | S_IRUGO, 273 273 pod_get_compression_gain, pod_set_compression_gain); 274 - static DEVICE_ATTR(vol_pedal_position, S_IRUSR | S_IRUGO, 274 + static DEVICE_ATTR(vol_pedal_position, S_IWUSR | S_IRUGO, 275 275 pod_get_vol_pedal_position, pod_set_vol_pedal_position); 276 - static DEVICE_ATTR(compression_threshold, S_IRUSR | S_IRUGO, 276 + static DEVICE_ATTR(compression_threshold, S_IWUSR | S_IRUGO, 277 277 pod_get_compression_threshold, 278 278 pod_set_compression_threshold); 279 - static DEVICE_ATTR(pan, S_IRUSR | S_IRUGO, pod_get_pan, pod_set_pan); 280 - static DEVICE_ATTR(amp_model_setup, S_IRUSR | S_IRUGO, pod_get_amp_model_setup, 279 + static DEVICE_ATTR(pan, S_IWUSR | S_IRUGO, pod_get_pan, pod_set_pan); 280 + static DEVICE_ATTR(amp_model_setup, S_IWUSR | S_IRUGO, pod_get_amp_model_setup, 281 281 pod_set_amp_model_setup); 282 - static DEVICE_ATTR(amp_model, S_IRUSR | S_IRUGO, pod_get_amp_model, 282 + static DEVICE_ATTR(amp_model, S_IWUSR | S_IRUGO, pod_get_amp_model, 283 283 pod_set_amp_model); 284 - static DEVICE_ATTR(drive, S_IRUSR | S_IRUGO, pod_get_drive, pod_set_drive); 285 - static DEVICE_ATTR(bass, S_IRUSR | S_IRUGO, pod_get_bass, pod_set_bass); 286 - static DEVICE_ATTR(mid, S_IRUSR | S_IRUGO, pod_get_mid, pod_set_mid); 287 - static DEVICE_ATTR(lowmid, S_IRUSR | S_IRUGO, pod_get_lowmid, pod_set_lowmid); 288 - static DEVICE_ATTR(treble, S_IRUSR | S_IRUGO, pod_get_treble, pod_set_treble); 289 - static DEVICE_ATTR(highmid, S_IRUSR | S_IRUGO, pod_get_highmid, 284 + static DEVICE_ATTR(drive, S_IWUSR | S_IRUGO, pod_get_drive, pod_set_drive); 285 + static DEVICE_ATTR(bass, S_IWUSR | S_IRUGO, pod_get_bass, pod_set_bass); 286 + static DEVICE_ATTR(mid, S_IWUSR | S_IRUGO, pod_get_mid, pod_set_mid); 287 + static DEVICE_ATTR(lowmid, S_IWUSR | S_IRUGO, pod_get_lowmid, pod_set_lowmid); 288 + static DEVICE_ATTR(treble, S_IWUSR | S_IRUGO, pod_get_treble, pod_set_treble); 289 + static DEVICE_ATTR(highmid, S_IWUSR | S_IRUGO, pod_get_highmid, 290 290 pod_set_highmid); 291 - static DEVICE_ATTR(chan_vol, S_IRUSR | S_IRUGO, pod_get_chan_vol, 291 + static DEVICE_ATTR(chan_vol, S_IWUSR | S_IRUGO, pod_get_chan_vol, 292 292 pod_set_chan_vol); 293 - static DEVICE_ATTR(reverb_mix, S_IRUSR | S_IRUGO, pod_get_reverb_mix, 293 + static DEVICE_ATTR(reverb_mix, S_IWUSR | S_IRUGO, pod_get_reverb_mix, 294 294 pod_set_reverb_mix); 295 - static DEVICE_ATTR(effect_setup, S_IRUSR | S_IRUGO, pod_get_effect_setup, 295 + static DEVICE_ATTR(effect_setup, S_IWUSR | S_IRUGO, pod_get_effect_setup, 296 296 pod_set_effect_setup); 297 - static DEVICE_ATTR(band_1_frequency, S_IRUSR | S_IRUGO, 297 + static DEVICE_ATTR(band_1_frequency, S_IWUSR | S_IRUGO, 298 298 pod_get_band_1_frequency, pod_set_band_1_frequency); 299 - static DEVICE_ATTR(presence, S_IRUSR | S_IRUGO, pod_get_presence, 299 + static DEVICE_ATTR(presence, S_IWUSR | S_IRUGO, pod_get_presence, 300 300 pod_set_presence); 301 - static DEVICE_ATTR2(treble__bass, treble, S_IRUSR | S_IRUGO, 301 + static DEVICE_ATTR2(treble__bass, treble, S_IWUSR | S_IRUGO, 302 302 pod_get_treble__bass, pod_set_treble__bass); 303 - static DEVICE_ATTR(noise_gate_enable, S_IRUSR | S_IRUGO, 303 + static DEVICE_ATTR(noise_gate_enable, S_IWUSR | S_IRUGO, 304 304 pod_get_noise_gate_enable, pod_set_noise_gate_enable); 305 - static DEVICE_ATTR(gate_threshold, S_IRUSR | S_IRUGO, pod_get_gate_threshold, 305 + static DEVICE_ATTR(gate_threshold, S_IWUSR | S_IRUGO, pod_get_gate_threshold, 306 306 pod_set_gate_threshold); 307 - static DEVICE_ATTR(gate_decay_time, S_IRUSR | S_IRUGO, pod_get_gate_decay_time, 307 + static DEVICE_ATTR(gate_decay_time, S_IWUSR | S_IRUGO, pod_get_gate_decay_time, 308 308 pod_set_gate_decay_time); 309 - static DEVICE_ATTR(stomp_enable, S_IRUSR | S_IRUGO, pod_get_stomp_enable, 309 + static DEVICE_ATTR(stomp_enable, S_IWUSR | S_IRUGO, pod_get_stomp_enable, 310 310 pod_set_stomp_enable); 311 - static DEVICE_ATTR(comp_enable, S_IRUSR | S_IRUGO, pod_get_comp_enable, 311 + static DEVICE_ATTR(comp_enable, S_IWUSR | S_IRUGO, pod_get_comp_enable, 312 312 pod_set_comp_enable); 313 - static DEVICE_ATTR(stomp_time, S_IRUSR | S_IRUGO, pod_get_stomp_time, 313 + static DEVICE_ATTR(stomp_time, S_IWUSR | S_IRUGO, pod_get_stomp_time, 314 314 pod_set_stomp_time); 315 - static DEVICE_ATTR(delay_enable, S_IRUSR | S_IRUGO, pod_get_delay_enable, 315 + static DEVICE_ATTR(delay_enable, S_IWUSR | S_IRUGO, pod_get_delay_enable, 316 316 pod_set_delay_enable); 317 - static DEVICE_ATTR(mod_param_1, S_IRUSR | S_IRUGO, pod_get_mod_param_1, 317 + static DEVICE_ATTR(mod_param_1, S_IWUSR | S_IRUGO, pod_get_mod_param_1, 318 318 pod_set_mod_param_1); 319 - static DEVICE_ATTR(delay_param_1, S_IRUSR | S_IRUGO, pod_get_delay_param_1, 319 + static DEVICE_ATTR(delay_param_1, S_IWUSR | S_IRUGO, pod_get_delay_param_1, 320 320 pod_set_delay_param_1); 321 - static DEVICE_ATTR(delay_param_1_note_value, S_IRUSR | S_IRUGO, 321 + static DEVICE_ATTR(delay_param_1_note_value, S_IWUSR | S_IRUGO, 322 322 pod_get_delay_param_1_note_value, 323 323 pod_set_delay_param_1_note_value); 324 - static DEVICE_ATTR2(band_2_frequency__bass, band_2_frequency, S_IRUSR | S_IRUGO, 324 + static DEVICE_ATTR2(band_2_frequency__bass, band_2_frequency, S_IWUSR | S_IRUGO, 325 325 pod_get_band_2_frequency__bass, 326 326 pod_set_band_2_frequency__bass); 327 - static DEVICE_ATTR(delay_param_2, S_IRUSR | S_IRUGO, pod_get_delay_param_2, 327 + static DEVICE_ATTR(delay_param_2, S_IWUSR | S_IRUGO, pod_get_delay_param_2, 328 328 pod_set_delay_param_2); 329 - static DEVICE_ATTR(delay_volume_mix, S_IRUSR | S_IRUGO, 329 + static DEVICE_ATTR(delay_volume_mix, S_IWUSR | S_IRUGO, 330 330 pod_get_delay_volume_mix, pod_set_delay_volume_mix); 331 - static DEVICE_ATTR(delay_param_3, S_IRUSR | S_IRUGO, pod_get_delay_param_3, 331 + static DEVICE_ATTR(delay_param_3, S_IWUSR | S_IRUGO, pod_get_delay_param_3, 332 332 pod_set_delay_param_3); 333 - static DEVICE_ATTR(reverb_enable, S_IRUSR | S_IRUGO, pod_get_reverb_enable, 333 + static DEVICE_ATTR(reverb_enable, S_IWUSR | S_IRUGO, pod_get_reverb_enable, 334 334 pod_set_reverb_enable); 335 - static DEVICE_ATTR(reverb_type, S_IRUSR | S_IRUGO, pod_get_reverb_type, 335 + static DEVICE_ATTR(reverb_type, S_IWUSR | S_IRUGO, pod_get_reverb_type, 336 336 pod_set_reverb_type); 337 - static DEVICE_ATTR(reverb_decay, S_IRUSR | S_IRUGO, pod_get_reverb_decay, 337 + static DEVICE_ATTR(reverb_decay, S_IWUSR | S_IRUGO, pod_get_reverb_decay, 338 338 pod_set_reverb_decay); 339 - static DEVICE_ATTR(reverb_tone, S_IRUSR | S_IRUGO, pod_get_reverb_tone, 339 + static DEVICE_ATTR(reverb_tone, S_IWUSR | S_IRUGO, pod_get_reverb_tone, 340 340 pod_set_reverb_tone); 341 - static DEVICE_ATTR(reverb_pre_delay, S_IRUSR | S_IRUGO, 341 + static DEVICE_ATTR(reverb_pre_delay, S_IWUSR | S_IRUGO, 342 342 pod_get_reverb_pre_delay, pod_set_reverb_pre_delay); 343 - static DEVICE_ATTR(reverb_pre_post, S_IRUSR | S_IRUGO, pod_get_reverb_pre_post, 343 + static DEVICE_ATTR(reverb_pre_post, S_IWUSR | S_IRUGO, pod_get_reverb_pre_post, 344 344 pod_set_reverb_pre_post); 345 - static DEVICE_ATTR(band_2_frequency, S_IRUSR | S_IRUGO, 345 + static DEVICE_ATTR(band_2_frequency, S_IWUSR | S_IRUGO, 346 346 pod_get_band_2_frequency, pod_set_band_2_frequency); 347 - static DEVICE_ATTR2(band_3_frequency__bass, band_3_frequency, S_IRUSR | S_IRUGO, 347 + static DEVICE_ATTR2(band_3_frequency__bass, band_3_frequency, S_IWUSR | S_IRUGO, 348 348 pod_get_band_3_frequency__bass, 349 349 pod_set_band_3_frequency__bass); 350 - static DEVICE_ATTR(wah_enable, S_IRUSR | S_IRUGO, pod_get_wah_enable, 350 + static DEVICE_ATTR(wah_enable, S_IWUSR | S_IRUGO, pod_get_wah_enable, 351 351 pod_set_wah_enable); 352 - static DEVICE_ATTR(modulation_lo_cut, S_IRUSR | S_IRUGO, 352 + static DEVICE_ATTR(modulation_lo_cut, S_IWUSR | S_IRUGO, 353 353 pod_get_modulation_lo_cut, pod_set_modulation_lo_cut); 354 - static DEVICE_ATTR(delay_reverb_lo_cut, S_IRUSR | S_IRUGO, 354 + static DEVICE_ATTR(delay_reverb_lo_cut, S_IWUSR | S_IRUGO, 355 355 pod_get_delay_reverb_lo_cut, pod_set_delay_reverb_lo_cut); 356 - static DEVICE_ATTR(volume_pedal_minimum, S_IRUSR | S_IRUGO, 356 + static DEVICE_ATTR(volume_pedal_minimum, S_IWUSR | S_IRUGO, 357 357 pod_get_volume_pedal_minimum, pod_set_volume_pedal_minimum); 358 - static DEVICE_ATTR(eq_pre_post, S_IRUSR | S_IRUGO, pod_get_eq_pre_post, 358 + static DEVICE_ATTR(eq_pre_post, S_IWUSR | S_IRUGO, pod_get_eq_pre_post, 359 359 pod_set_eq_pre_post); 360 - static DEVICE_ATTR(volume_pre_post, S_IRUSR | S_IRUGO, pod_get_volume_pre_post, 360 + static DEVICE_ATTR(volume_pre_post, S_IWUSR | S_IRUGO, pod_get_volume_pre_post, 361 361 pod_set_volume_pre_post); 362 - static DEVICE_ATTR(di_model, S_IRUSR | S_IRUGO, pod_get_di_model, 362 + static DEVICE_ATTR(di_model, S_IWUSR | S_IRUGO, pod_get_di_model, 363 363 pod_set_di_model); 364 - static DEVICE_ATTR(di_delay, S_IRUSR | S_IRUGO, pod_get_di_delay, 364 + static DEVICE_ATTR(di_delay, S_IWUSR | S_IRUGO, pod_get_di_delay, 365 365 pod_set_di_delay); 366 - static DEVICE_ATTR(mod_enable, S_IRUSR | S_IRUGO, pod_get_mod_enable, 366 + static DEVICE_ATTR(mod_enable, S_IWUSR | S_IRUGO, pod_get_mod_enable, 367 367 pod_set_mod_enable); 368 - static DEVICE_ATTR(mod_param_1_note_value, S_IRUSR | S_IRUGO, 368 + static DEVICE_ATTR(mod_param_1_note_value, S_IWUSR | S_IRUGO, 369 369 pod_get_mod_param_1_note_value, 370 370 pod_set_mod_param_1_note_value); 371 - static DEVICE_ATTR(mod_param_2, S_IRUSR | S_IRUGO, pod_get_mod_param_2, 371 + static DEVICE_ATTR(mod_param_2, S_IWUSR | S_IRUGO, pod_get_mod_param_2, 372 372 pod_set_mod_param_2); 373 - static DEVICE_ATTR(mod_param_3, S_IRUSR | S_IRUGO, pod_get_mod_param_3, 373 + static DEVICE_ATTR(mod_param_3, S_IWUSR | S_IRUGO, pod_get_mod_param_3, 374 374 pod_set_mod_param_3); 375 - static DEVICE_ATTR(mod_param_4, S_IRUSR | S_IRUGO, pod_get_mod_param_4, 375 + static DEVICE_ATTR(mod_param_4, S_IWUSR | S_IRUGO, pod_get_mod_param_4, 376 376 pod_set_mod_param_4); 377 - static DEVICE_ATTR(mod_param_5, S_IRUSR | S_IRUGO, pod_get_mod_param_5, 377 + static DEVICE_ATTR(mod_param_5, S_IWUSR | S_IRUGO, pod_get_mod_param_5, 378 378 pod_set_mod_param_5); 379 - static DEVICE_ATTR(mod_volume_mix, S_IRUSR | S_IRUGO, pod_get_mod_volume_mix, 379 + static DEVICE_ATTR(mod_volume_mix, S_IWUSR | S_IRUGO, pod_get_mod_volume_mix, 380 380 pod_set_mod_volume_mix); 381 - static DEVICE_ATTR(mod_pre_post, S_IRUSR | S_IRUGO, pod_get_mod_pre_post, 381 + static DEVICE_ATTR(mod_pre_post, S_IWUSR | S_IRUGO, pod_get_mod_pre_post, 382 382 pod_set_mod_pre_post); 383 - static DEVICE_ATTR(modulation_model, S_IRUSR | S_IRUGO, 383 + static DEVICE_ATTR(modulation_model, S_IWUSR | S_IRUGO, 384 384 pod_get_modulation_model, pod_set_modulation_model); 385 - static DEVICE_ATTR(band_3_frequency, S_IRUSR | S_IRUGO, 385 + static DEVICE_ATTR(band_3_frequency, S_IWUSR | S_IRUGO, 386 386 pod_get_band_3_frequency, pod_set_band_3_frequency); 387 - static DEVICE_ATTR2(band_4_frequency__bass, band_4_frequency, S_IRUSR | S_IRUGO, 387 + static DEVICE_ATTR2(band_4_frequency__bass, band_4_frequency, S_IWUSR | S_IRUGO, 388 388 pod_get_band_4_frequency__bass, 389 389 pod_set_band_4_frequency__bass); 390 - static DEVICE_ATTR(mod_param_1_double_precision, S_IRUSR | S_IRUGO, 390 + static DEVICE_ATTR(mod_param_1_double_precision, S_IWUSR | S_IRUGO, 391 391 pod_get_mod_param_1_double_precision, 392 392 pod_set_mod_param_1_double_precision); 393 - static DEVICE_ATTR(delay_param_1_double_precision, S_IRUSR | S_IRUGO, 393 + static DEVICE_ATTR(delay_param_1_double_precision, S_IWUSR | S_IRUGO, 394 394 pod_get_delay_param_1_double_precision, 395 395 pod_set_delay_param_1_double_precision); 396 - static DEVICE_ATTR(eq_enable, S_IRUSR | S_IRUGO, pod_get_eq_enable, 396 + static DEVICE_ATTR(eq_enable, S_IWUSR | S_IRUGO, pod_get_eq_enable, 397 397 pod_set_eq_enable); 398 - static DEVICE_ATTR(tap, S_IRUSR | S_IRUGO, pod_get_tap, pod_set_tap); 399 - static DEVICE_ATTR(volume_tweak_pedal_assign, S_IRUSR | S_IRUGO, 398 + static DEVICE_ATTR(tap, S_IWUSR | S_IRUGO, pod_get_tap, pod_set_tap); 399 + static DEVICE_ATTR(volume_tweak_pedal_assign, S_IWUSR | S_IRUGO, 400 400 pod_get_volume_tweak_pedal_assign, 401 401 pod_set_volume_tweak_pedal_assign); 402 - static DEVICE_ATTR(band_5_frequency, S_IRUSR | S_IRUGO, 402 + static DEVICE_ATTR(band_5_frequency, S_IWUSR | S_IRUGO, 403 403 pod_get_band_5_frequency, pod_set_band_5_frequency); 404 - static DEVICE_ATTR(tuner, S_IRUSR | S_IRUGO, pod_get_tuner, pod_set_tuner); 405 - static DEVICE_ATTR(mic_selection, S_IRUSR | S_IRUGO, pod_get_mic_selection, 404 + static DEVICE_ATTR(tuner, S_IWUSR | S_IRUGO, pod_get_tuner, pod_set_tuner); 405 + static DEVICE_ATTR(mic_selection, S_IWUSR | S_IRUGO, pod_get_mic_selection, 406 406 pod_set_mic_selection); 407 - static DEVICE_ATTR(cabinet_model, S_IRUSR | S_IRUGO, pod_get_cabinet_model, 407 + static DEVICE_ATTR(cabinet_model, S_IWUSR | S_IRUGO, pod_get_cabinet_model, 408 408 pod_set_cabinet_model); 409 - static DEVICE_ATTR(stomp_model, S_IRUSR | S_IRUGO, pod_get_stomp_model, 409 + static DEVICE_ATTR(stomp_model, S_IWUSR | S_IRUGO, pod_get_stomp_model, 410 410 pod_set_stomp_model); 411 - static DEVICE_ATTR(roomlevel, S_IRUSR | S_IRUGO, pod_get_roomlevel, 411 + static DEVICE_ATTR(roomlevel, S_IWUSR | S_IRUGO, pod_get_roomlevel, 412 412 pod_set_roomlevel); 413 - static DEVICE_ATTR(band_4_frequency, S_IRUSR | S_IRUGO, 413 + static DEVICE_ATTR(band_4_frequency, S_IWUSR | S_IRUGO, 414 414 pod_get_band_4_frequency, pod_set_band_4_frequency); 415 - static DEVICE_ATTR(band_6_frequency, S_IRUSR | S_IRUGO, 415 + static DEVICE_ATTR(band_6_frequency, S_IWUSR | S_IRUGO, 416 416 pod_get_band_6_frequency, pod_set_band_6_frequency); 417 - static DEVICE_ATTR(stomp_param_1_note_value, S_IRUSR | S_IRUGO, 417 + static DEVICE_ATTR(stomp_param_1_note_value, S_IWUSR | S_IRUGO, 418 418 pod_get_stomp_param_1_note_value, 419 419 pod_set_stomp_param_1_note_value); 420 - static DEVICE_ATTR(stomp_param_2, S_IRUSR | S_IRUGO, pod_get_stomp_param_2, 420 + static DEVICE_ATTR(stomp_param_2, S_IWUSR | S_IRUGO, pod_get_stomp_param_2, 421 421 pod_set_stomp_param_2); 422 - static DEVICE_ATTR(stomp_param_3, S_IRUSR | S_IRUGO, pod_get_stomp_param_3, 422 + static DEVICE_ATTR(stomp_param_3, S_IWUSR | S_IRUGO, pod_get_stomp_param_3, 423 423 pod_set_stomp_param_3); 424 - static DEVICE_ATTR(stomp_param_4, S_IRUSR | S_IRUGO, pod_get_stomp_param_4, 424 + static DEVICE_ATTR(stomp_param_4, S_IWUSR | S_IRUGO, pod_get_stomp_param_4, 425 425 pod_set_stomp_param_4); 426 - static DEVICE_ATTR(stomp_param_5, S_IRUSR | S_IRUGO, pod_get_stomp_param_5, 426 + static DEVICE_ATTR(stomp_param_5, S_IWUSR | S_IRUGO, pod_get_stomp_param_5, 427 427 pod_set_stomp_param_5); 428 - static DEVICE_ATTR(stomp_param_6, S_IRUSR | S_IRUGO, pod_get_stomp_param_6, 428 + static DEVICE_ATTR(stomp_param_6, S_IWUSR | S_IRUGO, pod_get_stomp_param_6, 429 429 pod_set_stomp_param_6); 430 - static DEVICE_ATTR(amp_switch_select, S_IRUSR | S_IRUGO, 430 + static DEVICE_ATTR(amp_switch_select, S_IWUSR | S_IRUGO, 431 431 pod_get_amp_switch_select, pod_set_amp_switch_select); 432 - static DEVICE_ATTR(delay_param_4, S_IRUSR | S_IRUGO, pod_get_delay_param_4, 432 + static DEVICE_ATTR(delay_param_4, S_IWUSR | S_IRUGO, pod_get_delay_param_4, 433 433 pod_set_delay_param_4); 434 - static DEVICE_ATTR(delay_param_5, S_IRUSR | S_IRUGO, pod_get_delay_param_5, 434 + static DEVICE_ATTR(delay_param_5, S_IWUSR | S_IRUGO, pod_get_delay_param_5, 435 435 pod_set_delay_param_5); 436 - static DEVICE_ATTR(delay_pre_post, S_IRUSR | S_IRUGO, pod_get_delay_pre_post, 436 + static DEVICE_ATTR(delay_pre_post, S_IWUSR | S_IRUGO, pod_get_delay_pre_post, 437 437 pod_set_delay_pre_post); 438 - static DEVICE_ATTR(delay_model, S_IRUSR | S_IRUGO, pod_get_delay_model, 438 + static DEVICE_ATTR(delay_model, S_IWUSR | S_IRUGO, pod_get_delay_model, 439 439 pod_set_delay_model); 440 - static DEVICE_ATTR(delay_verb_model, S_IRUSR | S_IRUGO, 440 + static DEVICE_ATTR(delay_verb_model, S_IWUSR | S_IRUGO, 441 441 pod_get_delay_verb_model, pod_set_delay_verb_model); 442 - static DEVICE_ATTR(tempo_msb, S_IRUSR | S_IRUGO, pod_get_tempo_msb, 442 + static DEVICE_ATTR(tempo_msb, S_IWUSR | S_IRUGO, pod_get_tempo_msb, 443 443 pod_set_tempo_msb); 444 - static DEVICE_ATTR(tempo_lsb, S_IRUSR | S_IRUGO, pod_get_tempo_lsb, 444 + static DEVICE_ATTR(tempo_lsb, S_IWUSR | S_IRUGO, pod_get_tempo_lsb, 445 445 pod_set_tempo_lsb); 446 - static DEVICE_ATTR(wah_model, S_IRUSR | S_IRUGO, pod_get_wah_model, 446 + static DEVICE_ATTR(wah_model, S_IWUSR | S_IRUGO, pod_get_wah_model, 447 447 pod_set_wah_model); 448 - static DEVICE_ATTR(bypass_volume, S_IRUSR | S_IRUGO, pod_get_bypass_volume, 448 + static DEVICE_ATTR(bypass_volume, S_IWUSR | S_IRUGO, pod_get_bypass_volume, 449 449 pod_set_bypass_volume); 450 - static DEVICE_ATTR(fx_loop_on_off, S_IRUSR | S_IRUGO, pod_get_fx_loop_on_off, 450 + static DEVICE_ATTR(fx_loop_on_off, S_IWUSR | S_IRUGO, pod_get_fx_loop_on_off, 451 451 pod_set_fx_loop_on_off); 452 - static DEVICE_ATTR(tweak_param_select, S_IRUSR | S_IRUGO, 452 + static DEVICE_ATTR(tweak_param_select, S_IWUSR | S_IRUGO, 453 453 pod_get_tweak_param_select, pod_set_tweak_param_select); 454 - static DEVICE_ATTR(amp1_engage, S_IRUSR | S_IRUGO, pod_get_amp1_engage, 454 + static DEVICE_ATTR(amp1_engage, S_IWUSR | S_IRUGO, pod_get_amp1_engage, 455 455 pod_set_amp1_engage); 456 - static DEVICE_ATTR(band_1_gain, S_IRUSR | S_IRUGO, pod_get_band_1_gain, 456 + static DEVICE_ATTR(band_1_gain, S_IWUSR | S_IRUGO, pod_get_band_1_gain, 457 457 pod_set_band_1_gain); 458 - static DEVICE_ATTR2(band_2_gain__bass, band_2_gain, S_IRUSR | S_IRUGO, 458 + static DEVICE_ATTR2(band_2_gain__bass, band_2_gain, S_IWUSR | S_IRUGO, 459 459 pod_get_band_2_gain__bass, pod_set_band_2_gain__bass); 460 - static DEVICE_ATTR(band_2_gain, S_IRUSR | S_IRUGO, pod_get_band_2_gain, 460 + static DEVICE_ATTR(band_2_gain, S_IWUSR | S_IRUGO, pod_get_band_2_gain, 461 461 pod_set_band_2_gain); 462 - static DEVICE_ATTR2(band_3_gain__bass, band_3_gain, S_IRUSR | S_IRUGO, 462 + static DEVICE_ATTR2(band_3_gain__bass, band_3_gain, S_IWUSR | S_IRUGO, 463 463 pod_get_band_3_gain__bass, pod_set_band_3_gain__bass); 464 - static DEVICE_ATTR(band_3_gain, S_IRUSR | S_IRUGO, pod_get_band_3_gain, 464 + static DEVICE_ATTR(band_3_gain, S_IWUSR | S_IRUGO, pod_get_band_3_gain, 465 465 pod_set_band_3_gain); 466 - static DEVICE_ATTR2(band_4_gain__bass, band_4_gain, S_IRUSR | S_IRUGO, 466 + static DEVICE_ATTR2(band_4_gain__bass, band_4_gain, S_IWUSR | S_IRUGO, 467 467 pod_get_band_4_gain__bass, pod_set_band_4_gain__bass); 468 - static DEVICE_ATTR2(band_5_gain__bass, band_5_gain, S_IRUSR | S_IRUGO, 468 + static DEVICE_ATTR2(band_5_gain__bass, band_5_gain, S_IWUSR | S_IRUGO, 469 469 pod_get_band_5_gain__bass, pod_set_band_5_gain__bass); 470 - static DEVICE_ATTR(band_4_gain, S_IRUSR | S_IRUGO, pod_get_band_4_gain, 470 + static DEVICE_ATTR(band_4_gain, S_IWUSR | S_IRUGO, pod_get_band_4_gain, 471 471 pod_set_band_4_gain); 472 - static DEVICE_ATTR2(band_6_gain__bass, band_6_gain, S_IRUSR | S_IRUGO, 472 + static DEVICE_ATTR2(band_6_gain__bass, band_6_gain, S_IWUSR | S_IRUGO, 473 473 pod_get_band_6_gain__bass, pod_set_band_6_gain__bass); 474 474 static DEVICE_ATTR(body, S_IRUGO, variax_get_body, line6_nop_write); 475 475 static DEVICE_ATTR(pickup1_enable, S_IRUGO, variax_get_pickup1_enable,
+2 -2
drivers/staging/line6/midi.c
··· 350 350 return count; 351 351 } 352 352 353 - static DEVICE_ATTR(midi_mask_transmit, S_IRUSR | S_IRUGO, 353 + static DEVICE_ATTR(midi_mask_transmit, S_IWUSR | S_IRUGO, 354 354 midi_get_midi_mask_transmit, midi_set_midi_mask_transmit); 355 - static DEVICE_ATTR(midi_mask_receive, S_IRUSR | S_IRUGO, 355 + static DEVICE_ATTR(midi_mask_receive, S_IWUSR | S_IRUGO, 356 356 midi_get_midi_mask_receive, midi_set_midi_mask_receive); 357 357 358 358 /* MIDI device destructor */
+2 -2
drivers/staging/line6/pcm.c
··· 79 79 return count; 80 80 } 81 81 82 - static DEVICE_ATTR(impulse_volume, S_IRUSR | S_IRUGO, pcm_get_impulse_volume, 82 + static DEVICE_ATTR(impulse_volume, S_IWUSR | S_IRUGO, pcm_get_impulse_volume, 83 83 pcm_set_impulse_volume); 84 - static DEVICE_ATTR(impulse_period, S_IRUSR | S_IRUGO, pcm_get_impulse_period, 84 + static DEVICE_ATTR(impulse_period, S_IWUSR | S_IRUGO, pcm_get_impulse_period, 85 85 pcm_set_impulse_period); 86 86 87 87 #endif
+16 -16
drivers/staging/line6/pod.c
··· 1051 1051 #undef GET_SYSTEM_PARAM 1052 1052 1053 1053 /* POD special files: */ 1054 - static DEVICE_ATTR(channel, S_IRUSR | S_IRUGO, pod_get_channel, 1054 + static DEVICE_ATTR(channel, S_IWUSR | S_IRUGO, pod_get_channel, 1055 1055 pod_set_channel); 1056 1056 static DEVICE_ATTR(clip, S_IRUGO, pod_wait_for_clip, line6_nop_write); 1057 1057 static DEVICE_ATTR(device_id, S_IRUGO, pod_get_device_id, line6_nop_write); 1058 1058 static DEVICE_ATTR(dirty, S_IRUGO, pod_get_dirty, line6_nop_write); 1059 - static DEVICE_ATTR(dump, S_IRUSR | S_IRUGO, pod_get_dump, pod_set_dump); 1060 - static DEVICE_ATTR(dump_buf, S_IRUSR | S_IRUGO, pod_get_dump_buf, 1059 + static DEVICE_ATTR(dump, S_IWUSR | S_IRUGO, pod_get_dump, pod_set_dump); 1060 + static DEVICE_ATTR(dump_buf, S_IWUSR | S_IRUGO, pod_get_dump_buf, 1061 1061 pod_set_dump_buf); 1062 - static DEVICE_ATTR(finish, S_IRUSR, line6_nop_read, pod_set_finish); 1062 + static DEVICE_ATTR(finish, S_IWUSR, line6_nop_read, pod_set_finish); 1063 1063 static DEVICE_ATTR(firmware_version, S_IRUGO, pod_get_firmware_version, 1064 1064 line6_nop_write); 1065 - static DEVICE_ATTR(midi_postprocess, S_IRUSR | S_IRUGO, 1065 + static DEVICE_ATTR(midi_postprocess, S_IWUSR | S_IRUGO, 1066 1066 pod_get_midi_postprocess, pod_set_midi_postprocess); 1067 - static DEVICE_ATTR(monitor_level, S_IRUSR | S_IRUGO, pod_get_monitor_level, 1067 + static DEVICE_ATTR(monitor_level, S_IWUSR | S_IRUGO, pod_get_monitor_level, 1068 1068 pod_set_monitor_level); 1069 1069 static DEVICE_ATTR(name, S_IRUGO, pod_get_name, line6_nop_write); 1070 1070 static DEVICE_ATTR(name_buf, S_IRUGO, pod_get_name_buf, line6_nop_write); 1071 - static DEVICE_ATTR(retrieve_amp_setup, S_IRUSR, line6_nop_read, 1071 + static DEVICE_ATTR(retrieve_amp_setup, S_IWUSR, line6_nop_read, 1072 1072 pod_set_retrieve_amp_setup); 1073 - static DEVICE_ATTR(retrieve_channel, S_IRUSR, line6_nop_read, 1073 + static DEVICE_ATTR(retrieve_channel, S_IWUSR, line6_nop_read, 1074 1074 pod_set_retrieve_channel); 1075 - static DEVICE_ATTR(retrieve_effects_setup, S_IRUSR, line6_nop_read, 1075 + static DEVICE_ATTR(retrieve_effects_setup, S_IWUSR, line6_nop_read, 1076 1076 pod_set_retrieve_effects_setup); 1077 - static DEVICE_ATTR(routing, S_IRUSR | S_IRUGO, pod_get_routing, 1077 + static DEVICE_ATTR(routing, S_IWUSR | S_IRUGO, pod_get_routing, 1078 1078 pod_set_routing); 1079 1079 static DEVICE_ATTR(serial_number, S_IRUGO, pod_get_serial_number, 1080 1080 line6_nop_write); 1081 - static DEVICE_ATTR(store_amp_setup, S_IRUSR, line6_nop_read, 1081 + static DEVICE_ATTR(store_amp_setup, S_IWUSR, line6_nop_read, 1082 1082 pod_set_store_amp_setup); 1083 - static DEVICE_ATTR(store_channel, S_IRUSR, line6_nop_read, 1083 + static DEVICE_ATTR(store_channel, S_IWUSR, line6_nop_read, 1084 1084 pod_set_store_channel); 1085 - static DEVICE_ATTR(store_effects_setup, S_IRUSR, line6_nop_read, 1085 + static DEVICE_ATTR(store_effects_setup, S_IWUSR, line6_nop_read, 1086 1086 pod_set_store_effects_setup); 1087 - static DEVICE_ATTR(tuner_freq, S_IRUSR | S_IRUGO, pod_get_tuner_freq, 1087 + static DEVICE_ATTR(tuner_freq, S_IWUSR | S_IRUGO, pod_get_tuner_freq, 1088 1088 pod_set_tuner_freq); 1089 - static DEVICE_ATTR(tuner_mute, S_IRUSR | S_IRUGO, pod_get_tuner_mute, 1089 + static DEVICE_ATTR(tuner_mute, S_IWUSR | S_IRUGO, pod_get_tuner_mute, 1090 1090 pod_set_tuner_mute); 1091 1091 static DEVICE_ATTR(tuner_note, S_IRUGO, pod_get_tuner_note, line6_nop_write); 1092 1092 static DEVICE_ATTR(tuner_pitch, S_IRUGO, pod_get_tuner_pitch, line6_nop_write); 1093 1093 1094 1094 #ifdef CONFIG_LINE6_USB_RAW 1095 - static DEVICE_ATTR(raw, S_IRUSR, line6_nop_read, line6_set_raw); 1095 + static DEVICE_ATTR(raw, S_IWUSR, line6_nop_read, line6_set_raw); 1096 1096 #endif 1097 1097 1098 1098 /* control info callback */
+2 -2
drivers/staging/line6/toneport.c
··· 154 154 return count; 155 155 } 156 156 157 - static DEVICE_ATTR(led_red, S_IRUSR | S_IRUGO, line6_nop_read, 157 + static DEVICE_ATTR(led_red, S_IWUSR | S_IRUGO, line6_nop_read, 158 158 toneport_set_led_red); 159 - static DEVICE_ATTR(led_green, S_IRUSR | S_IRUGO, line6_nop_read, 159 + static DEVICE_ATTR(led_green, S_IWUSR | S_IRUGO, line6_nop_read, 160 160 toneport_set_led_green); 161 161 162 162 static int toneport_send_cmd(struct usb_device *usbdev, int cmd1, int cmd2)
+6 -6
drivers/staging/line6/variax.c
··· 549 549 #endif 550 550 551 551 /* Variax workbench special files: */ 552 - static DEVICE_ATTR(model, S_IRUSR | S_IRUGO, variax_get_model, 552 + static DEVICE_ATTR(model, S_IWUSR | S_IRUGO, variax_get_model, 553 553 variax_set_model); 554 - static DEVICE_ATTR(volume, S_IRUSR | S_IRUGO, variax_get_volume, 554 + static DEVICE_ATTR(volume, S_IWUSR | S_IRUGO, variax_get_volume, 555 555 variax_set_volume); 556 - static DEVICE_ATTR(tone, S_IRUSR | S_IRUGO, variax_get_tone, variax_set_tone); 556 + static DEVICE_ATTR(tone, S_IWUSR | S_IRUGO, variax_get_tone, variax_set_tone); 557 557 static DEVICE_ATTR(name, S_IRUGO, variax_get_name, line6_nop_write); 558 558 static DEVICE_ATTR(bank, S_IRUGO, variax_get_bank, line6_nop_write); 559 559 static DEVICE_ATTR(dump, S_IRUGO, variax_get_dump, line6_nop_write); 560 - static DEVICE_ATTR(active, S_IRUSR | S_IRUGO, variax_get_active, 560 + static DEVICE_ATTR(active, S_IWUSR | S_IRUGO, variax_get_active, 561 561 variax_set_active); 562 562 static DEVICE_ATTR(guitar, S_IRUGO, variax_get_guitar, line6_nop_write); 563 563 564 564 #ifdef CONFIG_LINE6_USB_RAW 565 - static DEVICE_ATTR(raw, S_IRUSR, line6_nop_read, line6_set_raw); 566 - static DEVICE_ATTR(raw2, S_IRUSR, line6_nop_read, variax_set_raw2); 565 + static DEVICE_ATTR(raw, S_IWUSR, line6_nop_read, line6_set_raw); 566 + static DEVICE_ATTR(raw2, S_IWUSR, line6_nop_read, variax_set_raw2); 567 567 #endif 568 568 569 569 /*