Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net/smc: Introduce tracepoint for smcr link down

SMC-R link down event is important to help us find links' issues, we
should track this event, especially in the single nic mode, which means
upper layer connection would be shut down. Then find out the direct
link-down reason in time, not only increased the counter, also the
location of the code who triggered this event.

Signed-off-by: Tony Lu <tonylu@linux.alibaba.com>
Reviewed-by: Wen Gu <guwen@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Tony Lu and committed by
David S. Miller
a3a0e81b aff3083f

+38 -2
+7 -2
net/smc/smc_core.c
··· 34 34 #include "smc_ism.h" 35 35 #include "smc_netlink.h" 36 36 #include "smc_stats.h" 37 + #include "smc_tracepoint.h" 37 38 38 39 #define SMC_LGR_NUM_INCR 256 39 40 #define SMC_LGR_FREE_DELAY_SERV (600 * HZ) ··· 1621 1620 /* must be called under lgr->llc_conf_mutex lock */ 1622 1621 void smcr_link_down_cond(struct smc_link *lnk) 1623 1622 { 1624 - if (smc_link_downing(&lnk->state)) 1623 + if (smc_link_downing(&lnk->state)) { 1624 + trace_smcr_link_down(lnk, __builtin_return_address(0)); 1625 1625 smcr_link_down(lnk); 1626 + } 1626 1627 } 1627 1628 1628 1629 /* will get the lgr->llc_conf_mutex lock */ 1629 1630 void smcr_link_down_cond_sched(struct smc_link *lnk) 1630 1631 { 1631 - if (smc_link_downing(&lnk->state)) 1632 + if (smc_link_downing(&lnk->state)) { 1633 + trace_smcr_link_down(lnk, __builtin_return_address(0)); 1632 1634 schedule_work(&lnk->link_down_wrk); 1635 + } 1633 1636 } 1634 1637 1635 1638 void smcr_port_err(struct smc_ib_device *smcibdev, u8 ibport)
+1
net/smc/smc_tracepoint.c
··· 6 6 EXPORT_TRACEPOINT_SYMBOL(smc_switch_to_fallback); 7 7 EXPORT_TRACEPOINT_SYMBOL(smc_tx_sendmsg); 8 8 EXPORT_TRACEPOINT_SYMBOL(smc_rx_recvmsg); 9 + EXPORT_TRACEPOINT_SYMBOL(smcr_link_down);
+30
net/smc/smc_tracepoint.h
··· 75 75 TP_ARGS(smc, len) 76 76 ); 77 77 78 + TRACE_EVENT(smcr_link_down, 79 + 80 + TP_PROTO(const struct smc_link *lnk, void *location), 81 + 82 + TP_ARGS(lnk, location), 83 + 84 + TP_STRUCT__entry( 85 + __field(const void *, lnk) 86 + __field(const void *, lgr) 87 + __field(int, state) 88 + __string(name, lnk->ibname) 89 + __field(void *, location) 90 + ), 91 + 92 + TP_fast_assign( 93 + const struct smc_link_group *lgr = lnk->lgr; 94 + 95 + __entry->lnk = lnk; 96 + __entry->lgr = lgr; 97 + __entry->state = lnk->state; 98 + __assign_str(name, lnk->ibname); 99 + __entry->location = location; 100 + ), 101 + 102 + TP_printk("lnk=%p lgr=%p state=%d dev=%s location=%p", 103 + __entry->lnk, __entry->lgr, 104 + __entry->state, __get_str(name), 105 + __entry->location) 106 + ); 107 + 78 108 #endif /* _TRACE_SMC_H */ 79 109 80 110 #undef TRACE_INCLUDE_PATH