Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

KVM: selftests: Fix inverted "warning" in access tracking perf test

Warn if the number of idle pages is greater than or equal to 10% of the
total number of pages, not if the percentage of idle pages is less than
10%. The original code asserted that less than 10% of pages were still
idle, but the check got inverted when the assert was converted to a
warning.

Opportunistically clean up the warning; selftests are 64-bit only, there
is no need to use "%PRIu64" instead of "%lu".

Fixes: 6336a810db5c ("KVM: selftests: replace assertion with warning in access_tracking_perf_test")
Reviewed-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Signed-off-by: Sean Christopherson <seanjc@google.com>
Link: https://lore.kernel.org/r/20221129175300.4052283-2-seanjc@google.com

+3 -4
+3 -4
tools/testing/selftests/kvm/access_tracking_perf_test.c
··· 185 185 * happens, much more pages are cached there and guest won't see the 186 186 * "idle" bit cleared. 187 187 */ 188 - if (still_idle < pages / 10) 189 - printf("WARNING: vCPU%d: Too many pages still idle (%" PRIu64 190 - "out of %" PRIu64 "), this will affect performance results" 191 - ".\n", 188 + if (still_idle >= pages / 10) 189 + printf("WARNING: vCPU%d: Too many pages still idle (%lu out of %lu), " 190 + "this will affect performance results.\n", 192 191 vcpu_idx, still_idle, pages); 193 192 194 193 close(page_idle_fd);