Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

clk: mediatek: mt7622-apmixedsys: Fix an error handling path in clk_mt8135_apmixed_probe()

'clk_data' is allocated with mtk_devm_alloc_clk_data(). So calling
mtk_free_clk_data() explicitly in the remove function would lead to a
double-free.

Remove the redundant call.

Fixes: c50e2ea6507b ("clk: mediatek: mt7622-apmixedsys: Add .remove() callback for module build")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/2c553c2a5077757e4f7af0bb895acc43881cf62c.1704616152.git.christophe.jaillet@wanadoo.fr
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

authored by

Christophe JAILLET and committed by
Stephen Boyd
a32e88f2 03c1c51e

-1
-1
drivers/clk/mediatek/clk-mt7622-apmixedsys.c
··· 127 127 of_clk_del_provider(node); 128 128 mtk_clk_unregister_gates(apmixed_clks, ARRAY_SIZE(apmixed_clks), clk_data); 129 129 mtk_clk_unregister_plls(plls, ARRAY_SIZE(plls), clk_data); 130 - mtk_free_clk_data(clk_data); 131 130 } 132 131 133 132 static const struct of_device_id of_match_clk_mt7622_apmixed[] = {