Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

perf intel-pt: Fix next 'err' value, walking trace

Code after label 'next:' in intel_pt_walk_trace() assumes 'err' is zero,
but it may not be, if arrived at via a 'goto'. Ensure it is zero.

Fixes: 7c1b16ba0e26e6 ("perf intel-pt: Add support for decoding FUP/TIP only")
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: stable@vger.kernel.org # v5.15+
Link: https://lore.kernel.org/r/20211210162303.2288710-6-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

authored by

Adrian Hunter and committed by
Arnaldo Carvalho de Melo
a32e6c5d c79ee2b2

+1
+1
tools/perf/util/intel-pt-decoder/intel-pt-decoder.c
··· 2942 2942 if (err) 2943 2943 return err; 2944 2944 next: 2945 + err = 0; 2945 2946 if (decoder->cyc_threshold) { 2946 2947 if (decoder->sample_cyc && last_packet_type != INTEL_PT_CYC) 2947 2948 decoder->sample_cyc = false;