Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ASoC: codecs: tscs42xx: use snd_kcontrol_chip() instead of snd_soc_kcontrol_component()

We have very similar name functions (A)(B). Both gets component from
snd_kcontrol, but (A) is used in callback functions which is registered
through snd_soc_add_component_controls(), (B) is used through
snd_soc_dapm_new_widgets().

(A) snd_soc_kcontrol_component()
(B) snd_soc_dapm_kcontrol_component()

(B) is using very picky way to get component but using it is necessary in
ASoC. But (A) is just wrapper function to snd_kcontrol_chip(), and directly
using it without wrapper is very common way on ALSA.
To reduce confusions of similar function, let's use common way on (A).

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://patch.msgid.link/87a51up0t6.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Kuninori Morimoto and committed by
Mark Brown
a31e9992 a6531a04

+2 -4
+2 -4
sound/soc/codecs/tscs42xx.c
··· 263 263 static int coeff_ram_get(struct snd_kcontrol *kcontrol, 264 264 struct snd_ctl_elem_value *ucontrol) 265 265 { 266 - struct snd_soc_component *component = 267 - snd_soc_kcontrol_component(kcontrol); 266 + struct snd_soc_component *component = snd_kcontrol_chip(kcontrol); 268 267 struct tscs42xx *tscs42xx = snd_soc_component_get_drvdata(component); 269 268 struct coeff_ram_ctl *ctl = 270 269 (struct coeff_ram_ctl *)kcontrol->private_value; ··· 282 283 static int coeff_ram_put(struct snd_kcontrol *kcontrol, 283 284 struct snd_ctl_elem_value *ucontrol) 284 285 { 285 - struct snd_soc_component *component = 286 - snd_soc_kcontrol_component(kcontrol); 286 + struct snd_soc_component *component = snd_kcontrol_chip(kcontrol); 287 287 struct tscs42xx *tscs42xx = snd_soc_component_get_drvdata(component); 288 288 struct coeff_ram_ctl *ctl = 289 289 (struct coeff_ram_ctl *)kcontrol->private_value;