Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

qlge: Fix sparse endian warning for inbound packet control block flags.

Changed flags element from __le32 to 3 reserved bytes and one byte of
flags. Changed flags bit definitions to reflect byte width instead of
__le32 width.

Warnings:
drivers/net/qlge/qlge_main.c:1206:16: warning: restricted degrades to integer
drivers/net/qlge/qlge_main.c:1207:16: warning: restricted degrades to integer
drivers/net/qlge/qlge_main.c:1233:17: warning: restricted degrades to integer
drivers/net/qlge/qlge_main.c:1276:17: warning: restricted degrades to integer
drivers/net/qlge/qlge_main.c:1349:19: warning: restricted degrades to integer

Signed-off-by: Ron Mercer <ron.mercer@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Ron Mercer and committed by
David S. Miller
a303ce09 8306c952

+9 -11
+5 -4
drivers/net/qlge/qlge.h
··· 979 979 980 980 __le16 reserved1; 981 981 __le32 reserved2[6]; 982 - __le32 flags4; 983 - #define IB_MAC_IOCB_RSP_HV 0x20000000 /* */ 984 - #define IB_MAC_IOCB_RSP_HS 0x40000000 /* */ 985 - #define IB_MAC_IOCB_RSP_HL 0x80000000 /* */ 982 + u8 reserved3[3]; 983 + u8 flags4; 984 + #define IB_MAC_IOCB_RSP_HV 0x20 985 + #define IB_MAC_IOCB_RSP_HS 0x40 986 + #define IB_MAC_IOCB_RSP_HL 0x80 986 987 __le32 hdr_len; /* */ 987 988 __le32 hdr_addr_lo; /* */ 988 989 __le32 hdr_addr_hi; /* */
+4 -7
drivers/net/qlge/qlge_dbg.c
··· 821 821 le16_to_cpu(ib_mac_rsp->vlan_id)); 822 822 823 823 printk(KERN_ERR PFX "flags4 = %s%s%s.\n", 824 - le32_to_cpu(ib_mac_rsp-> 825 - flags4) & IB_MAC_IOCB_RSP_HV ? "HV " : "", 826 - le32_to_cpu(ib_mac_rsp-> 827 - flags4) & IB_MAC_IOCB_RSP_HS ? "HS " : "", 828 - le32_to_cpu(ib_mac_rsp-> 829 - flags4) & IB_MAC_IOCB_RSP_HL ? "HL " : ""); 824 + ib_mac_rsp->flags4 & IB_MAC_IOCB_RSP_HV ? "HV " : "", 825 + ib_mac_rsp->flags4 & IB_MAC_IOCB_RSP_HS ? "HS " : "", 826 + ib_mac_rsp->flags4 & IB_MAC_IOCB_RSP_HL ? "HL " : ""); 830 827 831 - if (le32_to_cpu(ib_mac_rsp->flags4) & IB_MAC_IOCB_RSP_HV) { 828 + if (ib_mac_rsp->flags4 & IB_MAC_IOCB_RSP_HV) { 832 829 printk(KERN_ERR PFX "hdr length = %d.\n", 833 830 le32_to_cpu(ib_mac_rsp->hdr_len)); 834 831 printk(KERN_ERR PFX "hdr addr_hi = 0x%x.\n",