Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

bcache: Convert to use sysfs_emit()/sysfs_emit_at() APIs

Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Signed-off-by: Coly Li <colyli@suse.de>
Link: https://lore.kernel.org/r/20230615121223.22502-2-colyli@suse.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>

authored by

ye xingchen and committed by
Jens Axboe
a301b2de dd7de370

+15 -16
+15 -16
drivers/md/bcache/sysfs.c
··· 1111 1111 1112 1112 vfree(p); 1113 1113 1114 - ret = scnprintf(buf, PAGE_SIZE, 1115 - "Unused: %zu%%\n" 1116 - "Clean: %zu%%\n" 1117 - "Dirty: %zu%%\n" 1118 - "Metadata: %zu%%\n" 1119 - "Average: %llu\n" 1120 - "Sectors per Q: %zu\n" 1121 - "Quantiles: [", 1122 - unused * 100 / (size_t) ca->sb.nbuckets, 1123 - available * 100 / (size_t) ca->sb.nbuckets, 1124 - dirty * 100 / (size_t) ca->sb.nbuckets, 1125 - meta * 100 / (size_t) ca->sb.nbuckets, sum, 1126 - n * ca->sb.bucket_size / (ARRAY_SIZE(q) + 1)); 1114 + ret = sysfs_emit(buf, 1115 + "Unused: %zu%%\n" 1116 + "Clean: %zu%%\n" 1117 + "Dirty: %zu%%\n" 1118 + "Metadata: %zu%%\n" 1119 + "Average: %llu\n" 1120 + "Sectors per Q: %zu\n" 1121 + "Quantiles: [", 1122 + unused * 100 / (size_t) ca->sb.nbuckets, 1123 + available * 100 / (size_t) ca->sb.nbuckets, 1124 + dirty * 100 / (size_t) ca->sb.nbuckets, 1125 + meta * 100 / (size_t) ca->sb.nbuckets, sum, 1126 + n * ca->sb.bucket_size / (ARRAY_SIZE(q) + 1)); 1127 1127 1128 1128 for (i = 0; i < ARRAY_SIZE(q); i++) 1129 - ret += scnprintf(buf + ret, PAGE_SIZE - ret, 1130 - "%u ", q[i]); 1129 + ret += sysfs_emit_at(buf, ret, "%u ", q[i]); 1131 1130 ret--; 1132 1131 1133 - ret += scnprintf(buf + ret, PAGE_SIZE - ret, "]\n"); 1132 + ret += sysfs_emit_at(buf, ret, "]\n"); 1134 1133 1135 1134 return ret; 1136 1135 }