Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

pwm: samsung: Fix a bit test in pwm_samsung_resume()

The PWMF_REQUESTED enum is supposed to be used with test_bit() and not
used as in a bitwise AND. In this specific code the flag will never be
set so the function is effectively a no-op.

Fixes: e3fe982b2e4e ("pwm: samsung: Put per-channel data into driver data")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>

authored by

Dan Carpenter and committed by
Thierry Reding
a2da597f 40592064

+1 -1
+1 -1
drivers/pwm/pwm-samsung.c
··· 631 631 struct pwm_device *pwm = &chip->pwms[i]; 632 632 struct samsung_pwm_channel *chan = &our_chip->channel[i]; 633 633 634 - if (!(pwm->flags & PWMF_REQUESTED)) 634 + if (!test_bit(PWMF_REQUESTED, &pwm->flags)) 635 635 continue; 636 636 637 637 if (our_chip->variant.output_mask & BIT(i))