Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

bpf: Fix memory leak on object 'data'

The error return path on when bpf_fentry_test* tests fail does not
kfree 'data'. Fix this by adding the missing kfree.

Addresses-Coverity: ("Resource leak")

Fixes: faeb2dce084a ("bpf: Add kernel test functions for fentry testing")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/20191118114059.37287-1-colin.king@canonical.com

authored by

Colin Ian King and committed by
Alexei Starovoitov
a25ecd9d 2ea2612b

+3 -1
+3 -1
net/bpf/test_run.c
··· 161 161 bpf_fentry_test3(4, 5, 6) != 15 || 162 162 bpf_fentry_test4((void *)7, 8, 9, 10) != 34 || 163 163 bpf_fentry_test5(11, (void *)12, 13, 14, 15) != 65 || 164 - bpf_fentry_test6(16, (void *)17, 18, 19, (void *)20, 21) != 111) 164 + bpf_fentry_test6(16, (void *)17, 18, 19, (void *)20, 21) != 111) { 165 + kfree(data); 165 166 return ERR_PTR(-EFAULT); 167 + } 166 168 return data; 167 169 } 168 170