Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

xfrm: fix policy unreferencing on larval drop

I mistakenly had the error path to use num_pols to decide how
many policies we need to drop (cruft from earlier patch set
version which did not handle socket policies right).

This is wrong since normally we do not keep explicit references
(instead we hold reference to the cache entry which holds references
to policies). drop_pols is set to num_pols if we are holding the
references, so use that. Otherwise we eventually BUG_ON inside
xfrm_policy_destroy due to premature policy deletion.

Signed-off-by: Timo Teras <timo.teras@iki.fi>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Timo Teras and committed by
David S. Miller
a1aa3483 a14462f1

+1 -1
+1 -1
net/xfrm/xfrm_policy.c
··· 1805 1805 /* EREMOTE tells the caller to generate 1806 1806 * a one-shot blackhole route. */ 1807 1807 dst_release(dst); 1808 - xfrm_pols_put(pols, num_pols); 1808 + xfrm_pols_put(pols, drop_pols); 1809 1809 XFRM_INC_STATS(net, LINUX_MIB_XFRMOUTNOSTATES); 1810 1810 return -EREMOTE; 1811 1811 }