Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[media] radio-si470x-usb: use USB API functions rather than constants

This patch introduces the use of the function usb_endpoint_is_int_in.

The Coccinelle semantic patch that makes these changes is as follows:

@@ struct usb_endpoint_descriptor *epd; @@

- ((epd->bEndpointAddress & \(USB_ENDPOINT_DIR_MASK\|0x80\)) ==
- \(USB_DIR_IN\|0x80\))
+ usb_endpoint_dir_in(epd)

@@ struct usb_endpoint_descriptor *epd; @@

- ((epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\)) ==
- \(USB_ENDPOINT_XFER_INT\|3\))
+ usb_endpoint_xfer_int(epd)

@@ struct usb_endpoint_descriptor *epd; @@

- (usb_endpoint_xfer_int(epd) && usb_endpoint_dir_in(epd))
+ usb_endpoint_is_int_in(epd)

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

authored by

Himangi Saraogi and committed by
Mauro Carvalho Chehab
a0ffe4c0 3b60b761

+1 -3
+1 -3
drivers/media/radio/si470x/radio-si470x-usb.c
··· 607 607 /* Set up interrupt endpoint information. */ 608 608 for (i = 0; i < iface_desc->desc.bNumEndpoints; ++i) { 609 609 endpoint = &iface_desc->endpoint[i].desc; 610 - if (((endpoint->bEndpointAddress & USB_ENDPOINT_DIR_MASK) == 611 - USB_DIR_IN) && ((endpoint->bmAttributes & 612 - USB_ENDPOINT_XFERTYPE_MASK) == USB_ENDPOINT_XFER_INT)) 610 + if (usb_endpoint_is_int_in(endpoint)) 613 611 radio->int_in_endpoint = endpoint; 614 612 } 615 613 if (!radio->int_in_endpoint) {