Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

regulator: axp20x: Fix misleading use of negation

It works incidentally, because AXP20X_DCDC2_LDO3_V_RAMP_DCDC2_EN
is non-zero, but the false branch value really should be just 0.

Signed-off-by: Ondrej Jirman <megous@megous.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Link: https://lore.kernel.org/r/20200222235634.243805-1-megous@megous.com
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Ondrej Jirman and committed by
Mark Brown
a0fc8b6a 502cdd60

+2 -4
+2 -4
drivers/regulator/axp20x-regulator.c
··· 381 381 mask = AXP20X_DCDC2_LDO3_V_RAMP_DCDC2_RATE_MASK | 382 382 AXP20X_DCDC2_LDO3_V_RAMP_DCDC2_EN_MASK; 383 383 enable = (ramp > 0) ? 384 - AXP20X_DCDC2_LDO3_V_RAMP_DCDC2_EN : 385 - !AXP20X_DCDC2_LDO3_V_RAMP_DCDC2_EN; 384 + AXP20X_DCDC2_LDO3_V_RAMP_DCDC2_EN : 0; 386 385 break; 387 386 } 388 387 ··· 392 393 mask = AXP20X_DCDC2_LDO3_V_RAMP_LDO3_RATE_MASK | 393 394 AXP20X_DCDC2_LDO3_V_RAMP_LDO3_EN_MASK; 394 395 enable = (ramp > 0) ? 395 - AXP20X_DCDC2_LDO3_V_RAMP_LDO3_EN : 396 - !AXP20X_DCDC2_LDO3_V_RAMP_LDO3_EN; 396 + AXP20X_DCDC2_LDO3_V_RAMP_LDO3_EN : 0; 397 397 break; 398 398 } 399 399