Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

video: fbdev: pxa3xx-gcu: Fix integer overflow in pxa3xx_gcu_write

In pxa3xx_gcu_write, a count parameter of type size_t is passed to words of
type int. Then, copy_from_user() may cause a heap overflow because it is used
as the third argument of copy_from_user().

Signed-off-by: Hyunwoo Kim <imv4bel@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>

authored by

Hyunwoo Kim and committed by
Helge Deller
a09d2d00 267173cb

+1 -1
+1 -1
drivers/video/fbdev/pxa3xx-gcu.c
··· 381 381 struct pxa3xx_gcu_batch *buffer; 382 382 struct pxa3xx_gcu_priv *priv = to_pxa3xx_gcu_priv(file); 383 383 384 - int words = count / 4; 384 + size_t words = count / 4; 385 385 386 386 /* Does not need to be atomic. There's a lock in user space, 387 387 * but anyhow, this is just for statistics. */