tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

Revert "sparc: Convert to using %pOFn instead of device_node.name"

This reverts commit 0b9871a3a8cc7234c285b5d9bf66cc6712cfee7c.

Causes crashes with qemu, interacts badly with commit commit
6d0a70a284be ("vsprintf: print OF node name using full_name")
etc.

Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

David S. Miller a06ecbfe d1f1f98c

+51 -51
unified split
+2 -2
arch/sparc/kernel/auxio_64.c
··· 115 115 auxio_devtype = AUXIO_TYPE_SBUS; 116 116 size = 1; 117 117 } else { 118 - printk("auxio: Unknown parent bus type [%pOFn]\n", 119 - dp->parent); 118 + printk("auxio: Unknown parent bus type [%s]\n", 119 + dp->parent->name); 120 120 return -ENODEV; 121 121 } 122 122 auxio_register = of_ioremap(&dev->resource[0], 0, size, "auxio");
+2 -2
arch/sparc/kernel/power.c
··· 41 41 42 42 power_reg = of_ioremap(res, 0, 0x4, "power"); 43 43 44 - printk(KERN_INFO "%pOFn: Control reg at %llx\n", 45 - op->dev.of_node, res->start); 44 + printk(KERN_INFO "%s: Control reg at %llx\n", 45 + op->dev.of_node->name, res->start); 46 46 47 47 if (has_button_interrupt(irq, op->dev.of_node)) { 48 48 if (request_irq(irq,
+13 -13
arch/sparc/kernel/prom_32.c
··· 68 68 return; 69 69 70 70 regs = rprop->value; 71 - sprintf(tmp_buf, "%pOFn@%x,%x", 72 - dp, 71 + sprintf(tmp_buf, "%s@%x,%x", 72 + dp->name, 73 73 regs->which_io, regs->phys_addr); 74 74 } 75 75 ··· 84 84 return; 85 85 86 86 regs = prop->value; 87 - sprintf(tmp_buf, "%pOFn@%x,%x", 88 - dp, 87 + sprintf(tmp_buf, "%s@%x,%x", 88 + dp->name, 89 89 regs->which_io, 90 90 regs->phys_addr); 91 91 } ··· 104 104 regs = prop->value; 105 105 devfn = (regs->phys_hi >> 8) & 0xff; 106 106 if (devfn & 0x07) { 107 - sprintf(tmp_buf, "%pOFn@%x,%x", 108 - dp, 107 + sprintf(tmp_buf, "%s@%x,%x", 108 + dp->name, 109 109 devfn >> 3, 110 110 devfn & 0x07); 111 111 } else { 112 - sprintf(tmp_buf, "%pOFn@%x", 113 - dp, 112 + sprintf(tmp_buf, "%s@%x", 113 + dp->name, 114 114 devfn >> 3); 115 115 } 116 116 } ··· 127 127 128 128 regs = prop->value; 129 129 130 - sprintf(tmp_buf, "%pOFn@%x,%x", 131 - dp, 130 + sprintf(tmp_buf, "%s@%x,%x", 131 + dp->name, 132 132 regs->which_io, regs->phys_addr); 133 133 } 134 134 ··· 167 167 return; 168 168 device = prop->value; 169 169 170 - sprintf(tmp_buf, "%pOFn:%d:%d@%x,%x", 171 - dp, *vendor, *device, 170 + sprintf(tmp_buf, "%s:%d:%d@%x,%x", 171 + dp->name, *vendor, *device, 172 172 *intr, reg0); 173 173 } 174 174 ··· 201 201 tmp_buf[0] = '\0'; 202 202 __build_path_component(dp, tmp_buf); 203 203 if (tmp_buf[0] == '\0') 204 - snprintf(tmp_buf, sizeof(tmp_buf), "%pOFn", dp); 204 + strcpy(tmp_buf, dp->name); 205 205 206 206 n = prom_early_alloc(strlen(tmp_buf) + 1); 207 207 strcpy(n, tmp_buf);
+34 -34
arch/sparc/kernel/prom_64.c
··· 82 82 83 83 regs = rprop->value; 84 84 if (!of_node_is_root(dp->parent)) { 85 - sprintf(tmp_buf, "%pOFn@%x,%x", 86 - dp, 85 + sprintf(tmp_buf, "%s@%x,%x", 86 + dp->name, 87 87 (unsigned int) (regs->phys_addr >> 32UL), 88 88 (unsigned int) (regs->phys_addr & 0xffffffffUL)); 89 89 return; ··· 97 97 const char *prefix = (type == 0) ? "m" : "i"; 98 98 99 99 if (low_bits) 100 - sprintf(tmp_buf, "%pOFn@%s%x,%x", 101 - dp, prefix, 100 + sprintf(tmp_buf, "%s@%s%x,%x", 101 + dp->name, prefix, 102 102 high_bits, low_bits); 103 103 else 104 - sprintf(tmp_buf, "%pOFn@%s%x", 105 - dp, 104 + sprintf(tmp_buf, "%s@%s%x", 105 + dp->name, 106 106 prefix, 107 107 high_bits); 108 108 } else if (type == 12) { 109 - sprintf(tmp_buf, "%pOFn@%x", 110 - dp, high_bits); 109 + sprintf(tmp_buf, "%s@%x", 110 + dp->name, high_bits); 111 111 } 112 112 } 113 113 ··· 122 122 123 123 regs = prop->value; 124 124 if (!of_node_is_root(dp->parent)) { 125 - sprintf(tmp_buf, "%pOFn@%x,%x", 126 - dp, 125 + sprintf(tmp_buf, "%s@%x,%x", 126 + dp->name, 127 127 (unsigned int) (regs->phys_addr >> 32UL), 128 128 (unsigned int) (regs->phys_addr & 0xffffffffUL)); 129 129 return; ··· 138 138 if (tlb_type >= cheetah) 139 139 mask = 0x7fffff; 140 140 141 - sprintf(tmp_buf, "%pOFn@%x,%x", 142 - dp, 141 + sprintf(tmp_buf, "%s@%x,%x", 142 + dp->name, 143 143 *(u32 *)prop->value, 144 144 (unsigned int) (regs->phys_addr & mask)); 145 145 } ··· 156 156 return; 157 157 158 158 regs = prop->value; 159 - sprintf(tmp_buf, "%pOFn@%x,%x", 160 - dp, 159 + sprintf(tmp_buf, "%s@%x,%x", 160 + dp->name, 161 161 regs->which_io, 162 162 regs->phys_addr); 163 163 } ··· 176 176 regs = prop->value; 177 177 devfn = (regs->phys_hi >> 8) & 0xff; 178 178 if (devfn & 0x07) { 179 - sprintf(tmp_buf, "%pOFn@%x,%x", 180 - dp, 179 + sprintf(tmp_buf, "%s@%x,%x", 180 + dp->name, 181 181 devfn >> 3, 182 182 devfn & 0x07); 183 183 } else { 184 - sprintf(tmp_buf, "%pOFn@%x", 185 - dp, 184 + sprintf(tmp_buf, "%s@%x", 185 + dp->name, 186 186 devfn >> 3); 187 187 } 188 188 } ··· 203 203 if (!prop) 204 204 return; 205 205 206 - sprintf(tmp_buf, "%pOFn@%x,%x", 207 - dp, 206 + sprintf(tmp_buf, "%s@%x,%x", 207 + dp->name, 208 208 *(u32 *) prop->value, 209 209 (unsigned int) (regs->phys_addr & 0xffffffffUL)); 210 210 } ··· 221 221 222 222 regs = prop->value; 223 223 224 - sprintf(tmp_buf, "%pOFn@%x", dp, *regs); 224 + sprintf(tmp_buf, "%s@%x", dp->name, *regs); 225 225 } 226 226 227 227 /* "name@addrhi,addrlo" */ ··· 236 236 237 237 regs = prop->value; 238 238 239 - sprintf(tmp_buf, "%pOFn@%x,%x", 240 - dp, 239 + sprintf(tmp_buf, "%s@%x,%x", 240 + dp->name, 241 241 (unsigned int) (regs->phys_addr >> 32UL), 242 242 (unsigned int) (regs->phys_addr & 0xffffffffUL)); 243 243 } ··· 257 257 /* This actually isn't right... should look at the #address-cells 258 258 * property of the i2c bus node etc. etc. 259 259 */ 260 - sprintf(tmp_buf, "%pOFn@%x,%x", 261 - dp, regs[0], regs[1]); 260 + sprintf(tmp_buf, "%s@%x,%x", 261 + dp->name, regs[0], regs[1]); 262 262 } 263 263 264 264 /* "name@reg0[,reg1]" */ ··· 274 274 regs = prop->value; 275 275 276 276 if (prop->length == sizeof(u32) || regs[1] == 1) { 277 - sprintf(tmp_buf, "%pOFn@%x", 278 - dp, regs[0]); 277 + sprintf(tmp_buf, "%s@%x", 278 + dp->name, regs[0]); 279 279 } else { 280 - sprintf(tmp_buf, "%pOFn@%x,%x", 281 - dp, regs[0], regs[1]); 280 + sprintf(tmp_buf, "%s@%x,%x", 281 + dp->name, regs[0], regs[1]); 282 282 } 283 283 } 284 284 ··· 295 295 regs = prop->value; 296 296 297 297 if (regs[2] || regs[3]) { 298 - sprintf(tmp_buf, "%pOFn@%08x%08x,%04x%08x", 299 - dp, regs[0], regs[1], regs[2], regs[3]); 298 + sprintf(tmp_buf, "%s@%08x%08x,%04x%08x", 299 + dp->name, regs[0], regs[1], regs[2], regs[3]); 300 300 } else { 301 - sprintf(tmp_buf, "%pOFn@%08x%08x", 302 - dp, regs[0], regs[1]); 301 + sprintf(tmp_buf, "%s@%08x%08x", 302 + dp->name, regs[0], regs[1]); 303 303 } 304 304 } 305 305 ··· 361 361 tmp_buf[0] = '\0'; 362 362 __build_path_component(dp, tmp_buf); 363 363 if (tmp_buf[0] == '\0') 364 - snprintf(tmp_buf, sizeof(tmp_buf), "%pOFn", dp); 364 + strcpy(tmp_buf, dp->name); 365 365 366 366 n = prom_early_alloc(strlen(tmp_buf) + 1); 367 367 strcpy(n, tmp_buf);