Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

selftests/user_events: Fix failures when user_events is not installed

When user_events is not installed the self tests currently fail. Now
that these self tests run by default we need to ensure they don't fail
when user_events was not enabled for the kernel being tested.

Add common methods to detect if tracefs and user_events is enabled. If
either is not enabled skip the test. If tracefs is enabled, but is not
mounted, mount tracefs and fail if there were any errors. Fail if not
run as root.

Fixes: 68b4d2d58389 ("selftests/user_events: Reenable build")
Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Link: https://lore.kernel.org/all/CA+G9fYuugZ0OMeS6HvpSS4nuf_A3s455ecipGBvER0LJHojKZg@mail.gmail.com/

Signed-off-by: Beau Belgrave <beaub@linux.microsoft.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>

authored by

Beau Belgrave and committed by
Shuah Khan
a06023a8 0bb80ecc

+111
+3
tools/testing/selftests/user_events/abi_test.c
··· 19 19 #include <asm/unistd.h> 20 20 21 21 #include "../kselftest_harness.h" 22 + #include "user_events_selftests.h" 22 23 23 24 const char *data_file = "/sys/kernel/tracing/user_events_data"; 24 25 const char *enable_file = "/sys/kernel/tracing/events/user_events/__abi_event/enable"; ··· 94 93 }; 95 94 96 95 FIXTURE_SETUP(user) { 96 + USER_EVENT_FIXTURE_SETUP(return); 97 + 97 98 change_event(false); 98 99 self->check = 0; 99 100 }
+2
tools/testing/selftests/user_events/dyn_test.c
··· 15 15 #include <unistd.h> 16 16 17 17 #include "../kselftest_harness.h" 18 + #include "user_events_selftests.h" 18 19 19 20 const char *abi_file = "/sys/kernel/tracing/user_events_data"; 20 21 const char *enable_file = "/sys/kernel/tracing/events/user_events/__test_event/enable"; ··· 147 146 }; 148 147 149 148 FIXTURE_SETUP(user) { 149 + USER_EVENT_FIXTURE_SETUP(return); 150 150 } 151 151 152 152 FIXTURE_TEARDOWN(user) {
+3
tools/testing/selftests/user_events/ftrace_test.c
··· 16 16 #include <unistd.h> 17 17 18 18 #include "../kselftest_harness.h" 19 + #include "user_events_selftests.h" 19 20 20 21 const char *data_file = "/sys/kernel/tracing/user_events_data"; 21 22 const char *status_file = "/sys/kernel/tracing/user_events_status"; ··· 207 206 }; 208 207 209 208 FIXTURE_SETUP(user) { 209 + USER_EVENT_FIXTURE_SETUP(return); 210 + 210 211 self->status_fd = open(status_file, O_RDONLY); 211 212 ASSERT_NE(-1, self->status_fd); 212 213
+3
tools/testing/selftests/user_events/perf_test.c
··· 17 17 #include <asm/unistd.h> 18 18 19 19 #include "../kselftest_harness.h" 20 + #include "user_events_selftests.h" 20 21 21 22 const char *data_file = "/sys/kernel/tracing/user_events_data"; 22 23 const char *id_file = "/sys/kernel/tracing/events/user_events/__test_event/id"; ··· 114 113 }; 115 114 116 115 FIXTURE_SETUP(user) { 116 + USER_EVENT_FIXTURE_SETUP(return); 117 + 117 118 self->data_fd = open(data_file, O_RDWR); 118 119 ASSERT_NE(-1, self->data_fd); 119 120 }
+100
tools/testing/selftests/user_events/user_events_selftests.h
··· 1 + /* SPDX-License-Identifier: GPL-2.0 */ 2 + 3 + #ifndef _USER_EVENTS_SELFTESTS_H 4 + #define _USER_EVENTS_SELFTESTS_H 5 + 6 + #include <sys/stat.h> 7 + #include <sys/types.h> 8 + #include <sys/mount.h> 9 + #include <unistd.h> 10 + #include <errno.h> 11 + 12 + #include "../kselftest.h" 13 + 14 + static inline bool tracefs_enabled(char **message, bool *fail) 15 + { 16 + struct stat buf; 17 + int ret; 18 + 19 + *message = ""; 20 + *fail = false; 21 + 22 + /* Ensure tracefs is installed */ 23 + ret = stat("/sys/kernel/tracing", &buf); 24 + 25 + if (ret == -1) { 26 + *message = "Tracefs is not installed"; 27 + return false; 28 + } 29 + 30 + /* Ensure mounted tracefs */ 31 + ret = stat("/sys/kernel/tracing/README", &buf); 32 + 33 + if (ret == -1 && errno == ENOENT) { 34 + if (mount(NULL, "/sys/kernel/tracing", "tracefs", 0, NULL) != 0) { 35 + *message = "Cannot mount tracefs"; 36 + *fail = true; 37 + return false; 38 + } 39 + 40 + ret = stat("/sys/kernel/tracing/README", &buf); 41 + } 42 + 43 + if (ret == -1) { 44 + *message = "Cannot access tracefs"; 45 + *fail = true; 46 + return false; 47 + } 48 + 49 + return true; 50 + } 51 + 52 + static inline bool user_events_enabled(char **message, bool *fail) 53 + { 54 + struct stat buf; 55 + int ret; 56 + 57 + *message = ""; 58 + *fail = false; 59 + 60 + if (getuid() != 0) { 61 + *message = "Must be run as root"; 62 + *fail = true; 63 + return false; 64 + } 65 + 66 + if (!tracefs_enabled(message, fail)) 67 + return false; 68 + 69 + /* Ensure user_events is installed */ 70 + ret = stat("/sys/kernel/tracing/user_events_data", &buf); 71 + 72 + if (ret == -1) { 73 + switch (errno) { 74 + case ENOENT: 75 + *message = "user_events is not installed"; 76 + return false; 77 + 78 + default: 79 + *message = "Cannot access user_events_data"; 80 + *fail = true; 81 + return false; 82 + } 83 + } 84 + 85 + return true; 86 + } 87 + 88 + #define USER_EVENT_FIXTURE_SETUP(statement) do { \ 89 + char *message; \ 90 + bool fail; \ 91 + if (!user_events_enabled(&message, &fail)) { \ 92 + if (fail) { \ 93 + TH_LOG("Setup failed due to: %s", message); \ 94 + ASSERT_FALSE(fail); \ 95 + } \ 96 + SKIP(statement, "Skipping due to: %s", message); \ 97 + } \ 98 + } while (0) 99 + 100 + #endif /* _USER_EVENTS_SELFTESTS_H */