tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

ethernet: use eth_hw_addr_set() for dev->addr_len cases

Convert all Ethernet drivers from memcpy(... dev->addr_len)
to eth_hw_addr_set():

@@
expression dev, np;
@@
- memcpy(dev->dev_addr, np, dev->addr_len)
+ eth_hw_addr_set(dev, np)

In theory addr_len may not be ETH_ALEN, but we don't expect
non-Ethernet devices to live under this directory, and only
the following cases of setting addr_len exist:
- cxgb4 for mgmt device,
and the drivers which set it to ETH_ALEN: s2io, mlx4, vxge.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Jakub Kicinski and committed by
David S. Miller a05e4c0a 5e8fba84

+90 -93
+1 -1
drivers/net/ethernet/8390/ne2k-pci.c
··· 390 390 dev->ethtool_ops = &ne2k_pci_ethtool_ops; 391 391 NS8390_init(dev, 0); 392 392 393 - memcpy(dev->dev_addr, SA_prom, dev->addr_len); 393 + eth_hw_addr_set(dev, SA_prom); 394 394 395 395 i = register_netdev(dev); 396 396 if (i)
+1 -1
drivers/net/ethernet/actions/owl-emac.c
··· 1173 1173 if (netif_running(netdev)) 1174 1174 return -EBUSY; 1175 1175 1176 - memcpy(netdev->dev_addr, skaddr->sa_data, netdev->addr_len); 1176 + eth_hw_addr_set(netdev, skaddr->sa_data); 1177 1177 owl_emac_set_hw_mac_addr(netdev); 1178 1178 1179 1179 return owl_emac_setup_frame_xmit(netdev_priv(netdev));
+1 -1
drivers/net/ethernet/aeroflex/greth.c
··· 1025 1025 if (!is_valid_ether_addr(addr->sa_data)) 1026 1026 return -EADDRNOTAVAIL; 1027 1027 1028 - memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); 1028 + eth_hw_addr_set(dev, addr->sa_data); 1029 1029 GRETH_REGSAVE(regs->esa_msb, dev->dev_addr[0] << 8 | dev->dev_addr[1]); 1030 1030 GRETH_REGSAVE(regs->esa_lsb, dev->dev_addr[2] << 24 | dev->dev_addr[3] << 16 | 1031 1031 dev->dev_addr[4] << 8 | dev->dev_addr[5]);
+1 -1
drivers/net/ethernet/alteon/acenic.c
··· 2718 2718 if(netif_running(dev)) 2719 2719 return -EBUSY; 2720 2720 2721 - memcpy(dev->dev_addr, addr->sa_data,dev->addr_len); 2721 + eth_hw_addr_set(dev, addr->sa_data); 2722 2722 2723 2723 da = (u8 *)dev->dev_addr; 2724 2724
+1 -1
drivers/net/ethernet/amd/amd8111e.c
··· 1500 1500 int i; 1501 1501 struct sockaddr *addr = p; 1502 1502 1503 - memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); 1503 + eth_hw_addr_set(dev, addr->sa_data); 1504 1504 spin_lock_irq(&lp->lock); 1505 1505 /* Setting the MAC address to the device */ 1506 1506 for (i = 0; i < ETH_ALEN; i++)
+1 -1
drivers/net/ethernet/amd/atarilance.c
··· 1123 1123 return -EIO; 1124 1124 } 1125 1125 1126 - memcpy( dev->dev_addr, saddr->sa_data, dev->addr_len ); 1126 + eth_hw_addr_set(dev, saddr->sa_data); 1127 1127 for( i = 0; i < 6; i++ ) 1128 1128 MEM->init.hwaddr[i] = dev->dev_addr[i^1]; /* <- 16 bit swap! */ 1129 1129 lp->memcpy_f( RIEBL_HWADDR_ADDR, dev->dev_addr, 6 );
+1 -1
drivers/net/ethernet/amd/xgbe/xgbe-drv.c
··· 2016 2016 if (!is_valid_ether_addr(saddr->sa_data)) 2017 2017 return -EADDRNOTAVAIL; 2018 2018 2019 - memcpy(netdev->dev_addr, saddr->sa_data, netdev->addr_len); 2019 + eth_hw_addr_set(netdev, saddr->sa_data); 2020 2020 2021 2021 hw_if->set_mac_address(pdata, netdev->dev_addr); 2022 2022
+1 -1
drivers/net/ethernet/amd/xgbe/xgbe-main.c
··· 267 267 268 268 netdev->irq = pdata->dev_irq; 269 269 netdev->base_addr = (unsigned long)pdata->xgmac_regs; 270 - memcpy(netdev->dev_addr, pdata->mac_addr, netdev->addr_len); 270 + eth_hw_addr_set(netdev, pdata->mac_addr); 271 271 272 272 /* Initialize ECC timestamps */ 273 273 pdata->tx_sec_period = jiffies;
+1 -1
drivers/net/ethernet/arc/emac_main.c
··· 773 773 if (!is_valid_ether_addr(addr->sa_data)) 774 774 return -EADDRNOTAVAIL; 775 775 776 - memcpy(ndev->dev_addr, addr->sa_data, ndev->addr_len); 776 + eth_hw_addr_set(ndev, addr->sa_data); 777 777 778 778 arc_emac_set_address_internal(ndev); 779 779
+1 -1
drivers/net/ethernet/atheros/alx/main.c
··· 607 607 if (netdev->addr_assign_type & NET_ADDR_RANDOM) 608 608 netdev->addr_assign_type ^= NET_ADDR_RANDOM; 609 609 610 - memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); 610 + eth_hw_addr_set(netdev, addr->sa_data); 611 611 memcpy(hw->mac_addr, addr->sa_data, netdev->addr_len); 612 612 alx_set_macaddr(hw, hw->mac_addr); 613 613
+2 -2
drivers/net/ethernet/atheros/atl1c/atl1c_main.c
··· 482 482 if (netif_running(netdev)) 483 483 return -EBUSY; 484 484 485 - memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); 485 + eth_hw_addr_set(netdev, addr->sa_data); 486 486 memcpy(adapter->hw.mac_addr, addr->sa_data, netdev->addr_len); 487 487 488 488 atl1c_hw_set_mac_addr(&adapter->hw, adapter->hw.mac_addr); ··· 2767 2767 /* got a random MAC address, set NET_ADDR_RANDOM to netdev */ 2768 2768 netdev->addr_assign_type = NET_ADDR_RANDOM; 2769 2769 } 2770 - memcpy(netdev->dev_addr, adapter->hw.mac_addr, netdev->addr_len); 2770 + eth_hw_addr_set(netdev, adapter->hw.mac_addr); 2771 2771 if (netif_msg_probe(adapter)) 2772 2772 dev_dbg(&pdev->dev, "mac address : %pM\n", 2773 2773 adapter->hw.mac_addr);
+2 -2
drivers/net/ethernet/atheros/atl1e/atl1e_main.c
··· 374 374 if (netif_running(netdev)) 375 375 return -EBUSY; 376 376 377 - memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); 377 + eth_hw_addr_set(netdev, addr->sa_data); 378 378 memcpy(adapter->hw.mac_addr, addr->sa_data, netdev->addr_len); 379 379 380 380 atl1e_hw_set_mac_addr(&adapter->hw); ··· 2390 2390 goto err_eeprom; 2391 2391 } 2392 2392 2393 - memcpy(netdev->dev_addr, adapter->hw.mac_addr, netdev->addr_len); 2393 + eth_hw_addr_set(netdev, adapter->hw.mac_addr); 2394 2394 netdev_dbg(netdev, "mac address : %pM\n", adapter->hw.mac_addr); 2395 2395 2396 2396 INIT_WORK(&adapter->reset_task, atl1e_reset_task);
+1 -1
drivers/net/ethernet/atheros/atlx/atl1.c
··· 3027 3027 /* mark random mac */ 3028 3028 netdev->addr_assign_type = NET_ADDR_RANDOM; 3029 3029 } 3030 - memcpy(netdev->dev_addr, adapter->hw.mac_addr, netdev->addr_len); 3030 + eth_hw_addr_set(netdev, adapter->hw.mac_addr); 3031 3031 3032 3032 if (!is_valid_ether_addr(netdev->dev_addr)) { 3033 3033 err = -EIO;
+2 -2
drivers/net/ethernet/atheros/atlx/atl2.c
··· 931 931 if (netif_running(netdev)) 932 932 return -EBUSY; 933 933 934 - memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); 934 + eth_hw_addr_set(netdev, addr->sa_data); 935 935 memcpy(adapter->hw.mac_addr, addr->sa_data, netdev->addr_len); 936 936 937 937 atl2_set_mac_addr(&adapter->hw); ··· 1405 1405 1406 1406 /* copy the MAC address out of the EEPROM */ 1407 1407 atl2_read_mac_addr(&adapter->hw); 1408 - memcpy(netdev->dev_addr, adapter->hw.mac_addr, netdev->addr_len); 1408 + eth_hw_addr_set(netdev, adapter->hw.mac_addr); 1409 1409 if (!is_valid_ether_addr(netdev->dev_addr)) { 1410 1410 err = -EIO; 1411 1411 goto err_eeprom;
+1 -1
drivers/net/ethernet/atheros/atlx/atlx.c
··· 69 69 if (!is_valid_ether_addr(addr->sa_data)) 70 70 return -EADDRNOTAVAIL; 71 71 72 - memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); 72 + eth_hw_addr_set(netdev, addr->sa_data); 73 73 memcpy(adapter->hw.mac_addr, addr->sa_data, netdev->addr_len); 74 74 75 75 atlx_set_mac_addr(&adapter->hw);
+1 -1
drivers/net/ethernet/broadcom/b44.c
··· 1383 1383 if (!is_valid_ether_addr(addr->sa_data)) 1384 1384 return -EINVAL; 1385 1385 1386 - memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); 1386 + eth_hw_addr_set(dev, addr->sa_data); 1387 1387 1388 1388 spin_lock_irq(&bp->lock); 1389 1389
+1 -1
drivers/net/ethernet/broadcom/bcmsysport.c
··· 1850 1850 if (!is_valid_ether_addr(addr->sa_data)) 1851 1851 return -EINVAL; 1852 1852 1853 - memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); 1853 + eth_hw_addr_set(dev, addr->sa_data); 1854 1854 1855 1855 /* interface is disabled, changes to MAC will be reflected on next 1856 1856 * open call
+1 -1
drivers/net/ethernet/broadcom/bnx2.c
··· 7910 7910 if (!is_valid_ether_addr(addr->sa_data)) 7911 7911 return -EADDRNOTAVAIL; 7912 7912 7913 - memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); 7913 + eth_hw_addr_set(dev, addr->sa_data); 7914 7914 if (netif_running(dev)) 7915 7915 bnx2_set_mac_addr(bp, bp->dev->dev_addr, 0); 7916 7916
+1 -1
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
··· 4336 4336 return rc; 4337 4337 } 4338 4338 4339 - memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); 4339 + eth_hw_addr_set(dev, addr->sa_data); 4340 4340 4341 4341 if (netif_running(dev)) 4342 4342 rc = bnx2x_set_eth_mac(bp, true);
+1 -1
drivers/net/ethernet/broadcom/bnxt/bnxt.c
··· 12369 12369 if (rc) 12370 12370 return rc; 12371 12371 12372 - memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); 12372 + eth_hw_addr_set(dev, addr->sa_data); 12373 12373 if (netif_running(dev)) { 12374 12374 bnxt_close_nic(bp, false, false); 12375 12375 rc = bnxt_open_nic(bp, false, false);
+1 -1
drivers/net/ethernet/broadcom/tg3.c
··· 9366 9366 if (!is_valid_ether_addr(addr->sa_data)) 9367 9367 return -EADDRNOTAVAIL; 9368 9368 9369 - memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); 9369 + eth_hw_addr_set(dev, addr->sa_data); 9370 9370 9371 9371 if (!netif_running(dev)) 9372 9372 return 0;
+1 -1
drivers/net/ethernet/calxeda/xgmac.c
··· 1479 1479 if (!is_valid_ether_addr(addr->sa_data)) 1480 1480 return -EADDRNOTAVAIL; 1481 1481 1482 - memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); 1482 + eth_hw_addr_set(dev, addr->sa_data); 1483 1483 1484 1484 xgmac_set_mac_addr(ioaddr, dev->dev_addr, 0); 1485 1485
+1 -1
drivers/net/ethernet/cavium/liquidio/lio_main.c
··· 2024 2024 return -EIO; 2025 2025 } 2026 2026 2027 - memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); 2027 + eth_hw_addr_set(netdev, addr->sa_data); 2028 2028 memcpy(((u8 *)&lio->linfo.hw_addr) + 2, addr->sa_data, ETH_ALEN); 2029 2029 2030 2030 return 0;
+1 -1
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c
··· 1168 1168 return -EPERM; 1169 1169 } 1170 1170 1171 - memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); 1171 + eth_hw_addr_set(netdev, addr->sa_data); 1172 1172 ether_addr_copy(((u8 *)&lio->linfo.hw_addr) + 2, addr->sa_data); 1173 1173 1174 1174 return 0;
+1 -1
drivers/net/ethernet/cavium/thunder/nicvf_main.c
··· 1611 1611 if (!is_valid_ether_addr(addr->sa_data)) 1612 1612 return -EADDRNOTAVAIL; 1613 1613 1614 - memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); 1614 + eth_hw_addr_set(netdev, addr->sa_data); 1615 1615 1616 1616 if (nic->pdev->msix_enabled) { 1617 1617 if (nicvf_hw_set_mac_addr(nic, netdev))
+1 -1
drivers/net/ethernet/chelsio/cxgb/cxgb2.c
··· 853 853 if (!mac->ops->macaddress_set) 854 854 return -EOPNOTSUPP; 855 855 856 - memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); 856 + eth_hw_addr_set(dev, addr->sa_data); 857 857 mac->ops->macaddress_set(mac, dev->dev_addr); 858 858 return 0; 859 859 }
+1 -1
drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c
··· 2586 2586 if (!is_valid_ether_addr(addr->sa_data)) 2587 2587 return -EADDRNOTAVAIL; 2588 2588 2589 - memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); 2589 + eth_hw_addr_set(dev, addr->sa_data); 2590 2590 t3_mac_set_address(&pi->mac, LAN_MAC_IDX, dev->dev_addr); 2591 2591 if (offload_running(adapter)) 2592 2592 write_smt_entry(adapter, pi->port_id);
+1 -1
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
··· 3468 3468 if (ret < 0) 3469 3469 return ret; 3470 3470 3471 - memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); 3471 + eth_hw_addr_set(dev, addr->sa_data); 3472 3472 return 0; 3473 3473 } 3474 3474
+1 -1
drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
··· 1218 1218 if (ret < 0) 1219 1219 return ret; 1220 1220 1221 - memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); 1221 + eth_hw_addr_set(dev, addr->sa_data); 1222 1222 return 0; 1223 1223 } 1224 1224
+1 -1
drivers/net/ethernet/cirrus/cs89x0.c
··· 1227 1227 if (netif_running(dev)) 1228 1228 return -EBUSY; 1229 1229 1230 - memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); 1230 + eth_hw_addr_set(dev, addr->sa_data); 1231 1231 1232 1232 cs89_dbg(0, debug, "%s: Setting MAC address to %pM\n", 1233 1233 dev->name, dev->dev_addr);
+1 -1
drivers/net/ethernet/cisco/enic/enic_main.c
··· 985 985 return -EADDRNOTAVAIL; 986 986 } 987 987 988 - memcpy(netdev->dev_addr, addr, netdev->addr_len); 988 + eth_hw_addr_set(netdev, addr); 989 989 990 990 return 0; 991 991 }
+1 -1
drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
··· 268 268 269 269 if (is_valid_ether_addr(mac_addr)) { 270 270 memcpy(net_dev->perm_addr, mac_addr, net_dev->addr_len); 271 - memcpy(net_dev->dev_addr, mac_addr, net_dev->addr_len); 271 + eth_hw_addr_set(net_dev, mac_addr); 272 272 } else { 273 273 eth_hw_addr_random(net_dev); 274 274 err = priv->mac_dev->change_addr(priv->mac_dev->fman_mac,
+2 -2
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
··· 4013 4013 return err; 4014 4014 } 4015 4015 } 4016 - memcpy(net_dev->dev_addr, mac_addr, net_dev->addr_len); 4016 + eth_hw_addr_set(net_dev, mac_addr); 4017 4017 } else if (is_zero_ether_addr(dpni_mac_addr)) { 4018 4018 /* No MAC address configured, fill in net_dev->dev_addr 4019 4019 * with a random one ··· 4038 4038 /* NET_ADDR_PERM is default, all we have to do is 4039 4039 * fill in the device addr. 4040 4040 */ 4041 - memcpy(net_dev->dev_addr, dpni_mac_addr, net_dev->addr_len); 4041 + eth_hw_addr_set(net_dev, dpni_mac_addr); 4042 4042 } 4043 4043 4044 4044 return 0;
+1 -1
drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c
··· 980 980 981 981 /* First check if firmware has any address configured by bootloader */ 982 982 if (!is_zero_ether_addr(mac_addr)) { 983 - memcpy(net_dev->dev_addr, mac_addr, net_dev->addr_len); 983 + eth_hw_addr_set(net_dev, mac_addr); 984 984 } else { 985 985 /* No MAC address configured, fill in net_dev->dev_addr 986 986 * with a random one
+1 -1
drivers/net/ethernet/freescale/enetc/enetc_pf.c
··· 40 40 if (!is_valid_ether_addr(saddr->sa_data)) 41 41 return -EADDRNOTAVAIL; 42 42 43 - memcpy(ndev->dev_addr, saddr->sa_data, ndev->addr_len); 43 + eth_hw_addr_set(ndev, saddr->sa_data); 44 44 enetc_pf_set_primary_mac_addr(&priv->si->hw, 0, saddr->sa_data); 45 45 46 46 return 0;
+1 -1
drivers/net/ethernet/freescale/fec_main.c
··· 3326 3326 if (addr) { 3327 3327 if (!is_valid_ether_addr(addr->sa_data)) 3328 3328 return -EADDRNOTAVAIL; 3329 - memcpy(ndev->dev_addr, addr->sa_data, ndev->addr_len); 3329 + eth_hw_addr_set(ndev, addr->sa_data); 3330 3330 } 3331 3331 3332 3332 /* Add netif status check here to avoid system hang in below case:
+1 -1
drivers/net/ethernet/freescale/fec_mpc52xx.c
··· 112 112 { 113 113 struct sockaddr *sock = addr; 114 114 115 - memcpy(dev->dev_addr, sock->sa_data, dev->addr_len); 115 + eth_hw_addr_set(dev, sock->sa_data); 116 116 117 117 mpc52xx_fec_set_paddr(dev, sock->sa_data); 118 118 return 0;
+1 -1
drivers/net/ethernet/freescale/ucc_geth.c
··· 3205 3205 if (!is_valid_ether_addr(addr->sa_data)) 3206 3206 return -EADDRNOTAVAIL; 3207 3207 3208 - memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); 3208 + eth_hw_addr_set(dev, addr->sa_data); 3209 3209 3210 3210 /* 3211 3211 * If device is not running, we will set mac addr register
+1 -1
drivers/net/ethernet/hisilicon/hisi_femac.c
··· 555 555 if (!is_valid_ether_addr(skaddr->sa_data)) 556 556 return -EADDRNOTAVAIL; 557 557 558 - memcpy(dev->dev_addr, skaddr->sa_data, dev->addr_len); 558 + eth_hw_addr_set(dev, skaddr->sa_data); 559 559 dev->addr_assign_type &= ~NET_ADDR_RANDOM; 560 560 561 561 hisi_femac_set_hw_mac_addr(priv, dev->dev_addr);
+1 -1
drivers/net/ethernet/hisilicon/hns/hns_enet.c
··· 1194 1194 return ret; 1195 1195 } 1196 1196 1197 - memcpy(ndev->dev_addr, mac_addr->sa_data, ndev->addr_len); 1197 + eth_hw_addr_set(ndev, mac_addr->sa_data); 1198 1198 1199 1199 return 0; 1200 1200 }
+1 -1
drivers/net/ethernet/ibm/ehea/ehea_main.c
··· 1741 1741 goto out_free; 1742 1742 } 1743 1743 1744 - memcpy(dev->dev_addr, mac_addr->sa_data, dev->addr_len); 1744 + eth_hw_addr_set(dev, mac_addr->sa_data); 1745 1745 1746 1746 /* Deregister old MAC in pHYP */ 1747 1747 if (port->state == EHEA_PORT_UP) {
+1 -1
drivers/net/ethernet/ibm/emac/core.c
··· 1013 1013 1014 1014 mutex_lock(&dev->link_lock); 1015 1015 1016 - memcpy(ndev->dev_addr, addr->sa_data, ndev->addr_len); 1016 + eth_hw_addr_set(ndev, addr->sa_data); 1017 1017 1018 1018 emac_rx_disable(dev); 1019 1019 emac_tx_disable(dev);
+1 -1
drivers/net/ethernet/intel/e100.c
··· 2259 2259 if (!is_valid_ether_addr(addr->sa_data)) 2260 2260 return -EADDRNOTAVAIL; 2261 2261 2262 - memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); 2262 + eth_hw_addr_set(netdev, addr->sa_data); 2263 2263 e100_exec_cb(nic, NULL, e100_setup_iaaddr); 2264 2264 2265 2265 return 0;
+2 -2
drivers/net/ethernet/intel/e1000/e1000_main.c
··· 1103 1103 e_err(probe, "EEPROM Read Error\n"); 1104 1104 } 1105 1105 /* don't block initialization here due to bad MAC address */ 1106 - memcpy(netdev->dev_addr, hw->mac_addr, netdev->addr_len); 1106 + eth_hw_addr_set(netdev, hw->mac_addr); 1107 1107 1108 1108 if (!is_valid_ether_addr(netdev->dev_addr)) 1109 1109 e_err(probe, "Invalid MAC Address\n"); ··· 2209 2209 if (hw->mac_type == e1000_82542_rev2_0) 2210 2210 e1000_enter_82542_rst(adapter); 2211 2211 2212 - memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); 2212 + eth_hw_addr_set(netdev, addr->sa_data); 2213 2213 memcpy(hw->mac_addr, addr->sa_data, netdev->addr_len); 2214 2214 2215 2215 e1000_rar_set(hw, hw->mac_addr, 0);
+2 -2
drivers/net/ethernet/intel/e1000e/netdev.c
··· 4786 4786 if (!is_valid_ether_addr(addr->sa_data)) 4787 4787 return -EADDRNOTAVAIL; 4788 4788 4789 - memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); 4789 + eth_hw_addr_set(netdev, addr->sa_data); 4790 4790 memcpy(adapter->hw.mac.addr, addr->sa_data, netdev->addr_len); 4791 4791 4792 4792 hw->mac.ops.rar_set(&adapter->hw, adapter->hw.mac.addr, 0); ··· 7589 7589 dev_err(&pdev->dev, 7590 7590 "NVM Read Error while reading MAC address\n"); 7591 7591 7592 - memcpy(netdev->dev_addr, adapter->hw.mac.addr, netdev->addr_len); 7592 + eth_hw_addr_set(netdev, adapter->hw.mac.addr); 7593 7593 7594 7594 if (!is_valid_ether_addr(netdev->dev_addr)) { 7595 7595 dev_err(&pdev->dev, "Invalid MAC Address: %pM\n",
+1 -1
drivers/net/ethernet/intel/ice/ice_main.c
··· 5144 5144 netif_addr_lock_bh(netdev); 5145 5145 ether_addr_copy(old_mac, netdev->dev_addr); 5146 5146 /* change the netdev's MAC address */ 5147 - memcpy(netdev->dev_addr, mac, netdev->addr_len); 5147 + eth_hw_addr_set(netdev, mac); 5148 5148 netif_addr_unlock_bh(netdev); 5149 5149 5150 5150 /* Clean up old MAC filter. Not an error if old filter doesn't exist */
+2 -2
drivers/net/ethernet/intel/igb/igb_main.c
··· 3356 3356 dev_err(&pdev->dev, "NVM Read Error\n"); 3357 3357 } 3358 3358 3359 - memcpy(netdev->dev_addr, hw->mac.addr, netdev->addr_len); 3359 + eth_hw_addr_set(netdev, hw->mac.addr); 3360 3360 3361 3361 if (!is_valid_ether_addr(netdev->dev_addr)) { 3362 3362 dev_err(&pdev->dev, "Invalid MAC Address\n"); ··· 4988 4988 if (!is_valid_ether_addr(addr->sa_data)) 4989 4989 return -EADDRNOTAVAIL; 4990 4990 4991 - memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); 4991 + eth_hw_addr_set(netdev, addr->sa_data); 4992 4992 memcpy(hw->mac.addr, addr->sa_data, netdev->addr_len); 4993 4993 4994 4994 /* set the correct pool for the new PF MAC address in entry 0 */
+3 -5
drivers/net/ethernet/intel/igbvf/netdev.c
··· 1527 1527 spin_unlock_bh(&hw->mbx_lock); 1528 1528 1529 1529 if (is_valid_ether_addr(adapter->hw.mac.addr)) { 1530 - memcpy(netdev->dev_addr, adapter->hw.mac.addr, 1531 - netdev->addr_len); 1530 + eth_hw_addr_set(netdev, adapter->hw.mac.addr); 1532 1531 memcpy(netdev->perm_addr, adapter->hw.mac.addr, 1533 1532 netdev->addr_len); 1534 1533 } ··· 1812 1813 if (!ether_addr_equal(addr->sa_data, hw->mac.addr)) 1813 1814 return -EADDRNOTAVAIL; 1814 1815 1815 - memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); 1816 + eth_hw_addr_set(netdev, addr->sa_data); 1816 1817 1817 1818 return 0; 1818 1819 } ··· 2815 2816 else if (is_zero_ether_addr(adapter->hw.mac.addr)) 2816 2817 dev_info(&pdev->dev, 2817 2818 "MAC address not assigned by administrator.\n"); 2818 - memcpy(netdev->dev_addr, adapter->hw.mac.addr, 2819 - netdev->addr_len); 2819 + eth_hw_addr_set(netdev, adapter->hw.mac.addr); 2820 2820 } 2821 2821 2822 2822 spin_unlock_bh(&hw->mbx_lock);
+2 -2
drivers/net/ethernet/intel/igc/igc_main.c
··· 949 949 if (!is_valid_ether_addr(addr->sa_data)) 950 950 return -EADDRNOTAVAIL; 951 951 952 - memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); 952 + eth_hw_addr_set(netdev, addr->sa_data); 953 953 memcpy(hw->mac.addr, addr->sa_data, netdev->addr_len); 954 954 955 955 /* set the correct pool for the new PF MAC address in entry 0 */ ··· 6377 6377 dev_err(&pdev->dev, "NVM Read Error\n"); 6378 6378 } 6379 6379 6380 - memcpy(netdev->dev_addr, hw->mac.addr, netdev->addr_len); 6380 + eth_hw_addr_set(netdev, hw->mac.addr); 6381 6381 6382 6382 if (!is_valid_ether_addr(netdev->dev_addr)) { 6383 6383 dev_err(&pdev->dev, "Invalid MAC Address\n");
+1 -1
drivers/net/ethernet/intel/ixgb/ixgb_main.c
··· 1030 1030 if (!is_valid_ether_addr(addr->sa_data)) 1031 1031 return -EADDRNOTAVAIL; 1032 1032 1033 - memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); 1033 + eth_hw_addr_set(netdev, addr->sa_data); 1034 1034 1035 1035 ixgb_rar_set(&adapter->hw, addr->sa_data, 0); 1036 1036
+2 -2
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
··· 8792 8792 if (!is_valid_ether_addr(addr->sa_data)) 8793 8793 return -EADDRNOTAVAIL; 8794 8794 8795 - memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); 8795 + eth_hw_addr_set(netdev, addr->sa_data); 8796 8796 memcpy(hw->mac.addr, addr->sa_data, netdev->addr_len); 8797 8797 8798 8798 ixgbe_mac_set_default_filter(adapter); ··· 10927 10927 eth_platform_get_mac_address(&adapter->pdev->dev, 10928 10928 adapter->hw.mac.perm_addr); 10929 10929 10930 - memcpy(netdev->dev_addr, hw->mac.perm_addr, netdev->addr_len); 10930 + eth_hw_addr_set(netdev, hw->mac.perm_addr); 10931 10931 10932 10932 if (!is_valid_ether_addr(netdev->dev_addr)) { 10933 10933 e_dev_err("invalid MAC address\n");
+1 -1
drivers/net/ethernet/jme.c
··· 2254 2254 return -EBUSY; 2255 2255 2256 2256 spin_lock_bh(&jme->macaddr_lock); 2257 - memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); 2257 + eth_hw_addr_set(netdev, addr->sa_data); 2258 2258 jme_set_unicastaddr(netdev); 2259 2259 spin_unlock_bh(&jme->macaddr_lock); 2260 2260
+1 -1
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
··· 203 203 return -EADDRNOTAVAIL; 204 204 205 205 if (!otx2_hw_set_mac_addr(pfvf, addr->sa_data)) { 206 - memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); 206 + eth_hw_addr_set(netdev, addr->sa_data); 207 207 /* update dmac field in vlan offload rule */ 208 208 if (netif_running(netdev) && 209 209 pfvf->flags & OTX2_FLAG_RX_VLAN_SUPPORT)
+1 -1
drivers/net/ethernet/mellanox/mlxsw/spectrum.c
··· 674 674 err = mlxsw_sp_port_dev_addr_set(mlxsw_sp_port, addr->sa_data); 675 675 if (err) 676 676 return err; 677 - memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); 677 + eth_hw_addr_set(dev, addr->sa_data); 678 678 return 0; 679 679 } 680 680
+2 -3
drivers/net/ethernet/micrel/ks8842.c
··· 1064 1064 if (!is_valid_ether_addr(addr->sa_data)) 1065 1065 return -EADDRNOTAVAIL; 1066 1066 1067 - memcpy(netdev->dev_addr, mac, netdev->addr_len); 1067 + eth_hw_addr_set(netdev, mac); 1068 1068 1069 1069 ks8842_write_mac_addr(adapter, mac); 1070 1070 return 0; ··· 1191 1191 1192 1192 if (i < netdev->addr_len) 1193 1193 /* an address was passed, use it */ 1194 - memcpy(netdev->dev_addr, pdata->macaddr, 1195 - netdev->addr_len); 1194 + eth_hw_addr_set(netdev, pdata->macaddr); 1196 1195 } 1197 1196 1198 1197 if (i == netdev->addr_len) {
+1 -1
drivers/net/ethernet/microchip/encx24j600.c
··· 761 761 if (!is_valid_ether_addr(address->sa_data)) 762 762 return -EADDRNOTAVAIL; 763 763 764 - memcpy(dev->dev_addr, address->sa_data, dev->addr_len); 764 + eth_hw_addr_set(dev, address->sa_data); 765 765 return encx24j600_set_hw_macaddr(dev); 766 766 } 767 767
+1 -1
drivers/net/ethernet/moxa/moxart_ether.c
··· 65 65 if (!is_valid_ether_addr(address->sa_data)) 66 66 return -EADDRNOTAVAIL; 67 67 68 - memcpy(ndev->dev_addr, address->sa_data, ndev->addr_len); 68 + eth_hw_addr_set(ndev, address->sa_data); 69 69 moxart_update_mac_address(ndev); 70 70 71 71 return 0;
+1 -1
drivers/net/ethernet/neterion/s2io.c
··· 5202 5202 if (!is_valid_ether_addr(addr->sa_data)) 5203 5203 return -EADDRNOTAVAIL; 5204 5204 5205 - memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); 5205 + eth_hw_addr_set(dev, addr->sa_data); 5206 5206 5207 5207 /* store the MAC address in CAM */ 5208 5208 return do_s2io_prog_unicast(dev, dev->dev_addr);
+2 -2
drivers/net/ethernet/neterion/vxge/vxge-main.c
··· 1328 1328 } 1329 1329 1330 1330 if (unlikely(!is_vxge_card_up(vdev))) { 1331 - memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); 1331 + eth_hw_addr_set(dev, addr->sa_data); 1332 1332 return VXGE_HW_OK; 1333 1333 } 1334 1334 ··· 1341 1341 return -EINVAL; 1342 1342 } 1343 1343 1344 - memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); 1344 + eth_hw_addr_set(dev, addr->sa_data); 1345 1345 1346 1346 return status; 1347 1347 }
+2 -2
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
··· 2137 2137 if (!is_valid_ether_addr(skaddr->sa_data)) { 2138 2138 ret_val = -EADDRNOTAVAIL; 2139 2139 } else { 2140 - memcpy(netdev->dev_addr, skaddr->sa_data, netdev->addr_len); 2140 + eth_hw_addr_set(netdev, skaddr->sa_data); 2141 2141 memcpy(adapter->hw.mac.addr, skaddr->sa_data, netdev->addr_len); 2142 2142 pch_gbe_mac_mar_set(&adapter->hw, adapter->hw.mac.addr, 0); 2143 2143 ret_val = 0; ··· 2555 2555 goto err_free_adapter; 2556 2556 } 2557 2557 2558 - memcpy(netdev->dev_addr, adapter->hw.mac.addr, netdev->addr_len); 2558 + eth_hw_addr_set(netdev, adapter->hw.mac.addr); 2559 2559 if (!is_valid_ether_addr(netdev->dev_addr)) { 2560 2560 /* 2561 2561 * If the MAC is invalid (or just missing), display a warning
+1 -1
drivers/net/ethernet/pasemi/pasemi_mac.c
··· 221 221 if (!is_valid_ether_addr(addr->sa_data)) 222 222 return -EADDRNOTAVAIL; 223 223 224 - memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); 224 + eth_hw_addr_set(dev, addr->sa_data); 225 225 226 226 adr0 = dev->dev_addr[2] << 24 | 227 227 dev->dev_addr[3] << 16 |
+1 -1
drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
··· 500 500 } 501 501 502 502 memcpy(adapter->mac_addr, addr->sa_data, netdev->addr_len); 503 - memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); 503 + eth_hw_addr_set(netdev, addr->sa_data); 504 504 adapter->macaddr_set(adapter, addr->sa_data); 505 505 506 506 if (netif_running(netdev)) {
+1 -1
drivers/net/ethernet/qlogic/qla3xxx.c
··· 3564 3564 if (!is_valid_ether_addr(addr->sa_data)) 3565 3565 return -EADDRNOTAVAIL; 3566 3566 3567 - memcpy(ndev->dev_addr, addr->sa_data, ndev->addr_len); 3567 + eth_hw_addr_set(ndev, addr->sa_data); 3568 3568 3569 3569 spin_lock_irqsave(&qdev->hw_lock, hw_flags); 3570 3570 /* Program lower 32 bits of the MAC address */
+1 -1
drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
··· 356 356 357 357 qlcnic_delete_adapter_mac(adapter); 358 358 memcpy(adapter->mac_addr, addr->sa_data, netdev->addr_len); 359 - memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); 359 + eth_hw_addr_set(netdev, addr->sa_data); 360 360 qlcnic_set_multi(adapter->netdev); 361 361 362 362 if (test_bit(__QLCNIC_DEV_UP, &adapter->state)) {
+1 -1
drivers/net/ethernet/realtek/8139cp.c
··· 1624 1624 if (!is_valid_ether_addr(addr->sa_data)) 1625 1625 return -EADDRNOTAVAIL; 1626 1626 1627 - memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); 1627 + eth_hw_addr_set(dev, addr->sa_data); 1628 1628 1629 1629 spin_lock_irq(&cp->lock); 1630 1630
+1 -1
drivers/net/ethernet/realtek/8139too.c
··· 2238 2238 if (!is_valid_ether_addr(addr->sa_data)) 2239 2239 return -EADDRNOTAVAIL; 2240 2240 2241 - memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); 2241 + eth_hw_addr_set(dev, addr->sa_data); 2242 2242 2243 2243 spin_lock_irq(&tp->lock); 2244 2244
+1 -1
drivers/net/ethernet/rocker/rocker_main.c
··· 1954 1954 err = rocker_cmd_set_port_settings_macaddr(rocker_port, addr->sa_data); 1955 1955 if (err) 1956 1956 return err; 1957 - memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); 1957 + eth_hw_addr_set(dev, addr->sa_data); 1958 1958 return 0; 1959 1959 } 1960 1960
+1 -1
drivers/net/ethernet/seeq/sgiseeq.c
··· 167 167 struct sgiseeq_private *sp = netdev_priv(dev); 168 168 struct sockaddr *sa = addr; 169 169 170 - memcpy(dev->dev_addr, sa->sa_data, dev->addr_len); 170 + eth_hw_addr_set(dev, sa->sa_data); 171 171 172 172 spin_lock_irq(&sp->tx_lock); 173 173 __sgiseeq_set_mac_address(dev);
+1 -1
drivers/net/ethernet/sgi/ioc3-eth.c
··· 243 243 struct ioc3_private *ip = netdev_priv(dev); 244 244 struct sockaddr *sa = addr; 245 245 246 - memcpy(dev->dev_addr, sa->sa_data, dev->addr_len); 246 + eth_hw_addr_set(dev, sa->sa_data); 247 247 248 248 spin_lock_irq(&ip->ioc3_lock); 249 249 __ioc3_set_mac_address(dev);
+1 -1
drivers/net/ethernet/sun/niu.c
··· 9235 9235 netdev_err(dev, "%pOF: OF MAC address prop len (%d) is wrong\n", 9236 9236 dp, prop_len); 9237 9237 } 9238 - memcpy(dev->dev_addr, mac_addr, dev->addr_len); 9238 + eth_hw_addr_set(dev, mac_addr); 9239 9239 if (!is_valid_ether_addr(&dev->dev_addr[0])) { 9240 9240 netdev_err(dev, "%pOF: OF MAC address is invalid\n", dp); 9241 9241 netdev_err(dev, "%pOF: [ %pM ]\n", dp, dev->dev_addr);
+1 -1
drivers/net/ethernet/sun/sungem.c
··· 2437 2437 if (!is_valid_ether_addr(macaddr->sa_data)) 2438 2438 return -EADDRNOTAVAIL; 2439 2439 2440 - memcpy(dev->dev_addr, macaddr->sa_data, dev->addr_len); 2440 + eth_hw_addr_set(dev, macaddr->sa_data); 2441 2441 2442 2442 /* We'll just catch it later when the device is up'd or resumed */ 2443 2443 if (!netif_running(dev) || !netif_device_present(dev))
+1 -1
drivers/net/ethernet/synopsys/dwc-xlgmac-common.c
··· 78 78 netdev->irq = pdata->dev_irq; 79 79 netdev->base_addr = (unsigned long)pdata->mac_regs; 80 80 xlgmac_read_mac_addr(pdata); 81 - memcpy(netdev->dev_addr, pdata->mac_addr, netdev->addr_len); 81 + eth_hw_addr_set(netdev, pdata->mac_addr); 82 82 83 83 /* Set all the function pointers */ 84 84 xlgmac_init_all_ops(pdata);
+1 -1
drivers/net/ethernet/synopsys/dwc-xlgmac-net.c
··· 798 798 if (!is_valid_ether_addr(saddr->sa_data)) 799 799 return -EADDRNOTAVAIL; 800 800 801 - memcpy(netdev->dev_addr, saddr->sa_data, netdev->addr_len); 801 + eth_hw_addr_set(netdev, saddr->sa_data); 802 802 803 803 hw_ops->set_mac_address(pdata, netdev->dev_addr); 804 804
+1 -1
drivers/net/ethernet/tehuti/tehuti.c
··· 832 832 if (netif_running(dev)) 833 833 return -EBUSY 834 834 */ 835 - memcpy(ndev->dev_addr, addr->sa_data, ndev->addr_len); 835 + eth_hw_addr_set(ndev, addr->sa_data); 836 836 bdx_restore_mac(ndev, priv); 837 837 RET(0); 838 838 }
+1 -1
drivers/net/ethernet/ti/davinci_emac.c
··· 1132 1132 1133 1133 /* Store mac addr in priv and rx channel and set it in EMAC hw */ 1134 1134 memcpy(priv->mac_addr, sa->sa_data, ndev->addr_len); 1135 - memcpy(ndev->dev_addr, sa->sa_data, ndev->addr_len); 1135 + eth_hw_addr_set(ndev, sa->sa_data); 1136 1136 1137 1137 /* MAC address is configured only after the interface is enabled. */ 1138 1138 if (netif_running(ndev)) {
+1 -1
drivers/net/ethernet/xilinx/xilinx_emaclite.c
··· 511 511 if (netif_running(dev)) 512 512 return -EBUSY; 513 513 514 - memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); 514 + eth_hw_addr_set(dev, addr->sa_data); 515 515 xemaclite_update_address(lp, dev->dev_addr); 516 516 return 0; 517 517 }