Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

macintosh/via-pmu-backlight: Use backlight helper

backlight_properties.fb_blank is deprecated. The states it represents
are handled by other properties; but instead of accessing those
properties directly, drivers should use the helpers provided by
backlight.h.

Instead of retrieving the backlight brightness in struct
backlight_properties manually, and then checking whether the backlight
should be on at all, use backlight_get_brightness() which does all
this and insulates this from future changes.

Signed-off-by: Stephen Kitt <steve@sk2.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220616170425.1346081-1-steve@sk2.org

authored by

Stephen Kitt and committed by
Michael Ellerman
a0542d2c 27f9690a

+1 -6
+1 -6
drivers/macintosh/via-pmu-backlight.c
··· 71 71 static int __pmu_backlight_update_status(struct backlight_device *bd) 72 72 { 73 73 struct adb_request req; 74 - int level = bd->props.brightness; 75 - 76 - 77 - if (bd->props.power != FB_BLANK_UNBLANK || 78 - bd->props.fb_blank != FB_BLANK_UNBLANK) 79 - level = 0; 74 + int level = backlight_get_brightness(bd); 80 75 81 76 if (level > 0) { 82 77 int pmulevel = pmu_backlight_get_level_brightness(level);