Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

hwmon: (gpio-fan) Add missing mutex locks

set_fan_speed() is expected to be called with fan_data->lock being locked.
Add locking for proper synchronization.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Link: https://lore.kernel.org/r/20250210145934.761280-3-alexander.stein@ew.tq-group.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

authored by

Alexander Stein and committed by
Guenter Roeck
9fee7d19 9f8e2e49

+15 -1
+15 -1
drivers/hwmon/gpio-fan.c
··· 393 393 if (state >= fan_data->num_speed) 394 394 return -EINVAL; 395 395 396 + mutex_lock(&fan_data->lock); 397 + 396 398 set_fan_speed(fan_data, state); 399 + 400 + mutex_unlock(&fan_data->lock); 401 + 397 402 return 0; 398 403 } 399 404 ··· 494 489 495 490 static void gpio_fan_stop(void *data) 496 491 { 492 + struct gpio_fan_data *fan_data = data; 493 + 494 + mutex_lock(&fan_data->lock); 497 495 set_fan_speed(data, 0); 496 + mutex_unlock(&fan_data->lock); 498 497 } 499 498 500 499 static int gpio_fan_probe(struct platform_device *pdev) ··· 571 562 572 563 if (fan_data->gpios) { 573 564 fan_data->resume_speed = fan_data->speed_index; 565 + mutex_lock(&fan_data->lock); 574 566 set_fan_speed(fan_data, 0); 567 + mutex_unlock(&fan_data->lock); 575 568 } 576 569 577 570 return 0; ··· 583 572 { 584 573 struct gpio_fan_data *fan_data = dev_get_drvdata(dev); 585 574 586 - if (fan_data->gpios) 575 + if (fan_data->gpios) { 576 + mutex_lock(&fan_data->lock); 587 577 set_fan_speed(fan_data, fan_data->resume_speed); 578 + mutex_unlock(&fan_data->lock); 579 + } 588 580 589 581 return 0; 590 582 }