Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/i915: Simplify vlv_wait_port_ready() arguments

Currently vlv_wait_port_ready() takes the display+dig_port,
but all it really needs is the encoder. The display can be
dug out from therein.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250213150220.13580-9-ville.syrjala@linux.intel.com
Reviewed-by: Jani Nikula <jani.nikula@intel.com>

+10 -14
+1 -1
drivers/gpu/drm/i915/display/g4x_dp.c
··· 701 701 if (display->platform.cherryview) 702 702 lane_mask = intel_dp_unused_lane_mask(pipe_config->lane_count); 703 703 704 - vlv_wait_port_ready(display, dp_to_dig_port(intel_dp), lane_mask); 704 + vlv_wait_port_ready(encoder, lane_mask); 705 705 } 706 706 707 707 intel_dp_set_power(intel_dp, DP_SET_POWER_D0);
+2 -4
drivers/gpu/drm/i915/display/g4x_hdmi.c
··· 479 479 const struct intel_crtc_state *pipe_config, 480 480 const struct drm_connector_state *conn_state) 481 481 { 482 - struct intel_display *display = to_intel_display(encoder); 483 482 struct intel_digital_port *dig_port = enc_to_dig_port(encoder); 484 483 485 484 vlv_phy_pre_encoder_enable(encoder, pipe_config); ··· 494 495 495 496 g4x_hdmi_enable_port(encoder, pipe_config); 496 497 497 - vlv_wait_port_ready(display, dig_port, 0x0); 498 + vlv_wait_port_ready(encoder, 0x0); 498 499 } 499 500 500 501 static void vlv_hdmi_pre_pll_enable(struct intel_atomic_state *state, ··· 555 556 const struct intel_crtc_state *pipe_config, 556 557 const struct drm_connector_state *conn_state) 557 558 { 558 - struct intel_display *display = to_intel_display(encoder); 559 559 struct intel_digital_port *dig_port = enc_to_dig_port(encoder); 560 560 561 561 chv_phy_pre_encoder_enable(encoder, pipe_config); ··· 569 571 570 572 g4x_hdmi_enable_port(encoder, pipe_config); 571 573 572 - vlv_wait_port_ready(display, dig_port, 0x0); 574 + vlv_wait_port_ready(encoder, 0x0); 573 575 574 576 /* Second common lane will stay alive on its own now */ 575 577 chv_phy_release_cl2_override(encoder);
+5 -5
drivers/gpu/drm/i915/display/intel_dpio_phy.c
··· 1157 1157 vlv_dpio_put(dev_priv); 1158 1158 } 1159 1159 1160 - void vlv_wait_port_ready(struct intel_display *display, 1161 - struct intel_digital_port *dig_port, 1160 + void vlv_wait_port_ready(struct intel_encoder *encoder, 1162 1161 unsigned int expected_mask) 1163 1162 { 1163 + struct intel_display *display = to_intel_display(encoder); 1164 1164 u32 port_mask; 1165 1165 i915_reg_t dpll_reg; 1166 1166 1167 - switch (dig_port->base.port) { 1167 + switch (encoder->port) { 1168 1168 default: 1169 - MISSING_CASE(dig_port->base.port); 1169 + MISSING_CASE(encoder->port); 1170 1170 fallthrough; 1171 1171 case PORT_B: 1172 1172 port_mask = DPLL_PORTB_READY_MASK; ··· 1186 1186 if (intel_de_wait(display, dpll_reg, port_mask, expected_mask, 1000)) 1187 1187 drm_WARN(display->drm, 1, 1188 1188 "timed out waiting for [ENCODER:%d:%s] port ready: got 0x%x, expected 0x%x\n", 1189 - dig_port->base.base.base.id, dig_port->base.base.name, 1189 + encoder->base.base.id, encoder->base.name, 1190 1190 intel_de_read(display, dpll_reg) & port_mask, 1191 1191 expected_mask); 1192 1192 }
+2 -4
drivers/gpu/drm/i915/display/intel_dpio_phy.h
··· 72 72 const struct intel_crtc_state *crtc_state); 73 73 void vlv_phy_reset_lanes(struct intel_encoder *encoder, 74 74 const struct intel_crtc_state *old_crtc_state); 75 - void vlv_wait_port_ready(struct intel_display *display, 76 - struct intel_digital_port *dig_port, 75 + void vlv_wait_port_ready(struct intel_encoder *encoder, 77 76 unsigned int expected_mask); 78 77 #else 79 78 static inline void bxt_port_to_phy_channel(struct intel_display *display, enum port port, ··· 172 173 const struct intel_crtc_state *old_crtc_state) 173 174 { 174 175 } 175 - static inline void vlv_wait_port_ready(struct intel_display *display, 176 - struct intel_digital_port *dig_port, 176 + static inline void vlv_wait_port_ready(struct intel_encoder *encoder, 177 177 unsigned int expected_mask) 178 178 { 179 179 }