Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

dmaengine: coh901318: fix integer overflow when shifting more than 32 places

Currently U300_DMA_CHANNELS is set to 40, meaning that the shift of 1 can
be more than 32 places, which leads to a 32 bit integer overflow. Fix this
by using 1ULL instead of 1 before shifting it. Also add braces on the
for-loop to keep with coding style conventions.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>

authored by

Colin Ian King and committed by
Vinod Koul
9f0df936 2cc40ee7

+3 -2
+3 -2
drivers/dma/coh901318.c
··· 1352 1352 1353 1353 tmp += sprintf(tmp, "DMA -- enabled dma channels\n"); 1354 1354 1355 - for (i = 0; i < U300_DMA_CHANNELS; i++) 1356 - if (started_channels & (1 << i)) 1355 + for (i = 0; i < U300_DMA_CHANNELS; i++) { 1356 + if (started_channels & (1ULL << i)) 1357 1357 tmp += sprintf(tmp, "channel %d\n", i); 1358 + } 1358 1359 1359 1360 tmp += sprintf(tmp, "Pool alloc nbr %d\n", pool_count); 1360 1361