Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mailbox: mediatek: Add check for possible failure of kzalloc

The patch 623a6143a845("mailbox: mediatek: Add Mediatek CMDQ driver")
introduce the following static checker warning:
drivers/mailbox/mtk-cmdq-mailbox.c:366 cmdq_mbox_send_data()
error: potential null dereference 'task'. (kzalloc returns null)

Fixes: 623a6143a845 ("mailbox: mediatek: Add Mediatek CMDQ driver")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Houlong Wei <houlong.wei@mediatek.com>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>

authored by

Houlong Wei and committed by
Jassi Brar
9f0a0a38 462f668e

+3
+3
drivers/mailbox/mtk-cmdq-mailbox.c
··· 363 363 WARN_ON(cmdq->suspended); 364 364 365 365 task = kzalloc(sizeof(*task), GFP_ATOMIC); 366 + if (!task) 367 + return -ENOMEM; 368 + 366 369 task->cmdq = cmdq; 367 370 INIT_LIST_HEAD(&task->list_entry); 368 371 task->pa_base = pkt->pa_base;