Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

watchdog: mei_wdt: request stop on reboot to prevent false positive event

Systemd on reboot enables shutdown watchdog that leaves the watchdog
device open to ensure that even if power down process get stuck the
platform reboots nonetheless.
The iamt_wdt is an alarm-only watchdog and can't reboot system, but the
FW will generate an alarm event reboot was completed in time, as the
watchdog is not automatically disabled during power cycle.
So we should request stop watchdog on reboot to eliminate wrong alarm
from the FW.

Cc: <stable@vger.kernel.org>
Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

authored by

Alexander Usyskin and committed by
Guenter Roeck
9eff1140 4cfccbda

+2
+2
drivers/watchdog/mei_wdt.c
··· 389 389 wdt->wdd.max_timeout = MEI_WDT_MAX_TIMEOUT; 390 390 391 391 watchdog_set_drvdata(&wdt->wdd, wdt); 392 + watchdog_stop_on_reboot(&wdt->wdd); 393 + 392 394 ret = watchdog_register_device(&wdt->wdd); 393 395 if (ret) { 394 396 dev_err(dev, "unable to register watchdog device = %d.\n", ret);