Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

PCI: Remove pci_scan_root_bus_msi()

The pci_scan_root_bus_bridge() function allows passing a parameterized
struct pci_host_bridge and scanning the resulting PCI bus; since the struct
msi_controller is part of the struct pci_host_bridge and the struct
pci_host_bridge can now be passed to pci_scan_root_bus_bridge() explicitly,
there is no need for a scan interface with a MSI controller parameter.

With all PCI host controller drivers and platform code relying on
pci_scan_root_bus_msi() converted over to pci_scan_root_bus_bridge() the
pci_scan_root_bus_msi() becomes obsolete and can be removed.

Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

authored by

Lorenzo Pieralisi and committed by
Bjorn Helgaas
9ee8a1c4 123db533

+5 -26
+5 -22
drivers/pci/probe.c
··· 2324 2324 { 2325 2325 } 2326 2326 2327 - static struct pci_bus *pci_create_root_bus_msi(struct device *parent, 2328 - int bus, struct pci_ops *ops, void *sysdata, 2329 - struct list_head *resources, struct msi_controller *msi) 2327 + struct pci_bus *pci_create_root_bus(struct device *parent, int bus, 2328 + struct pci_ops *ops, void *sysdata, struct list_head *resources) 2330 2329 { 2331 2330 int error; 2332 2331 struct pci_host_bridge *bridge; ··· 2340 2341 bridge->sysdata = sysdata; 2341 2342 bridge->busnr = bus; 2342 2343 bridge->ops = ops; 2343 - bridge->msi = msi; 2344 2344 2345 2345 error = pci_register_host_bridge(bridge); 2346 2346 if (error < 0) ··· 2350 2352 err_out: 2351 2353 kfree(bridge); 2352 2354 return NULL; 2353 - } 2354 - 2355 - struct pci_bus *pci_create_root_bus(struct device *parent, int bus, 2356 - struct pci_ops *ops, void *sysdata, struct list_head *resources) 2357 - { 2358 - return pci_create_root_bus_msi(parent, bus, ops, sysdata, resources, 2359 - NULL); 2360 2355 } 2361 2356 EXPORT_SYMBOL_GPL(pci_create_root_bus); 2362 2357 ··· 2455 2464 } 2456 2465 EXPORT_SYMBOL(pci_scan_root_bus_bridge); 2457 2466 2458 - struct pci_bus *pci_scan_root_bus_msi(struct device *parent, int bus, 2459 - struct pci_ops *ops, void *sysdata, 2460 - struct list_head *resources, struct msi_controller *msi) 2467 + struct pci_bus *pci_scan_root_bus(struct device *parent, int bus, 2468 + struct pci_ops *ops, void *sysdata, struct list_head *resources) 2461 2469 { 2462 2470 struct resource_entry *window; 2463 2471 bool found = false; ··· 2469 2479 break; 2470 2480 } 2471 2481 2472 - b = pci_create_root_bus_msi(parent, bus, ops, sysdata, resources, msi); 2482 + b = pci_create_root_bus(parent, bus, ops, sysdata, resources); 2473 2483 if (!b) 2474 2484 return NULL; 2475 2485 ··· 2486 2496 pci_bus_update_busn_res_end(b, max); 2487 2497 2488 2498 return b; 2489 - } 2490 - 2491 - struct pci_bus *pci_scan_root_bus(struct device *parent, int bus, 2492 - struct pci_ops *ops, void *sysdata, struct list_head *resources) 2493 - { 2494 - return pci_scan_root_bus_msi(parent, bus, ops, sysdata, resources, 2495 - NULL); 2496 2499 } 2497 2500 EXPORT_SYMBOL(pci_scan_root_bus); 2498 2501
-4
include/linux/pci.h
··· 849 849 int pci_bus_insert_busn_res(struct pci_bus *b, int bus, int busmax); 850 850 int pci_bus_update_busn_res_end(struct pci_bus *b, int busmax); 851 851 void pci_bus_release_busn_res(struct pci_bus *b); 852 - struct pci_bus *pci_scan_root_bus_msi(struct device *parent, int bus, 853 - struct pci_ops *ops, void *sysdata, 854 - struct list_head *resources, 855 - struct msi_controller *msi); 856 852 struct pci_bus *pci_scan_root_bus(struct device *parent, int bus, 857 853 struct pci_ops *ops, void *sysdata, 858 854 struct list_head *resources);