Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

staging: gpib: Fix inadvertent negative shift

During the initial checkpatch cleanup, when removing blanks
after open parentheses, a minus sign in the argument of a shift
operation was deleted by mistake. This transformed a pre-decrement
operation into a negation.

The result of a negative shift is undefined and a warning was
signalled by sparse.

Restore the pre-decrement operation.

Fixes: 6c52d5e3cde2 ("staging: gpib: Add common include files for GPIB drivers")
Signed-off-by: Dave Penkler <dpenkler@gmail.com>
Link: https://lore.kernel.org/r/20250116110014.15577-1-dpenkler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Dave Penkler and committed by
Greg Kroah-Hartman
9ed145e6 d3fbbfa9

+1 -1
+1 -1
drivers/staging/gpib/include/amcc5920.h
··· 22 22 23 23 static inline uint32_t amcc_wait_state_bits(unsigned int region, unsigned int num_wait_states) 24 24 { 25 - return (num_wait_states & 0x7) << (-region * bits_per_region); 25 + return (num_wait_states & 0x7) << (--region * bits_per_region); 26 26 }; 27 27 28 28 enum amcc_prefetch_bits {