Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Merge branch '10GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue

Nguyen, Anthony L says:

====================
10GbE Intel Wired LAN Driver Updates 2022-02-23

Yang Li fixes incorrect indenting as reported by smatch for ixgbevf.

Piotr removes non-inclusive language from ixgbe driver.

* '10GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue:
ixgbe: Remove non-inclusive language
ixgbevf: clean up some inconsistent indenting
====================

Link: https://lore.kernel.org/r/20220223185424.2129067-1-anthony.l.nguyen@intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

+26 -26
+18 -18
drivers/net/ethernet/intel/ixgbe/ixgbe_common.c
··· 30 30 u16 words, u16 *data); 31 31 static s32 ixgbe_detect_eeprom_page_size_generic(struct ixgbe_hw *hw, 32 32 u16 offset); 33 - static s32 ixgbe_disable_pcie_master(struct ixgbe_hw *hw); 33 + static s32 ixgbe_disable_pcie_primary(struct ixgbe_hw *hw); 34 34 35 35 /* Base table for registers values that change by MAC */ 36 36 const u32 ixgbe_mvals_8259X[IXGBE_MVALS_IDX_LIMIT] = { ··· 746 746 usleep_range(1000, 2000); 747 747 748 748 /* 749 - * Prevent the PCI-E bus from from hanging by disabling PCI-E master 749 + * Prevent the PCI-E bus from hanging by disabling PCI-E primary 750 750 * access and verify no pending requests 751 751 */ 752 - return ixgbe_disable_pcie_master(hw); 752 + return ixgbe_disable_pcie_primary(hw); 753 753 } 754 754 755 755 /** ··· 2506 2506 } 2507 2507 2508 2508 /** 2509 - * ixgbe_disable_pcie_master - Disable PCI-express master access 2509 + * ixgbe_disable_pcie_primary - Disable PCI-express primary access 2510 2510 * @hw: pointer to hardware structure 2511 2511 * 2512 - * Disables PCI-Express master access and verifies there are no pending 2513 - * requests. IXGBE_ERR_MASTER_REQUESTS_PENDING is returned if master disable 2514 - * bit hasn't caused the master requests to be disabled, else 0 2515 - * is returned signifying master requests disabled. 2512 + * Disables PCI-Express primary access and verifies there are no pending 2513 + * requests. IXGBE_ERR_PRIMARY_REQUESTS_PENDING is returned if primary disable 2514 + * bit hasn't caused the primary requests to be disabled, else 0 2515 + * is returned signifying primary requests disabled. 2516 2516 **/ 2517 - static s32 ixgbe_disable_pcie_master(struct ixgbe_hw *hw) 2517 + static s32 ixgbe_disable_pcie_primary(struct ixgbe_hw *hw) 2518 2518 { 2519 2519 u32 i, poll; 2520 2520 u16 value; ··· 2523 2523 IXGBE_WRITE_REG(hw, IXGBE_CTRL, IXGBE_CTRL_GIO_DIS); 2524 2524 2525 2525 /* Poll for bit to read as set */ 2526 - for (i = 0; i < IXGBE_PCI_MASTER_DISABLE_TIMEOUT; i++) { 2526 + for (i = 0; i < IXGBE_PCI_PRIMARY_DISABLE_TIMEOUT; i++) { 2527 2527 if (IXGBE_READ_REG(hw, IXGBE_CTRL) & IXGBE_CTRL_GIO_DIS) 2528 2528 break; 2529 2529 usleep_range(100, 120); 2530 2530 } 2531 - if (i >= IXGBE_PCI_MASTER_DISABLE_TIMEOUT) { 2531 + if (i >= IXGBE_PCI_PRIMARY_DISABLE_TIMEOUT) { 2532 2532 hw_dbg(hw, "GIO disable did not set - requesting resets\n"); 2533 2533 goto gio_disable_fail; 2534 2534 } 2535 2535 2536 - /* Exit if master requests are blocked */ 2536 + /* Exit if primary requests are blocked */ 2537 2537 if (!(IXGBE_READ_REG(hw, IXGBE_STATUS) & IXGBE_STATUS_GIO) || 2538 2538 ixgbe_removed(hw->hw_addr)) 2539 2539 return 0; 2540 2540 2541 - /* Poll for master request bit to clear */ 2542 - for (i = 0; i < IXGBE_PCI_MASTER_DISABLE_TIMEOUT; i++) { 2541 + /* Poll for primary request bit to clear */ 2542 + for (i = 0; i < IXGBE_PCI_PRIMARY_DISABLE_TIMEOUT; i++) { 2543 2543 udelay(100); 2544 2544 if (!(IXGBE_READ_REG(hw, IXGBE_STATUS) & IXGBE_STATUS_GIO)) 2545 2545 return 0; ··· 2547 2547 2548 2548 /* 2549 2549 * Two consecutive resets are required via CTRL.RST per datasheet 2550 - * 5.2.5.3.2 Master Disable. We set a flag to inform the reset routine 2551 - * of this need. The first reset prevents new master requests from 2550 + * 5.2.5.3.2 Primary Disable. We set a flag to inform the reset routine 2551 + * of this need. The first reset prevents new primary requests from 2552 2552 * being issued by our device. We then must wait 1usec or more for any 2553 2553 * remaining completions from the PCIe bus to trickle in, and then reset 2554 2554 * again to clear out any effects they may have had on our device. 2555 2555 */ 2556 - hw_dbg(hw, "GIO Master Disable bit didn't clear - requesting resets\n"); 2556 + hw_dbg(hw, "GIO Primary Disable bit didn't clear - requesting resets\n"); 2557 2557 gio_disable_fail: 2558 2558 hw->mac.flags |= IXGBE_FLAGS_DOUBLE_RESET_REQUIRED; 2559 2559 ··· 2575 2575 } 2576 2576 2577 2577 hw_dbg(hw, "PCIe transaction pending bit also did not clear.\n"); 2578 - return IXGBE_ERR_MASTER_REQUESTS_PENDING; 2578 + return IXGBE_ERR_PRIMARY_REQUESTS_PENDING; 2579 2579 } 2580 2580 2581 2581 /**
+2 -2
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
··· 5948 5948 case IXGBE_ERR_SFP_NOT_PRESENT: 5949 5949 case IXGBE_ERR_SFP_NOT_SUPPORTED: 5950 5950 break; 5951 - case IXGBE_ERR_MASTER_REQUESTS_PENDING: 5952 - e_dev_err("master disable timed out\n"); 5951 + case IXGBE_ERR_PRIMARY_REQUESTS_PENDING: 5952 + e_dev_err("primary disable timed out\n"); 5953 5953 break; 5954 5954 case IXGBE_ERR_EEPROM_VERSION: 5955 5955 /* We are running on a pre-production device, log a warning */
+5 -5
drivers/net/ethernet/intel/ixgbe/ixgbe_type.h
··· 1247 1247 #define IXGBE_PSRTYPE_RQPL_SHIFT 29 1248 1248 1249 1249 /* CTRL Bit Masks */ 1250 - #define IXGBE_CTRL_GIO_DIS 0x00000004 /* Global IO Master Disable bit */ 1250 + #define IXGBE_CTRL_GIO_DIS 0x00000004 /* Global IO Primary Disable bit */ 1251 1251 #define IXGBE_CTRL_LNK_RST 0x00000008 /* Link Reset. Resets everything. */ 1252 1252 #define IXGBE_CTRL_RST 0x04000000 /* Reset (SW) */ 1253 1253 #define IXGBE_CTRL_RST_MASK (IXGBE_CTRL_LNK_RST | IXGBE_CTRL_RST) ··· 1811 1811 /* STATUS Bit Masks */ 1812 1812 #define IXGBE_STATUS_LAN_ID 0x0000000C /* LAN ID */ 1813 1813 #define IXGBE_STATUS_LAN_ID_SHIFT 2 /* LAN ID Shift*/ 1814 - #define IXGBE_STATUS_GIO 0x00080000 /* GIO Master Enable Status */ 1814 + #define IXGBE_STATUS_GIO 0x00080000 /* GIO Primary Enable Status */ 1815 1815 1816 1816 #define IXGBE_STATUS_LAN_ID_0 0x00000000 /* LAN ID 0 */ 1817 1817 #define IXGBE_STATUS_LAN_ID_1 0x00000004 /* LAN ID 1 */ ··· 2193 2193 #define IXGBE_PCIDEVCTRL2_4_8s 0xd 2194 2194 #define IXGBE_PCIDEVCTRL2_17_34s 0xe 2195 2195 2196 - /* Number of 100 microseconds we wait for PCI Express master disable */ 2197 - #define IXGBE_PCI_MASTER_DISABLE_TIMEOUT 800 2196 + /* Number of 100 microseconds we wait for PCI Express primary disable */ 2197 + #define IXGBE_PCI_PRIMARY_DISABLE_TIMEOUT 800 2198 2198 2199 2199 /* RAH */ 2200 2200 #define IXGBE_RAH_VIND_MASK 0x003C0000 ··· 3671 3671 #define IXGBE_ERR_ADAPTER_STOPPED -9 3672 3672 #define IXGBE_ERR_INVALID_MAC_ADDR -10 3673 3673 #define IXGBE_ERR_DEVICE_NOT_SUPPORTED -11 3674 - #define IXGBE_ERR_MASTER_REQUESTS_PENDING -12 3674 + #define IXGBE_ERR_PRIMARY_REQUESTS_PENDING -12 3675 3675 #define IXGBE_ERR_INVALID_LINK_SETTINGS -13 3676 3676 #define IXGBE_ERR_AUTONEG_NOT_COMPLETE -14 3677 3677 #define IXGBE_ERR_RESET_FAILED -15
+1 -1
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
··· 2753 2753 ring->reg_idx = reg_idx; 2754 2754 2755 2755 /* assign ring to adapter */ 2756 - adapter->tx_ring[txr_idx] = ring; 2756 + adapter->tx_ring[txr_idx] = ring; 2757 2757 2758 2758 /* update count and index */ 2759 2759 txr_count--;