Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

PM / devfreq: tegra: fix error return code in tegra_devfreq_probe()

platform_get_irq() returns an error code, but the tegra-devfreq
driver ignores it and always returns -ENODEV. This is not correct,
and prevents -EPROBE_DEFER from being propagated properly.

Notice that platform_get_irq() no longer returns 0 on error:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af

Print and propagate the return value of platform_get_irq on failure.

Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>

authored by

Gustavo A. R. Silva and committed by
MyungJoo Ham
9e578b37 da55b1ad

+3 -3
+3 -3
drivers/devfreq/tegra-devfreq.c
··· 688 688 } 689 689 690 690 irq = platform_get_irq(pdev, 0); 691 - if (irq <= 0) { 692 - dev_err(&pdev->dev, "Failed to get IRQ\n"); 693 - return -ENODEV; 691 + if (irq < 0) { 692 + dev_err(&pdev->dev, "Failed to get IRQ: %d\n", irq); 693 + return irq; 694 694 } 695 695 696 696 platform_set_drvdata(pdev, tegra);