Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

KVM: selftests: Use "gpa" and "gva" for local variable names in pre-fault test

Rename guest_test_{phys,virt}_mem to g{p,v}a in the pre-fault memory test
to shorten line lengths and to use standard terminology.

Opportunsitically use "base_gva" in the guest code instead of "base_gpa"
to match the host side code, which now passes in "gva" (and because
referencing the virtual address avoids having to know that the data is
identity mapped).

No functional change intended.

Cc: Yan Zhao <yan.y.zhao@intel.com>
Link: https://lore.kernel.org/r/20251007224515.374516-1-seanjc@google.com
Signed-off-by: Sean Christopherson <seanjc@google.com>

+14 -18
+14 -18
tools/testing/selftests/kvm/pre_fault_memory_test.c
··· 17 17 #define TEST_NPAGES (TEST_SIZE / PAGE_SIZE) 18 18 #define TEST_SLOT 10 19 19 20 - static void guest_code(uint64_t base_gpa) 20 + static void guest_code(uint64_t base_gva) 21 21 { 22 22 volatile uint64_t val __used; 23 23 int i; 24 24 25 25 for (i = 0; i < TEST_NPAGES; i++) { 26 - uint64_t *src = (uint64_t *)(base_gpa + i * PAGE_SIZE); 26 + uint64_t *src = (uint64_t *)(base_gva + i * PAGE_SIZE); 27 27 28 28 val = *src; 29 29 } ··· 161 161 162 162 static void __test_pre_fault_memory(unsigned long vm_type, bool private) 163 163 { 164 + uint64_t gpa, gva, alignment, guest_page_size; 164 165 const struct vm_shape shape = { 165 166 .mode = VM_MODE_DEFAULT, 166 167 .type = vm_type, ··· 171 170 struct kvm_vm *vm; 172 171 struct ucall uc; 173 172 174 - uint64_t guest_test_phys_mem; 175 - uint64_t guest_test_virt_mem; 176 - uint64_t alignment, guest_page_size; 177 - 178 173 vm = vm_create_shape_with_one_vcpu(shape, &vcpu, guest_code); 179 174 180 175 alignment = guest_page_size = vm_guest_mode_params[VM_MODE_DEFAULT].page_size; 181 - guest_test_phys_mem = (vm->max_gfn - TEST_NPAGES) * guest_page_size; 176 + gpa = (vm->max_gfn - TEST_NPAGES) * guest_page_size; 182 177 #ifdef __s390x__ 183 178 alignment = max(0x100000UL, guest_page_size); 184 179 #else 185 180 alignment = SZ_2M; 186 181 #endif 187 - guest_test_phys_mem = align_down(guest_test_phys_mem, alignment); 188 - guest_test_virt_mem = guest_test_phys_mem & ((1ULL << (vm->va_bits - 1)) - 1); 182 + gpa = align_down(gpa, alignment); 183 + gva = gpa & ((1ULL << (vm->va_bits - 1)) - 1); 189 184 190 - vm_userspace_mem_region_add(vm, VM_MEM_SRC_ANONYMOUS, 191 - guest_test_phys_mem, TEST_SLOT, TEST_NPAGES, 192 - private ? KVM_MEM_GUEST_MEMFD : 0); 193 - virt_map(vm, guest_test_virt_mem, guest_test_phys_mem, TEST_NPAGES); 185 + vm_userspace_mem_region_add(vm, VM_MEM_SRC_ANONYMOUS, gpa, TEST_SLOT, 186 + TEST_NPAGES, private ? KVM_MEM_GUEST_MEMFD : 0); 187 + virt_map(vm, gva, gpa, TEST_NPAGES); 194 188 195 189 if (private) 196 - vm_mem_set_private(vm, guest_test_phys_mem, TEST_SIZE); 190 + vm_mem_set_private(vm, gpa, TEST_SIZE); 197 191 198 - pre_fault_memory(vcpu, guest_test_phys_mem, 0, SZ_2M, 0, private); 199 - pre_fault_memory(vcpu, guest_test_phys_mem, SZ_2M, PAGE_SIZE * 2, PAGE_SIZE, private); 200 - pre_fault_memory(vcpu, guest_test_phys_mem, TEST_SIZE, PAGE_SIZE, PAGE_SIZE, private); 192 + pre_fault_memory(vcpu, gpa, 0, SZ_2M, 0, private); 193 + pre_fault_memory(vcpu, gpa, SZ_2M, PAGE_SIZE * 2, PAGE_SIZE, private); 194 + pre_fault_memory(vcpu, gpa, TEST_SIZE, PAGE_SIZE, PAGE_SIZE, private); 201 195 202 - vcpu_args_set(vcpu, 1, guest_test_virt_mem); 196 + vcpu_args_set(vcpu, 1, gva); 203 197 vcpu_run(vcpu); 204 198 205 199 run = vcpu->run;