Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Revert ncsi: Propagate carrier gain/loss events to the NCSI controller

This reverts commit 3780bb29311eccb7a1c9641032a112eed237f7e3.

The cited commit introduced unwanted behavior.

The intent for the commit was to be able to detect carrier loss/gain
for just the NIC connected to the BMC. The unwanted effect is a
carrier loss for auxiliary paths also causes the BMC to lose
carrier. The BMC never regains carrier despite the secondary NIC
regaining a link.

This change, when merged, needs to be backported to stable kernels.
5.4-stable, 5.10-stable, 5.15-stable, 6.1-stable, 6.5-stable

Fixes: 3780bb29311e ("ncsi: Propagate carrier gain/loss events to the NCSI controller")
CC: stable@vger.kernel.org
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Johnathan Mantey and committed by
David S. Miller
9e2e7efb a133eae8

-5
-5
net/ncsi/ncsi-aen.c
··· 89 89 if ((had_link == has_link) || chained) 90 90 return 0; 91 91 92 - if (had_link) 93 - netif_carrier_off(ndp->ndev.dev); 94 - else 95 - netif_carrier_on(ndp->ndev.dev); 96 - 97 92 if (!ndp->multi_package && !nc->package->multi_channel) { 98 93 if (had_link) { 99 94 ndp->flags |= NCSI_DEV_RESHUFFLE;