Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

irqchip/mmp: Declare init functions in common header file

The functions icu_init_irq and mmp2_init_icu are exported
from this code, so declare them in the header file to avoid
the following sparse warnings:

drivers/irqchip/irq-mmp.c:248:13: warning: symbol 'icu_init_irq' was not declared. Should it be static?
drivers/irqchip/irq-mmp.c:271:13: warning: symbol 'mmp2_init_icu' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben-linux@fluff.org>
[maz: fixup commit message]
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220724222152.551850-1-ben-linux@fluff.org

authored by

Ben Dooks and committed by
Marc Zyngier
9d9b010f 71349cc8

+6 -3
+1 -1
arch/arm/mach-mmp/mmp2.h
··· 5 5 #include <linux/platform_data/pxa_sdhci.h> 6 6 7 7 extern void mmp2_timer_init(void); 8 - extern void __init mmp2_init_icu(void); 9 8 extern void __init mmp2_init_irq(void); 10 9 extern void mmp2_clear_pmic_int(void); 11 10 12 11 #include <linux/i2c.h> 13 12 #include <linux/platform_data/i2c-pxa.h> 14 13 #include <linux/platform_data/dma-mmp_tdma.h> 14 + #include <linux/irqchip/mmp.h> 15 15 16 16 #include "devices.h" 17 17
+1 -1
arch/arm/mach-mmp/pxa168.h
··· 5 5 #include <linux/reboot.h> 6 6 7 7 extern void pxa168_timer_init(void); 8 - extern void __init icu_init_irq(void); 9 8 extern void __init pxa168_init_irq(void); 10 9 extern void pxa168_restart(enum reboot_mode, const char *); 11 10 extern void pxa168_clear_keypad_wakeup(void); ··· 17 18 #include <linux/pxa168_eth.h> 18 19 #include <linux/platform_data/mv_usb.h> 19 20 #include <linux/soc/mmp/cputype.h> 21 + #include <linux/irqchip/mmp.h> 20 22 21 23 #include "devices.h" 22 24
+1 -1
arch/arm/mach-mmp/pxa910.h
··· 3 3 #define __ASM_MACH_PXA910_H 4 4 5 5 extern void pxa910_timer_init(void); 6 - extern void __init icu_init_irq(void); 7 6 extern void __init pxa910_init_irq(void); 8 7 9 8 #include <linux/i2c.h> 10 9 #include <linux/platform_data/i2c-pxa.h> 11 10 #include <linux/platform_data/mtd-nand-pxa3xx.h> 12 11 #include <video/mmp_disp.h> 12 + #include <linux/irqchip/mmp.h> 13 13 14 14 #include "devices.h" 15 15
+3
include/linux/irqchip/mmp.h
··· 4 4 5 5 extern struct irq_chip icu_irq_chip; 6 6 7 + extern void icu_init_irq(void); 8 + extern void mmp2_init_icu(void); 9 + 7 10 #endif /* __IRQCHIP_MMP_H */