Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ieee802154: hwsim: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Stefan Schmidt <stefan@datenfreihafen.org>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-wpan/20231117095922.876489-11-u.kleine-koenig@pengutronix.de

authored by

Uwe Kleine-König and committed by
Miquel Raynal
9d4ccdef 99d8a4a2

+2 -4
+2 -4
drivers/net/ieee802154/mac802154_hwsim.c
··· 1035 1035 return err; 1036 1036 } 1037 1037 1038 - static int hwsim_remove(struct platform_device *pdev) 1038 + static void hwsim_remove(struct platform_device *pdev) 1039 1039 { 1040 1040 struct hwsim_phy *phy, *tmp; 1041 1041 ··· 1043 1043 list_for_each_entry_safe(phy, tmp, &hwsim_phys, list) 1044 1044 hwsim_del(phy); 1045 1045 mutex_unlock(&hwsim_phys_lock); 1046 - 1047 - return 0; 1048 1046 } 1049 1047 1050 1048 static struct platform_driver mac802154hwsim_driver = { 1051 1049 .probe = hwsim_probe, 1052 - .remove = hwsim_remove, 1050 + .remove_new = hwsim_remove, 1053 1051 .driver = { 1054 1052 .name = "mac802154_hwsim", 1055 1053 },