Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

regulator: scmi: Use int type to store negative error codes

Change the 'ret' variable from u32 to int to store negative error codes or
zero returned by of_property_read_u32().

Storing the negative error codes in unsigned type, doesn't cause an issue
at runtime but it's ugly as pants. Additionally, assigning negative error
codes to unsigned type may trigger a GCC warning when the -Wsign-conversion
flag is enabled.

No effect on runtime.

Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
Fixes: 0fbeae70ee7c ("regulator: add SCMI driver")
Link: https://patch.msgid.link/20250829101411.625214-1-rongqianfeng@vivo.com
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Qianfeng Rong and committed by
Mark Brown
9d35d068 899fb38d

+2 -1
+2 -1
drivers/regulator/scmi-regulator.c
··· 257 257 struct device_node *np, 258 258 struct scmi_regulator_info *rinfo) 259 259 { 260 - u32 dom, ret; 260 + u32 dom; 261 + int ret; 261 262 262 263 ret = of_property_read_u32(np, "reg", &dom); 263 264 if (ret)