tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

[PATCH] uml: request format warnings to GCC for appropriate functions

Add the format attribute to prototypes so GCC warns about improper usage.

Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Cc: Jeff Dike <jdike@addtoit.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

authored by

Paolo 'Blaisorblade' Giarrusso and committed by
Linus Torvalds 9cf85b3a 6dad2d3f

+8 -4
+2 -1
arch/um/include/tt/tt.h
··· 19 19 extern int do_proc_op(void *t, int proc_id); 20 20 extern int tracer(int (*init_proc)(void *), void *sp); 21 21 extern void attach_process(int pid); 22 - extern void tracer_panic(char *format, ...); 22 + extern void tracer_panic(char *format, ...) 23 + __attribute__ ((format (printf, 1, 2))); 23 24 extern void set_init_pid(int pid); 24 25 extern int set_user_mode(void *task); 25 26 extern void set_tracing(void *t, int tracing);
+4 -2
arch/um/include/user.h
··· 6 6 #ifndef __USER_H__ 7 7 #define __USER_H__ 8 8 9 - extern void panic(const char *fmt, ...); 10 - extern int printk(const char *fmt, ...); 9 + extern void panic(const char *fmt, ...) 10 + __attribute__ ((format (printf, 1, 2))); 11 + extern int printk(const char *fmt, ...) 12 + __attribute__ ((format (printf, 1, 2))); 11 13 extern void schedule(void); 12 14 extern void *um_kmalloc(int size); 13 15 extern void *um_kmalloc_atomic(int size);
+2 -1
arch/um/include/user_util.h
··· 55 55 extern void *um_kmalloc(int size); 56 56 extern int switcheroo(int fd, int prot, void *from, void *to, int size); 57 57 extern void do_exec(int old_pid, int new_pid); 58 - extern void tracer_panic(char *msg, ...); 58 + extern void tracer_panic(char *msg, ...) 59 + __attribute__ ((format (printf, 1, 2))); 59 60 extern int detach(int pid, int sig); 60 61 extern int attach(int pid); 61 62 extern void kill_child_dead(int pid);