Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[PATCH] nfsd: sign conversion obscuring errors in nfsd_set_posix_acl()

Assigning the result of posix_acl_to_xattr() to an unsigned data type
(size/size_t) obscures possible errors.

Coverity CID: 1206.

Signed-off-by: Florin Malita <fmalita@gmail.com>
Acked-by: NeilBrown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

authored by

Florin Malita and committed by
Linus Torvalds
9ccfc29c 2adc7d47

+3 -4
+3 -4
fs/nfsd/vfs.c
··· 1922 1922 value = kmalloc(size, GFP_KERNEL); 1923 1923 if (!value) 1924 1924 return -ENOMEM; 1925 - size = posix_acl_to_xattr(acl, value, size); 1926 - if (size < 0) { 1927 - error = size; 1925 + error = posix_acl_to_xattr(acl, value, size); 1926 + if (error < 0) 1928 1927 goto getout; 1929 - } 1928 + size = error; 1930 1929 } else 1931 1930 size = 0; 1932 1931