tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

Remove "must_check" attributes in PCI-land

Don't just irritate all other kernel developers. Fix the users first,
then you can re-introduce the must-check infrastructure to avoid new
cases creeping in.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>

Linus Torvalds 9c8550ee ac5b8b6f

+8 -8
+8 -8
include/linux/pci.h
··· 380 380 return pci_bus_write_config_dword (dev->bus, dev->devfn, where, val); 381 381 } 382 382 383 - int __must_check pci_enable_device(struct pci_dev *dev); 384 - int __must_check pci_enable_device_bars(struct pci_dev *dev, int mask); 383 + int pci_enable_device(struct pci_dev *dev); 384 + int pci_enable_device_bars(struct pci_dev *dev, int mask); 385 385 void pci_disable_device(struct pci_dev *dev); 386 386 void pci_set_master(struct pci_dev *dev); 387 387 #define HAVE_PCI_SET_MWI 388 - int __must_check pci_set_mwi(struct pci_dev *dev); 388 + int pci_set_mwi(struct pci_dev *dev); 389 389 void pci_clear_mwi(struct pci_dev *dev); 390 390 void pci_intx(struct pci_dev *dev, int enable); 391 - int __must_check pci_set_dma_mask(struct pci_dev *dev, u64 mask); 392 - int __must_check pci_set_consistent_dma_mask(struct pci_dev *dev, u64 mask); 391 + int pci_set_dma_mask(struct pci_dev *dev, u64 mask); 392 + int pci_set_consistent_dma_mask(struct pci_dev *dev, u64 mask); 393 393 void pci_update_resource(struct pci_dev *dev, struct resource *res, int resno); 394 394 int pci_assign_resource(struct pci_dev *dev, int i); 395 395 void pci_restore_bars(struct pci_dev *dev); ··· 403 403 /* Power management related routines */ 404 404 int pci_save_state(struct pci_dev *dev); 405 405 int pci_restore_state(struct pci_dev *dev); 406 - int __must_check pci_set_power_state(struct pci_dev *dev, pci_power_t state); 407 - pci_power_t __must_check pci_choose_state(struct pci_dev *dev, pm_message_t state); 408 - int __must_check pci_enable_wake(struct pci_dev *dev, pci_power_t state, int enable); 406 + int pci_set_power_state(struct pci_dev *dev, pci_power_t state); 407 + pci_power_t pci_choose_state(struct pci_dev *dev, pm_message_t state); 408 + int pci_enable_wake(struct pci_dev *dev, pci_power_t state, int enable); 409 409 410 410 /* Helper functions for low-level code (drivers/pci/setup-[bus,res].c) */ 411 411 void pci_bus_assign_resources(struct pci_bus *bus);