Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

regulator: Fix memory garbage dev_err printout.

commit dd8004af: 'regulator: core: Log when a device causes a voltage
constraint fail', tried to print out some information about the
check consumer min/max uV fixup, however, it uses a garbage pointer
left over from list_for_each_entry leading to boot messages in the
form:

'[ 2.079890] <RANDOM ASCII>: Restricting voltage, 3735899821-4294967295uV'

Because it references regulator->dev, it could potentially read memory from
anywhere causing a panic.

This patch instead uses rdev and the updated min/max uV values.

Signed-off-by: Russ Dill <Russ.Dill@ti.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

authored by

Russ Dill and committed by
Mark Brown
9c7b4e8a f2e5d078

+2 -2
+2 -2
drivers/regulator/core.c
··· 200 200 } 201 201 202 202 if (*min_uV > *max_uV) { 203 - dev_err(regulator->dev, "Restricting voltage, %u-%uuV\n", 204 - regulator->min_uV, regulator->max_uV); 203 + rdev_err(rdev, "Restricting voltage, %u-%uuV\n", 204 + *min_uV, *max_uV); 205 205 return -EINVAL; 206 206 } 207 207