Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

clk: mediatek: clk-mt8188-topckgen: Remove univpll from parents of mfg_core_tmp

Same as MT8195, MT8188 GPU clock is primarly supplied by the dedicated
mfgpll. The clock "mfg_core_tmp" is only used as an alt clock when
setting mfgpll clock rate.

If we keep the univpll parents from mfg_core_tmp, when setting
GPU frequency to 390000000, the common clock framework would switch
the parent to univpll, instead of setting mfgpll to 390000000:

mfgpll 0 0 0 949999756
univpll 2 2 0 2340000000
univpll_d6 1 1 0 390000000
top_mfg_core_tmp 1 1 0 390000000
mfg_ck_fast_ref 1 1 0 390000000
mfgcfg_bg3d 1 1 0 390000000

This results in failures when subsequent devfreq operations need to
switch to other frequencies. So remove univpll from the parent list.

This solution is taken from commit 72d38ed720e9 ("clk: mediatek:
clk-mt8195-topckgen: Drop univplls from mfg mux parents")

Signed-off-by: Pablo Sun <pablo.sun@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20240927103005.17605-3-pablo.sun@mediatek.com
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

authored by

Pablo Sun and committed by
Stephen Boyd
9bf7cfdb 43c04ed7

+6 -3
+6 -3
drivers/clk/mediatek/clk-mt8188-topckgen.c
··· 342 342 "univpll_d3" 343 343 }; 344 344 345 + /* 346 + * MFG can be also parented to "univpll_d6" and "univpll_d7": 347 + * these have been removed from the parents list to let us 348 + * achieve GPU DVFS without any special clock handlers. 349 + */ 345 350 static const char * const mfg_core_tmp_parents[] = { 346 351 "clk26m", 347 - "mainpll_d5_d2", 348 - "univpll_d6", 349 - "univpll_d7" 352 + "mainpll_d5_d2" 350 353 }; 351 354 352 355 static const char * const camtg_parents[] = {